From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BBE038B13D for ; Tue, 10 Mar 2026 14:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152038; cv=none; b=rE15/Zd9NRfg5msTAQ7gXgeILYVrzdZavEAuKgnE9SzxikxAYjB2TuOJIhl4nO3csFRAbyWMIEdX9phHLC3RkcaKL3FH/EF6E5kbEUZbYDWBUHck+7gtqF63yjeBaWmRghIHpK/pVhRIxT23cb0TUIdAjWkuzuzHcHN6x4qN5g0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152038; c=relaxed/simple; bh=TgyjPvdRcam0qo8VsSYVIapChIfqCnvkFJzQeUg7kf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MY6o/G+qGpxSDpogtCS3DsIt8zxgCzpyo7M8emleMp7SW6ckEdkLDpzLwq5cD9eW0uh7XWjI/8X7SPbOfOyIYjswG2LeHY9Gbsyh0pIuVsjp6hM8LLJPTYoEHPNWNbLXuISnCijH8amCHy0nTBDroLVxD86QgeXA0CF3R8CMalU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AV/e0rwm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LPKahM39; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AV/e0rwm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LPKahM39" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaZeB2862005 for ; Tue, 10 Mar 2026 14:13:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Sa+gULIzj+R2VtMLbbQ8yLiDMiRWe09PKwmLNCGVTQs=; b=AV/e0rwmZSB3iqAR IfFGhVgsnZmsZK5nYHmca/HF6ZW8kMEnIgvLePHBd7XnoA8nKYmZGQU2edBK6oHJ a1nbytXTBaI9zlrZc/dtrAqSWc6Yw6GauTn1ziUfJw+ciNMaiU7TFsfe7CSCzzaI Fcl3Xstxstn3NKblz4ZYMmFoaAVaId0E/nhiT8nhojHcxp6BQTgXnnnKXak5nIyz ZvSVGb6tTNPY3uYqxIZG9hmHKIuX6TjO2PqjOFt9E0ATX5ZXCxhFjPecLrkgkWk2 Xlxh2CCK2IlehMYAA1AciToYNEA1J9xmalZOm7TWm9DH8gRmQlWYIR5wTe8DYcb5 xMdyNQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cte3w9pb6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 14:13:55 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd7a2c535eso40555385a.3 for ; Tue, 10 Mar 2026 07:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773152035; x=1773756835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sa+gULIzj+R2VtMLbbQ8yLiDMiRWe09PKwmLNCGVTQs=; b=LPKahM39lgzYLdE90SbBFizZAKPsimZrJieBl6MDtpCwZbK6pBayaRfFcyizhB6FWs btobqroS4P9UlXup8M+igZPmOnIzLE0SyYw5iTfDDJMHaBHrNiQeLN68x1KVzCFW9HxU SzfPWGf5tDliXFlXqordcEH1ik/v/7rl9CdGWcxT6gYNvvyYfv1VOIMw2KVrgtkwFXam ckvk6LdvhisAysWTHN7U7e5pTlFJjaFtnzS2BYuAVyFpnKxvDG34UldMNpg4cjhsxSj8 vX28nvxp8b5xfrdXcMdKvm36UtIz4YhEQRWBmY0W1KT8180jUmbnkm9SBn/rcOxGsAvy phvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773152035; x=1773756835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sa+gULIzj+R2VtMLbbQ8yLiDMiRWe09PKwmLNCGVTQs=; b=jtgKoc2mK6HDY11w2JTY5tbA3GjocTnydGE0mtVcoATvMccSAb+Y8tEwdSrBvJsu7u qmFu+LhsPTmu38sjdNv7MYIKIVnwRtePP+ykOad3RDpgQRALLM0RO4sdQ7MMc15NOXQJ GaIxxjXfoekttVyHtS7WxUkpKpjvWNahE7XVTX4AAFSO8bqU1lDVpxYaY7ZLmlHzSWTe Yp7Upf9AwjxDpWZcWHpMuPNGDn0Mg/YtT2s5d8EbU/B8DYE4XVkJi816+5yr4SzWtVk+ 0ybrZhmx0/PycpYrOVI56ydhULhjcJknS6Fk5HP+Qei+2VSrUrM6azeH1hbnPzLju/va Zhzg== X-Forwarded-Encrypted: i=1; AJvYcCU6yPuWK/i+51vGTeFRk90KpIesgzxamaZVZCyjoPTOYcnoDwKw+6K9V3Oe0RSIK3iqF8p1KOERv7/CGiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxA5r2LSbzYtbpGIcDJ+8Q2zhEGufTo+XtM/UT7rD3F0QEEXmV4 +EZzZerydlxrTkWaWTt85AeXA08AooJFQQGbD7yeGlOkJCQwWxWlexFtuMVUvDwWw1gWO/0XAs5 89HtTUtbnCrY9k4pBGbEGzy7A4dEEFyYPpZ7DooG/lM+deled1H6gihjvkZeBcROAJqA= X-Gm-Gg: ATEYQzwJmevPaQrHoo1fEHRbYpGxRk6EelzckvhEVNXYCrMR6eHHzLxwJNRVZPjsQUx neVvowXpj7Hn3MsfXeunrPfKiNKINGWoRGBGxiDyVBWIjHue8vwA+rGnafTYAn0LHNDdxwtCHe0 E3falYE6bRw93K7d9hTp/dq/8QXkaKgUVCGS7WMYEZp6AUy0vC774XOolXQ6lqMju+ug+i0Riv/ TXvi8bBM0tIyk0U5MMbaj7WqXz3S2bTaFTXQYWlspY2xr4MOwez1ksvpUMUavUM/soKiIkHipor FaBd0dTJtcCDsiKvsrc9tQIqm4SgZ5BqKXDdO7dRXMenXIizesZI/dGwR4pPjqxb4C7wBZVzyvM 7i/3Sh4S3fpEjBVQzGQ9ailuv2zF+vXirplm4/3moMP52MOpxxfBKiTS3CB1KS1S2jbBPAIP5W6 3T1Lo= X-Received: by 2002:a05:620a:45a0:b0:8cd:8d50:16a0 with SMTP id af79cd13be357-8cd8d501f65mr624306985a.3.1773152034680; Tue, 10 Mar 2026 07:13:54 -0700 (PDT) X-Received: by 2002:a05:620a:45a0:b0:8cd:8d50:16a0 with SMTP id af79cd13be357-8cd8d501f65mr624300385a.3.1773152034121; Tue, 10 Mar 2026 07:13:54 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a4fd67f1sm4239660a12.22.2026.03.10.07.13.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 07:13:53 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 15:13:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEyNCBTYWx0ZWRfXySjKlMZZu3dd 6YdHNtGrAuMC78twF3DLVxt8vMCuVTS4W3AyZXivvOJ+ko9sgj5zJwx/ysYEgjFcIE0q41XOoNx M5WDCEdewzk9NWrZ+n8at23YeyffxPyPj50qg+VgMrEuDGAVaZ8Qo4V30uAH41s7RfJ9otKj1JC K3sO4FCqNGEuG+jjCpVLTKG4+NJeoxxP87/OHv0/ohKJpRsO3/KdI8ywYXRx0RTVmTjvKQXl9sb 36Wcp6GZWmdzs5Rh+2h742/muedFaaJcoFx/3D5ss8GIPZTqBgticPNE8qw1BAbG/OiFaxfbsPU JbJxvNYpYSgE7g8RqUgYS+IfXRGWqwt6llv8Jn6r3og19MbiDdDgRF7qWBV/guhwTSQd0yJbxny G9b7Sk5JaYMP5jOrzX6PjEQhIOw50zu3JQo62X+eUSA5G7TtlGfHAya9eJNMdO9O0Rb2Ei02zky A6db4RAXfkJpRWHq0Sg== X-Authority-Analysis: v=2.4 cv=GtFPO01C c=1 sm=1 tr=0 ts=69b02723 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=T5VBltHwqSPm6ePZaXsA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: Wi0gEePcxCT0kcLLe5S5JL5A37hJO3Vk X-Proofpoint-GUID: Wi0gEePcxCT0kcLLe5S5JL5A37hJO3Vk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100124 On 3/10/26 9:06 AM, Harshal Dev wrote: > Update the inline-crypto engine DT binding to allow specifying up to two > clocks along with their names and associated power-domain. When the > 'clk_ignore_unused' flag is not passed on the kernel command line > occasional unclocked ICE hardware register access are observed during ICE > driver probe based on the relative timing between the probe and the kernel > disabling the unused clocks. On the other hand, when the 'pd_ignore_unused' > flag is not passed on the command line, clock 'stuck' issues are > observed if the power-domain required by ICE hardware is unused and thus > disabled before ICE probe. To avoid these scenarios, the 'iface' clock and > the associated power-domain should be specified in the ICE device tree node > and the 'iface' clock should be voted on by the ICE driver during probe. > > Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engine") > Signed-off-by: Harshal Dev > --- > .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > index c3408dcf5d20..d9a0a8adf645 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > @@ -28,6 +28,16 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + items: > + - const: ice_core_clk > + - const: iface_clk Trim the "_clk", we know they're clocks, because they come under.. you know.. the 'clocks' property! :D Konrad