From: shaozhengchao <shaozhengchao@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"weiyongjun (A)" <weiyongjun1@huawei.com>,
yuehaibing <yuehaibing@huawei.com>
Subject: 答复: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops
Date: Wed, 6 Jul 2022 01:52:38 +0000 [thread overview]
Message-ID: <a92ed8b2b01e499b986ad7b9b0fe93a8@huawei.com> (raw)
In-Reply-To: <20220705184326.649a4e04@kernel.org>
-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@kernel.org]
发送时间: 2022年7月6日 9:43
收件人: shaozhengchao <shaozhengchao@huawei.com>
抄送: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; jhs@mojatatu.com; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; weiyongjun (A) <weiyongjun1@huawei.com>; yuehaibing <yuehaibing@huawei.com>
主题: Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops
On Mon, 4 Jul 2022 20:43:22 +0800 Zhengchao Shao wrote:
> Return value of unregister_tcf_proto_ops is useless, remove it.
s/useless/unused/ ?
Should we add a WARN if the ops getting removed can't be found or there are callers which depend on handling unregistered ops without a warning?
Hi Jakub Kicinski:
Thank you for your apply. This patch does just remove the return value and change the function type from int to void. It doesn't remove the function.
Zhengchao Shao
next prev parent reply other threads:[~2022-07-06 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 12:43 Zhengchao Shao
2022-07-06 1:43 ` Jakub Kicinski
2022-07-06 1:52 ` shaozhengchao [this message]
2022-07-06 19:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a92ed8b2b01e499b986ad7b9b0fe93a8@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®