From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-209.mta0.migadu.com [91.218.175.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44C22DB789 for ; Sun, 20 Sep 2026 03:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.209 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789874965; cv=none; b=mdiIZX6/xU0i1tqzw/xzUfqgBkTWZAbdQFzEjC9gfHIU3QY4JvPYzG4tjSKpJQEepxnNTO7TZhsRgImrncQgdu5hqhl9ZwCtZWQF2pZnWB4KIgM8OQfLb/1Ucho008mEyBk3WZltLBDvyAlbLWQ8GstklxZaig+ehTclqXjS7xE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789874965; c=relaxed/simple; bh=7t9pgJ258Rrl5dDQjj8X+z+ssND9xQQoxEd4N7iBmDA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=az+EBp+jrokN/UmxiKRLd0DtHlmqEad+flD6jzkgmhs1KahwgkW9gfICmECR0r/FjKcV3ZjgLZBH0t5NZp7yKexijaAh4/PV3A9VOMk33YRDe9DqRmP8Kjt/V/zjh45e1wPSYc1jc/FSN69b4C4JHCbFnTNUY1KO180k3l37Ing= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=a/dbhuOv; arc=none smtp.client-ip=91.218.175.209 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="a/dbhuOv" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=7t9pgJ258Rrl5dDQjj8X+z+ssND9xQQoxEd4N7iBmDA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789874961; v=1; x=1790479761; b=a/dbhuOvBedqB60bdEBAj4jNrIQA4Kq75IjusovlAOLhiMw/eRAkcCgvcM/T3HbMQMqgxLjK ZRDP3RdEr9KtrZACnGHRuLnVxyIjuRJEWP+i7C8UACUPJam1GJnXxkFBlc6ljpwZ46R3kIqtXcc RJWi3/M+xPvJjrOLTJkXHPYc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 43907a8009874808; Sun, 20 Sep 2026 03:29:21 +0000 X-Mizu-Trace-ID: 43907a8009874808 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Sun, 20 Sep 2026 11:29:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cgroup/cpuset: Remove redundant sched domain rebuild from update_prstate() To: Guopeng Zhang , Waiman Long Cc: Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Guopeng Zhang References: <20260920025256.24991-1-guopeng.zhang@linux.dev> From: Ridong Chen In-Reply-To: <20260920025256.24991-1-guopeng.zhang@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/20/2026 10:52 AM, Guopeng Zhang wrote: > From: Guopeng Zhang > > Both callers of update_prstate(), cpuset_partition_write() and > cpuset_css_killed(), call cpuset_update_sd_hk_unlock() immediately > afterwards. That helper rebuilds sched domains when force_sd_rebuild is > set before releasing the cpuset locks, so the check in update_prstate() > is redundant. > > Commit 3bfe47967191 ("cgroup/cpuset: Move > housekeeping_update()/rebuild_sched_domains() together") removed the > same check from cpuset_write_resmask(). Remove the remaining one from > update_prstate(). > > Signed-off-by: Guopeng Zhang > --- > Changes in v2: > - Rename the patch to avoid the misleading "defer" wording. > > kernel/cgroup/cpuset.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 8f24171b6055..d58ecf56f384 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3039,8 +3039,6 @@ out: > update_partition_sd_lb(cs, old_prs); > > notify_partition_change(cs, old_prs); > - if (force_sd_rebuild) > - rebuild_sched_domains_locked(); > free_tmpmasks(&tmpmask); > return 0; > } Reviewed-by: Ridong Chen Thanks. -- Best regards Ridong