From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DEBC10F03 for ; Fri, 1 Mar 2019 08:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7E152186A for ; Fri, 1 Mar 2019 08:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387441AbfCAIPq convert rfc822-to-8bit (ORCPT ); Fri, 1 Mar 2019 03:15:46 -0500 Received: from smtp.asem.it ([151.1.184.197]:64184 "EHLO smtp.asem.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732008AbfCAIPp (ORCPT ); Fri, 1 Mar 2019 03:15:45 -0500 Received: from webmail.asem.it by asem.it (smtp.asem.it) (SecurityGateway 5.5.0) with ESMTP id SG003724702.MSG for ; Fri, 01 Mar 2019 09:15:39 +0100S Received: from ASAS044.asem.intra (172.16.16.44) by ASAS044.asem.intra (172.16.16.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Fri, 1 Mar 2019 09:15:39 +0100 Received: from ASAS044.asem.intra ([::1]) by ASAS044.asem.intra ([::1]) with mapi id 15.01.1261.035; Fri, 1 Mar 2019 09:15:39 +0100 From: Flavio Suligoi To: David Miller , "andrew@lunn.ch" CC: "jeffrey.t.kirsher@intel.com" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "andrew@lunn.ch" Subject: RE: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter Thread-Topic: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter Thread-Index: AQHUz2za8U5Pv4cZVkOebP6EQ2CVPqX1RhaAgAAUBLD///4SgIAAFXBwgAAawQCAAATLgIAA4SNg Date: Fri, 1 Mar 2019 08:15:39 +0000 Message-ID: References: <20190228163729.GB17912@lunn.ch> <6a7a37813e71420b929c769dd1e77664@asem.it> <20190228192958.GA24085@lunn.ch> <20190228.114707.11382969767373748.davem@davemloft.net> In-Reply-To: <20190228.114707.11382969767373748.davem@davemloft.net> Accept-Language: it-IT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.17.161] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SGHeloLookup-Result: pass smtp.helo=webmail.asem.it (ip=172.16.16.44) X-SGSPF-Result: none (smtp.asem.it) X-SGOP-RefID: str=0001.0A0B0207.5C78EA2C.0052,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 (_st=1 _vt=0 _iwf=0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> > Hi Flavio > >> > > >> > u-boot should be able to write the MAC address in the correct part of > >> > device tree. Boards have been doing this a long time. > >> > > >> > Module parameters are considered bad. You should only do it if you > >> > have no other option. Here you do have another options, so it is > going > >> > to be a hard sell getting David to access your patch. > >> > > >> > You will have more success by adding a call to > >> > eth_platform_get_mac_address() to the e1000e driver. > >> > >> You have right, and thanks for your suggestions, > >> but with a kernel parameter I can use the same method > >> for any board where the NVM is missed, independently of any > architecture > >> (with or without the device tree presence - ARM or x86 or others). > > > > Hi Flavio > > > > Well, lets wait for David to say what he thinks about the module > > parameter. > > I already rejected this, no way... Drivers that already have the > unacceptable module parameter are no an argument for spreading this > mistake further. Hi David and Andrew, ok, thank you for your suggestions and your time! Flavio