From: Hanjun Guo <guohanjun@huawei.com>
To: Kazuhiro Abe <fj1078ii@aa.jp.fujitsu.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v4] ACPI: AGDI: Add interrupt signaling mode support
Date: Mon, 20 Oct 2025 21:23:05 +0800 [thread overview]
Message-ID: <a93e845a-b084-a680-7158-68363c492b75@huawei.com> (raw)
In-Reply-To: <20251017073935.1746365-1-fj1078ii@aa.jp.fujitsu.com>
On 2025/10/17 15:39, Kazuhiro Abe wrote:
> AGDI has two types of signaling modes: SDEI and interrupt.
> Currently, the AGDI driver only supports SDEI.
> Therefore, add support for interrupt signaling mode
> The interrupt vector is retrieved from the AGDI table, and call panic
> function when an interrupt occurs.
>
> Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> Signed-off-by: Kazuhiro Abe <fj1078ii@aa.jp.fujitsu.com>
> ---
> Hanjun, I have addressed all your comments.
> Please review them.
>
> v3->v4
> - Add a comment to the flags member.
> - Fix agdi_interrupt_probe.
> - Fix agdi_interrupt_remove.
> - Add space in struct initializsation.
> - Delete curly braces.
Looks good to me,
Acked-by: Hanjun Guo <guohanjun@huawei.com>
Thanks
Hanjun
next prev parent reply other threads:[~2025-10-20 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:39 Kazuhiro Abe
2025-10-20 13:23 ` Hanjun Guo [this message]
2025-11-04 16:06 ` Will Deacon
2025-11-06 1:19 ` Kazuhiro Abe (Fujitsu)
2025-11-10 7:38 ` Kazuhiro Abe (Fujitsu)
2025-11-12 4:42 ` Charles Mirabile
2025-11-12 9:18 ` Kazuhiro Abe (Fujitsu)
2025-11-12 9:50 ` Lorenzo Pieralisi
2025-11-14 8:21 ` Kazuhiro Abe (Fujitsu)
2025-11-14 15:20 ` Charles Mirabile
2025-11-14 15:23 ` Will Deacon
2025-11-18 7:29 ` Hanjun Guo
2025-11-18 10:09 ` Kazuhiro Abe (Fujitsu)
2025-11-20 13:27 ` Hanjun Guo
2025-11-21 2:31 ` Kazuhiro Abe (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a93e845a-b084-a680-7158-68363c492b75@huawei.com \
--to=guohanjun@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=fj1078ii@aa.jp.fujitsu.com \
--cc=ilkka@os.amperecomputing.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®