From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E713A873B for ; Tue, 7 Apr 2026 11:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560723; cv=none; b=geWG1k8Eyo3jQuHYByrphEn29fa83r/4aYYSiUxHeOvoumViWGnvy+b2LN2x6XTkyC+OTa4RNs3yTmeBMO7hTixGYL0vcbWpL5PQL0pVxfy/RyixoUG/ty/ujpjPZW39TBtu70go2Id8mwqoS4CHuEwj7HwKzSbF5WCXKGALeX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560723; c=relaxed/simple; bh=w9cnIu+knTgg65YCw5dht36ngdUu2Y2zhB3WJV8QGBY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XnDse04pmqCfLNG2yNaYFlg7rd2jAUoFtJUdXRbksjY1Xy04AXDIeDup3WDz9HGQsnzH+mk6yIRQho/aAfE8fqKinDCwZw129xv6XCuMeBLMAQOF5ps5JT05dU7KO26WeQzJdyEjbMhasIHtrsUjCxiyachJBylOsXakxtQ0G2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ae9PeUV8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gp4LqTY3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ae9PeUV8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gp4LqTY3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376bI2q2550167 for ; Tue, 7 Apr 2026 11:18:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r3lOjc0t4VF0qA7I7ug+FZIFW2JOa5qp1tmA8m6o8bY=; b=ae9PeUV8ezUyTDLq ndqzM3OLFwVVyCHrNPszhJlk4nWmHAZaFddWbfDuMMzNTENmYYpQe8KQKuD28RjY PAzCvAv1OsFA010dFiKc+07R38hjiFOty6gmEk/j22h1CUVxSnJHhUNM73omZylw 3N65elgWlpaQTUSm+EIKJ1+ErE9ohfm0g98yyaDT4QOIYzhi1wjoddhc7BNdxuBL U5oBEz7PMwDuFpJlX5hUiyh/wROP3Y3mxndIfhWqzzN66/YULPOdv+GLTjFQkAIi O1mLzfLrrHwJDb0s2IhL1dXKN8awUttelsubrDiv4URVyoIDC0w+S7s/+FH/3D0t pklBpA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmreafgn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:18:40 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d8c183c2eso18811811cf.0 for ; Tue, 07 Apr 2026 04:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775560719; x=1776165519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r3lOjc0t4VF0qA7I7ug+FZIFW2JOa5qp1tmA8m6o8bY=; b=gp4LqTY3ctRU2KCCBJibvcA8cMh14yBnoU7AKvKC0v+oFHDsNPQz+L07Rvv48M8M7T +UD+Cak9cUFQJwFFwm9PNgxHOPIbCdDnhD/h94dNA/x+CgHQ5qcDQGc7Ek80O4TJ33Aa 3SAkudaT/IgXadP53fPTdsKyKtUPP5MvXMEArA/eJoFRl2z0B453euLUghlgjFkSBU5q +ukEvLThs96GqjFTLF7WWYeZCiyPA4tq/lq2k10nMzPRQVoTrsYH6AxU7OK1mS1KwLc2 Ab32Whge+tqhKHGfVCJrf5dQDF/vLsXA3JxD7I6u1T5Gz2hYMnL3D4v5TUvkwjAZcaqL diRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775560719; x=1776165519; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r3lOjc0t4VF0qA7I7ug+FZIFW2JOa5qp1tmA8m6o8bY=; b=ViJs/HMuGrxZuhnwmeI9XU0l+bJgmrn/loW68FlfgGAuamto2ABPihpwyaMosDuzhJ U+15nTjqd26fo+klVNSc2d+aCthgNV7G63/tzNSTd9TPRDaTUFaV2gOTjc5mt3AR/WMe osziY2tcpzg8I+qe9n2VONVAdeWbBAikvgE7Edt0FWiRrsT00wIDFihXEX0yBSUdJ1Lq 8VUDlY4SZ/H3sajzNCKiqux3wxKLCNxMZ3zRYKIv32c4pAbtiIGGDhwI2MyeKeJQa+J7 vk9/l9zjaYZoNrMxtNm2sfdXIwxyXSFYIqIKotlYz6jB717J4HmAHDydXvsZY80y3Kuv ShTw== X-Forwarded-Encrypted: i=1; AJvYcCWr6D/PMmPkWV36MU4MfJsn7eJY7EAQdUN2OQBOuu0omVwnRoLb7uNULPCDTzqI3CVyj28ajQmgejMImA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxvTja51CRI/ZJ/lLQkrW4XYkaQLyHbILhV/NsuRmhJDDcIe476 pBTaCA/GB5vj4V5bqFkffBXBLKk9h+DFznBggVXm03cGQJ0PMMg2UR/en/yhLd9DE79x7zHk6d1 t/+8QfQHigjPzZwJ02s43sKq/MKAa46xwt8s1FBRNsvbrZSj5uQRPGSLFLexsV6dj/s8= X-Gm-Gg: AeBDievcjEUneClpQu0qlErXUvToyCoYUrkqLzs/+mLD5wUGz9y70vs0iwTgE874ESe t/Wu9/fmIi9PPIipww+HQrUsFweN16rGA5ySY6cSGnTXZ0O2JzBiu0xyqxo4BocZIzMwIBdQbKn 1LHtUZy5T8J79DlxmRddMU4imjp/aDIp1Nmt/NrAHC9xpYVswzvN4Z756UO+ZWsfrGo5otgn1Or /z/oNRLVraJryATx0vSic8JzH0RjFC9oVvbHY3Dn3t7cV8fZWo+x5FLL8JcZvSoTlqacVUPO8lN Bqw6XrYUQ1veL/+4eW8PQHUVG0paq0BLwcn0hO2RsQ1ku6EaGAt5Unj95nqwuXWvh1hF8djKrtJ JmdwOUvCcxXabYLQSemYvWjI+7Vg33r/4l6gDs/7NCflrQhlwjKZYByubNAArqmDK+YyrmyGj1f ax19k= X-Received: by 2002:a05:622a:260b:b0:50b:5286:f756 with SMTP id d75a77b69052e-50d62c83682mr180228671cf.6.1775560718863; Tue, 07 Apr 2026 04:18:38 -0700 (PDT) X-Received: by 2002:a05:622a:260b:b0:50b:5286:f756 with SMTP id d75a77b69052e-50d62c83682mr180228531cf.6.1775560718435; Tue, 07 Apr 2026 04:18:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66e034bb78esm4545183a12.24.2026.04.07.04.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:18:37 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 13:18:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Add iface clock for ice sdhc To: Kuldeep Singh , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406-ice_emmc_clock_addition-v1-0-e7b237bf7a69@oss.qualcomm.com> <20260406-ice_emmc_clock_addition-v1-1-e7b237bf7a69@oss.qualcomm.com> <8ea92c00-56ca-47cd-95aa-dbf49ecf4118@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OKEXGyaB c=1 sm=1 tr=0 ts=69d4e810 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=yFPsli0tPFyAm-MtiuoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 8ZJ90UMHyrZHyX1vPqiwYb2z7DBMQ77i X-Proofpoint-ORIG-GUID: 8ZJ90UMHyrZHyX1vPqiwYb2z7DBMQ77i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwNSBTYWx0ZWRfXwm6IqZ7tRAVZ VnajUM4sJm3F8fzWoOiiRo8T2K72hfoONOZFX+NJBgh31BlEEds5dwoUo9t2IGepbXRz43lhUL+ 0xu8LW2Jtvf9C8VIgdQFv8heRvlHbDsiakza+/KzOgUOfNpDg5Z72nVWsEuSHH5Ir93qNPl778V z26aRn+07ysnjXp9SKo7I0RM8XN936NnIS8dp0z5PJmV154bVrOVaaKAr+Oqr/1icz6Fki93xPt AMiiTYv9DNXlBSaPsOxCSV2qviYmGzg9lnFoc0U8HwhmdGQKvV1I48o0R4YMOhs8N/ESA77eKnH 3zrESJbtwOh+2DIAQfPUzV3O0YLrne1llSkTPBOxokpwq7aACTrhso1SVNyCwFplD5uGaG0KDfm PyaNtUBIYV171iYgBew/bN8az0JX7UAWkk3rb5NbO9LXBV+fC/JEMbIA7WwX54++Pyn83gzLrwK R2vm4RmKsAccs4mj5KA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070105 On 4/7/26 1:09 PM, Kuldeep Singh wrote: >>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> index dda4697a61b7..5e6b659e8719 100644 >>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> @@ -1082,7 +1082,8 @@ sdhc_ice: crypto@7c8000 { >>> compatible = "qcom,sc7280-inline-crypto-engine", >>> "qcom,inline-crypto-engine"; >>> reg = <0x0 0x007c8000 0x0 0x18000>; >>> - clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; >>> + clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >>> + clock-names = "core", "iface"; >> >> nit: one a line would be preferred, please fix that up as you seemingly >> need a v2 anyway > > Hi Konrad, Didn't get your comment completely. > > Do I need to send v2 to just fix clock entries in 2 lines? > Or some other comment to address and send v2 for that? > I don't see any other comment on patchset to address. I didn't see your reply to Dmitry's initial comment about the DT bindings requiring an update. I'd prefer if you sent a v2 with that formatting change. Patches will not be merged for some ~3 weeks now, due to the kernel release cycle so it'll have to wait a bit anyway Konrad