From: Joe Perches <joe@perches.com>
To: Qing Wang <wangqing@vivo.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: si21xx: use time_after_eq() instead of jiffies judgment
Date: Thu, 10 Feb 2022 01:07:19 -0800 [thread overview]
Message-ID: <a940cf331d493c8755454e8557c2330901e30986.camel@perches.com> (raw)
In-Reply-To: <1644481917-14908-1-git-send-email-wangqing@vivo.com>
On Thu, 2022-02-10 at 00:31 -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> It is better to use time_xxx() directly instead of jiffies judgment
> for understanding.
[]
> diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
[]
> @@ -336,7 +336,7 @@ static int si21xx_wait_diseqc_idle(struct si21xx_state *state, int timeout)
> dprintk("%s\n", __func__);
>
> while ((si21_readreg(state, LNB_CTRL_REG_1) & 0x8) == 8) {
> - if (jiffies - start > timeout) {
> + if (time_after(jiffies, start + timeout)) {
> dprintk("%s: timeout!!\n", __func__);
> return -ETIMEDOUT;
> }
Appreciate all the conversions (IMO it should have been sent as
a block of patches with a cover letter instead of independent
unrelated patches) but wouldn't all of these be simpler and more
consistent using a style where the addition is done once and the
timeout test is something like:
unsigned long end = jiffies + timeout;
while (foo) {
if (time_after(jiffies, end)) {
error_msg(...)
return -ETIMEDOUT;
}
bar...;
}
prev parent reply other threads:[~2022-02-10 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 8:31 Qing Wang
2022-02-10 9:07 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a940cf331d493c8755454e8557c2330901e30986.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®