From: Randy Dunlap <rdunlap@infradead.org>
To: Dongliang Mu <dzm91@hust.edu.cn>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] docs: Improve wording in Sphinx dependency checker
Date: Thu, 29 Oct 2026 08:29:22 -0700 [thread overview]
Message-ID: <a9417893-b7ad-4f9b-b8dc-93a41eb7ff46@infradead.org> (raw)
In-Reply-To: <e0415ef0-205b-442d-8e4c-46b72da9fc83@hust.edu.cn>
On 10/29/26 5:51 AM, Dongliang Mu wrote:
>
> On 10/28/26 8:07 AM, Randy Dunlap wrote:
>> Hi,
>>
>> On 10/27/26 10:07 AM, Dongliang Mu wrote:
>>> @@ -784,10 +782,10 @@ class SphinxDependencyChecker(MissingCheckers):
>>> if not self.distro_msg:
>>> self.distro_msg = \
>>> "Note: RHEL-based distros typically require extra repositories.\n" \
>>> - "For most, enabling epel and crb are enough:\n" \
>>> + "For most, enabling EPEL and CRB is enough:\n" \
>> I think that "are" is correct here since the subject is plural.
>
>
> From my understanding, enabling XXX is the subject, so I change it to "is". However, this is not very clear.
>
> How about "For most, the EPEL and CRB repositories are enough:\n"? This seems more clear.
Fine with me. Thanks.
--
~Randy
next prev parent reply other threads:[~2026-10-29 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 16:56 [PATCH 0/2] docs: Update " Dongliang Mu
2026-10-27 16:56 ` [PATCH 1/2] docs: Recognize Deepin for dependency hints Dongliang Mu
2026-10-27 17:06 ` Mauro Carvalho Chehab
2026-10-27 17:10 ` Dongliang Mu
2026-10-28 0:42 ` Mauro Carvalho Chehab
2026-10-27 17:07 ` [PATCH 2/2] docs: Improve wording in Sphinx dependency checker Dongliang Mu
2026-10-28 0:07 ` Randy Dunlap
2026-10-29 12:51 ` Dongliang Mu
2026-10-29 15:29 ` Randy Dunlap [this message]
2026-10-28 0:58 ` Mauro Carvalho Chehab
2026-10-29 12:59 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9417893-b7ad-4f9b-b8dc-93a41eb7ff46@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=dzm91@hust.edu.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®