From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969189AbdDTGtm (ORCPT ); Thu, 20 Apr 2017 02:49:42 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:40033 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968521AbdDTGrh (ORCPT ); Thu, 20 Apr 2017 02:47:37 -0400 Subject: Re: [PATCH] gpu: host1x: select IOMMU_IOVA To: Arnd Bergmann , Thierry Reding References: <20170419182449.885312-1-arnd@arndb.de> Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org From: Mikko Perttunen Message-ID: Date: Thu, 20 Apr 2017 09:47:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170419182449.885312-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.209.167.43 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ah, had to forget something :) Reviewed-by: Mikko Perttunen On 19.04.2017 21:24, Arnd Bergmann wrote: > When IOMMU_IOVA is not built-in but host1x is, we get a link error: > > drivers/gpu/host1x/dev.o: In function `host1x_remove': > dev.c:(.text.host1x_remove+0x50): undefined reference to `put_iova_domain' > drivers/gpu/host1x/dev.o: In function `host1x_probe': > dev.c:(.text.host1x_probe+0x31c): undefined reference to `init_iova_domain' > dev.c:(.text.host1x_probe+0x38c): undefined reference to `put_iova_domain' > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_init': > cdma.c:(.text.host1x_cdma_init+0x238): undefined reference to `alloc_iova' > cdma.c:(.text.host1x_cdma_init+0x2c0): undefined reference to `__free_iova' > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_deinit': > cdma.c:(.text.host1x_cdma_deinit+0xb0): undefined reference to `free_iova' > > This adds the same select statement that we have for drm_tegra. > > Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/host1x/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig > index b2fd029d67b3..91916326957f 100644 > --- a/drivers/gpu/host1x/Kconfig > +++ b/drivers/gpu/host1x/Kconfig > @@ -1,6 +1,7 @@ > config TEGRA_HOST1X > tristate "NVIDIA Tegra host1x driver" > depends on ARCH_TEGRA || (ARM && COMPILE_TEST) > + select IOMMU_IOVA if IOMMU_SUPPORT > help > Driver for the NVIDIA Tegra host1x hardware. > >