From: Mike Travis <mike.travis@hpe.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Don Zickus <dzickus@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Frank Ramsay <frank.ramsay@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
Tony Ernst <tony.ernst@hpe.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/platform: Add a low priority low frequency NMI call chain
Date: Tue, 7 Mar 2017 07:38:39 -0800 [thread overview]
Message-ID: <a94f6a74-3810-db6f-c461-910c59c18446@hpe.com> (raw)
In-Reply-To: <20170307074210.GA24782@gmail.com>
On 3/6/2017 11:42 PM, Ingo Molnar wrote:
>
> * Mike Travis <mike.travis@hpe.com> wrote:
>
>> Add a new NMI call chain that is called last after all other NMI handlers
>> have been checked and did not "handle" the NMI. This mimics the current
>> NMI_UNKNOWN call chain except it eliminates the WARNING message about
>> multiple NMI handlers registering on this call chain.
>>
>> This call chain dramatically lowers the NMI call frequency when high
>> frequency NMI tools are in use, notably the perf tools. It is required
>> for NMI handlers that cannot sustain a high NMI call rate without
>> ramifications to the system operability.
>
> So how about we just turn off that warning instead? I don't remember the last time
> it actually _helped_ us find any kernel or hardware bug - and it has caused tons
> of problems...
I can do that, with an even simpler patch...
>
> It's not like we warn about excess regular IRQs either - we either handle them or
> at most increase a counter somewhere. We could do the same for NMIs: introduce a
> counter somewhere that counts the number of seemingly unhandled NMIs.
Really "unknown" NMI errors are reported by either the "dazed and
confused" message or if the panic on unknown nmi is set, then the
system will panic. So unknown NMI occurrences are already being
dealt with.
Plus the following stats are being collected, though I'm not sure of
any reporting facility:
struct nmi_stats {
unsigned int normal;
unsigned int unknown;
unsigned int external;
unsigned int swallow;
};
static DEFINE_PER_CPU(struct nmi_stats, nmi_stats);
>
> But in any case, we should not spam the kernel log, neither with high, nor with
> low frequency.
>
> Thanks,
>
> Ingo
>
next prev parent reply other threads:[~2017-03-07 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 18:17 [PATCH 0/2] Add and Use NMI LAST call chain to eliminate WARNING message Mike Travis
2017-03-06 18:17 ` [PATCH 1/2] x86/platform: Add a low priority low frequency NMI call chain Mike Travis
2017-03-07 7:42 ` Ingo Molnar
2017-03-07 15:22 ` Don Zickus
2017-03-07 16:00 ` Mike Travis
2017-03-07 16:07 ` Don Zickus
2017-03-07 16:13 ` Mike Travis
2017-03-07 15:38 ` Mike Travis [this message]
2017-03-08 10:28 ` Ingo Molnar
2017-03-08 15:17 ` Mike Travis
2017-03-06 18:17 ` [PATCH 2/2] x86/platform/uv: Use " Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a94f6a74-3810-db6f-c461-910c59c18446@hpe.com \
--to=mike.travis@hpe.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dimitri.sivanich@hpe.com \
--cc=dzickus@redhat.com \
--cc=frank.ramsay@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=russ.anderson@hpe.com \
--cc=tglx@linutronix.de \
--cc=tony.ernst@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®