From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 08AD1C433EF
	for <linux-kernel@archiver.kernel.org>; Mon, 24 Jan 2022 08:49:53 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242284AbiAXItw (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 24 Jan 2022 03:49:52 -0500
Received: from mout01.posteo.de ([185.67.36.141]:55419 "EHLO mout01.posteo.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S242605AbiAXItk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jan 2022 03:49:40 -0500
Received: from submission (posteo.de [89.146.220.130]) 
        by mout01.posteo.de (Postfix) with ESMTPS id BDD19240029
        for <linux-kernel@vger.kernel.org>; Mon, 24 Jan 2022 09:49:39 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
        by submission (posteo.de) with ESMTPSA id 4Jj3ZT5mpkz9rxM;
        Mon, 24 Jan 2022 09:49:37 +0100 (CET)
Message-ID: <a9504cb7-817d-9e50-1669-51e97d3e4347@posteo.net>
Date:   Mon, 24 Jan 2022 08:49:37 +0000
MIME-Version: 1.0
Subject: Re: [PATCH 02/11] serial: atmel_serial: include circ_buf.h
Content-Language: fr-FR
To:     Jiri Slaby <jslaby@suse.cz>, gregkh@linuxfoundation.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        johan@kernel.org, Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        Richard Genoud <richard.genoud@gmail.com>
References: <20220124071430.14907-1-jslaby@suse.cz>
 <20220124071430.14907-3-jslaby@suse.cz>
 <f01d8a90-973f-9492-a89a-a6a82435b731@posteo.net>
From:   Richard Genoud <richard.genoud@gmail.com>
In-Reply-To: <f01d8a90-973f-9492-a89a-a6a82435b731@posteo.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 24/01/2022 à 09:46, Richard Genoud a écrit :
> 
> Le 24/01/2022 à 08:14, Jiri Slaby a écrit :
>> atmel_uart_port::rx_ring is defined as struct circ_buf, but circ_buf.h
>> is not included explicitly in atmel_serial.c. It is included only
>> implicitly via serial_core.h. Fix this as serial_core.h might not
>> include that header in the future.
>>
>> Signed-off-by:Jiri Slaby <jslaby@suse.cz>
>> Cc: Richard Genoud <richard.genoud@gmail.com>
>> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
>> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
>> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>

Sorry, I really meant acked-by, not Signed-off-by :
Acked-by: Richard Genoud <richard.genoud@gmail.com>

>> ---
>>   drivers/tty/serial/atmel_serial.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index c370eddc651b..2d09a89974a2 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -8,6 +8,7 @@
>>    *
>>    *  DMA support added by Chip Coldwell.
>>    */
>> +#include <linux/circ_buf.h>
>>   #include <linux/tty.h>
>>   #include <linux/ioport.h>
>>   #include <linux/slab.h>
Thanks !