From: Jan Kiszka <jan.kiszka@siemens.com>
To: Sumit Garg <sumit.garg@linaro.org>, op-tee@lists.trustedfirmware.org
Cc: jens.wiklander@linaro.org, arnd@linaro.org, ardb@kernel.org,
jerome.forissier@linaro.org, ilias.apalodimas@linaro.org,
masahisa.kojima@linaro.org, maxim.uvarov@linaro.org,
jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org,
"Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@siemens.com>
Subject: Re: [PATCH v2] tee: optee: Fix supplicant based device enumeration
Date: Wed, 11 Oct 2023 16:45:29 +0200 [thread overview]
Message-ID: <a9515560-32bc-4f3b-a36c-87f7242081a9@siemens.com> (raw)
In-Reply-To: <CAFA6WYP7hgRWS_gp2AFEWDs27aOeUndB6+1dh95TtW2s1N+5Ag@mail.gmail.com>
On 29.08.23 13:03, Sumit Garg wrote:
> Hi Jan,
>
> On Fri, 28 Jul 2023 at 19:18, Sumit Garg <sumit.garg@linaro.org> wrote:
>>
>> Currently supplicant dependent optee device enumeration only registers
>> devices whenever tee-supplicant is invoked for the first time. But it
>> forgets to remove devices when tee-supplicant daemon stops running and
>> closes its context gracefully. This leads to following error for fTPM
>> driver during reboot/shutdown:
>>
>> [ 73.466791] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff3024
>>
>> Fix this by separating supplicant dependent devices so that the
>> user-space service can detach supplicant devices before closing the
>> supplicant. While at it use the global system workqueue for OP-TEE bus
>> scanning work rather than our own custom one.
>>
>> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Link: https://github.com/OP-TEE/optee_os/issues/6094
>
> I see you have marked this issue as resolved. It would be good to have
> your tested-by tag if it works for you.
>
Sorry for this very late reply. We finally validated that this works
fine for us, though only over 6.1, our current test target. I hope we
can enable tip of tree soon as well. But I think I can still add my
Tested-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
--
Siemens AG, Technology
Linux Expert Center
next prev parent reply other threads:[~2023-10-11 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 13:48 Sumit Garg
2023-07-31 6:21 ` Masahisa Kojima
2023-08-29 11:03 ` Sumit Garg
2023-10-11 14:45 ` Jan Kiszka [this message]
2023-10-12 12:39 ` Sumit Garg
2023-10-16 7:32 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9515560-32bc-4f3b-a36c-87f7242081a9@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ardb@kernel.org \
--cc=arnd@linaro.org \
--cc=diogo.ivo@siemens.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jens.wiklander@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=maxim.uvarov@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®