From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201E81E0DB0 for ; Fri, 13 Dec 2024 23:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734134140; cv=none; b=Fja3yKigzzXUyVBDAoPkpO3sYLCN8sPKxWSSWs9FgRQNl0DSRDB9trVqbO7rqyoSFRIuygoj2c+kNjvYIEWujUdR9yKLmaN5kdMpH9g15DhyfvVaClmcoZiTDgLoQk+7s3MkG0odLtcUlzMWCu4km8zfhHAOec+gqYqgjhENMrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734134140; c=relaxed/simple; bh=R3fFiruPOWwoh18HdeyS8/D0tZqJ2vocifkOSPPF/Ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TN02egmxz6tm2SQgu9FDvM5I2+rxWNj6NGxZjec+rxKyYpaone4ko2F1CZ+8YaGWLSoKcsd/+z6RZVBC8ZoHpmM7iWbyIU1PmkuLq9z1cUzny3S97xnKZOb2oXPYT+uOdTDwqlGvqjF6Qrc5jJhswt4pzY/5PDdzsaIeB2PWMsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aMkXbmxS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aMkXbmxS" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BDBhq5p018447 for ; Fri, 13 Dec 2024 23:55:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /xnO94cNP0YYeYF1CQE9V7trIwWBGc9LJ/rd4NjRnPs=; b=aMkXbmxSNkTzzQQB S9o0s4s3spQmhIUcA2RPC7SKgckPqTRHfuiA8RrXmvvvEOUfGPeif8m2ifwILC8+ wMP6rKrYcbYUVAh4Oa/MXkaNUQUNIVy4TfKdToJEly3kUDxv/pC/g/10FgMC+XTn wxeAOkHnFHo7dGVqFoEHhFcb8r/8cDE3HDffg3O0JC2B7CEmfG/IVmPYA2wHLF6d 0TBf4gLUcyKBzimTu0JeKDlSlGyW74eCZCShpZDOHi/+NgJ8OHIfMsnEoXUZj5CM PhyljobEv08BDqJSkCG6v8Ml6N0GbZal7hl50mAvXmewH45PScqSe7svDPVh1tL5 Bz2a5Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43gmac1jet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Dec 2024 23:55:37 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6d8e8153104so5312776d6.0 for ; Fri, 13 Dec 2024 15:55:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734134137; x=1734738937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xnO94cNP0YYeYF1CQE9V7trIwWBGc9LJ/rd4NjRnPs=; b=uMiLSggdKm3lp/fx/Ir8rmVoaUj1AOeltFxO9yWLKrvQ/BAbzZ98JhkwyzFieNkl63 8pexPRxjayR5HUsMDME5839E9JLCkvPTUY1nLOQp1zbq4ICtz0oA3BzZdk78raCsrlfy DORytsdE0iKRisSpfoz5jHj5n+TRD7ph/9xivgzmPwtJX+LQTOy2kEk1bFEZW/lUc4cq +qF7fL7LY4MK0qHapsbmtDn3WJd2QLy6YGPjGfrOCnrvhJFGydnqmCw0Vmhb2smMKsQB s8Uapug5GU0tJcoBUp4nJFAclPyW3ztvjcgSsFrfaFtvbkLJsS6E2kd+h7gyT/dJw1xz c9TQ== X-Forwarded-Encrypted: i=1; AJvYcCUtHwPdfrNfINYq+3ScU4Jg615DqyWfasJhe2ghfzky+rIYgTIadUkB5INTL43nGHPwuxCzObcmJYlUH20=@vger.kernel.org X-Gm-Message-State: AOJu0Yy90UFBHMYWHf9I3AQwOGANeeNd7jZT8XUZ1wVdTc3tqA5MMpT5 vJd3bVGR5zGMvOzc2xG2GHR/D70zIKpE/kx957vBu9LuYnB7I4St0Z1+hhkvtk/5bPRF0OSZur7 nHZmFwuZam2qR6gthi73dNr995+zFPsvug1XOS23Glhrfi3FQcCUqerTl96naZMo= X-Gm-Gg: ASbGncvarQMJIm02hM4Nk5W1J/49vDoxTaLo1/HJk/zo9A5WHJqlmz7+8RKilAd1bXA HLufrvwAIoUZwB54KGSDSyLSXQR1j0CtBZSHWfOq45GCgg9YKXS324FZLJx2EPrN5DTjbXmfFPd NAQhUOtAQyFNr+bEPW66ywiCfEmX2Byug24WzvEmHFj7iuyYrfWDWvSIuO0reV4bVm8NiLlxkbO aIU9DRRkGWYS9x1NSfPwNRJsHQFongSjK6wJoqh3r73W9lj7iz0L0LCdGjR3hr7MHoA8zYtqa0W Z+BfwSwtSoeeVLoGdMH+efBXxxEkqCCimAM= X-Received: by 2002:a05:620a:4609:b0:7b6:d754:2076 with SMTP id af79cd13be357-7b6fbf34839mr251747585a.12.1734134137022; Fri, 13 Dec 2024 15:55:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiB+qr/6TD32GoaPC74bztsp+aMojvpX/jfNnwMR0f0UY/F6jX6DVzI79ejvIQ6QMrD64TPA== X-Received: by 2002:a05:620a:4609:b0:7b6:d754:2076 with SMTP id af79cd13be357-7b6fbf34839mr251745685a.12.1734134136627; Fri, 13 Dec 2024 15:55:36 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab963b4faasm24867166b.193.2024.12.13.15.55.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2024 15:55:35 -0800 (PST) Message-ID: Date: Sat, 14 Dec 2024 00:55:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support To: Dzmitry Sankouski , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org References: <20241209-starqltechn_integration_upstream-v8-0-ec604481d691@gmail.com> <20241209-starqltechn_integration_upstream-v8-12-ec604481d691@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241209-starqltechn_integration_upstream-v8-12-ec604481d691@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: mvn_MmbGAGG0svYhh5eW7UTPW8KxlhkE X-Proofpoint-GUID: mvn_MmbGAGG0svYhh5eW7UTPW8KxlhkE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412130170 On 9.12.2024 1:09 PM, Dzmitry Sankouski wrote: > Add support for sound (headphones and mics only) > Also redefine slpi reserved memory, because adsp_mem overlaps with > slpi_mem inherited from sdm845.dtsi. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v8: > - clarify FM with FM -> FM radio > > Changes in v7: > - replace indeces with constants from dt-bindings/sound/qcom,wcd9340.h > - add spaces after 'link-name' node > - remove not connected digital mics from audio routing > - add DMIC(0|2) -> MCLK routing, because digital mics > need clocks > - align mapping comments, add dmics comment > > Changes in v6: > - refactor: s/starqltechn/sdm845-starqltechn in subject. > --- > arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 223 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 223 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > index 65f33be55da3..3a049459aeb3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > @@ -11,8 +11,16 @@ > #include > #include > #include > +#include > +#include > +#include > + > #include "sdm845.dtsi" > #include "pm8998.dtsi" > +#include "sdm845-wcd9340.dtsi" > + > +/delete-node/ &adsp_mem; > +/delete-node/ &slpi_mem; > > / { > chassis-type = "handset"; > @@ -97,6 +105,16 @@ memory@a1300000 { > ftrace-size = <0x40000>; > pmsg-size = <0x40000>; > }; > + > + slpi_mem: slpi@96700000 { > + reg = <0 0x96700000 0 0xf00000>; > + no-map; > + }; > + > + adsp_mem: memory@97800000 { > + reg = <0 0x97800000 0 0x2000000>; > + no-map; > + }; > }; > > i2c21 { > @@ -590,6 +608,211 @@ touchscreen@48 { > }; > }; > > +&adsp_pas { > + firmware-name = "qcom/sdm845/starqltechn/adsp.mbn"; > + status = "okay"; > +}; > + > +&lpasscc { > + status = "okay"; > +}; > + > +&wcd9340 { So this looks mostly good now.. but I noticed that the nodes are referenced in rather random order, please re-sort the references alphabetically [...] > + cpu { > + sound-dai = <&q6afedai SLIMBUS_0_RX>; > + }; > + > + platform { > + sound-dai = <&q6routing>; > + }; > + > + codec { > + sound-dai = <&wcd9340 AIF1_PB>; > + }; (and would be nice if these subnodes were sorted alphabetically too - codec < cpu < platform) Konrad