From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21E4C43219 for ; Tue, 30 Apr 2019 19:30:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 933F32063F for ; Tue, 30 Apr 2019 19:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="DmhRQ7xr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfD3TaW (ORCPT ); Tue, 30 Apr 2019 15:30:22 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36730 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbfD3TaV (ORCPT ); Tue, 30 Apr 2019 15:30:21 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3UJU9AR033504; Tue, 30 Apr 2019 14:30:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556652609; bh=ELf+VXPzXaBoZQ7HMDZ7pXuUI1yMkaohJXWakQNprkc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=DmhRQ7xrBly/jnVVoa3vSLyYE39iGJio8gv0/NYNx0zwKGQq2bGVQktJywN7tXwbk KIgAM1Z/GT/TTIXfJCxUobGcJThvd6KgvTJLL5O952zEg4iUKPlqUo3M3xwZmHG5BM 3VUCxRQCvKhY6+rh5kUiX/BZpWlQ7aJ3IDOEFPfw= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3UJU9Hq022115 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Apr 2019 14:30:09 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 30 Apr 2019 14:30:09 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 30 Apr 2019 14:30:09 -0500 Received: from [10.250.90.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3UJU83o081220; Tue, 30 Apr 2019 14:30:08 -0500 Subject: Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices To: Randy Dunlap , , CC: , References: <20190430191730.19450-1-dmurphy@ti.com> <20190430191730.19450-5-dmurphy@ti.com> <7d161cbc-d6bd-83aa-3790-6c45fdf9521f@infradead.org> From: Dan Murphy Message-ID: Date: Tue, 30 Apr 2019 14:30:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <7d161cbc-d6bd-83aa-3790-6c45fdf9521f@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy On 4/30/19 2:23 PM, Randy Dunlap wrote: > On 4/30/19 12:17 PM, Dan Murphy wrote: >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >> index da00b9ed5a5c..3ae24eaf4cde 100644 >> --- a/drivers/leds/Kconfig >> +++ b/drivers/leds/Kconfig >> @@ -776,6 +776,14 @@ config LEDS_NIC78BX >> To compile this driver as a module, choose M here: the module >> will be called leds-nic78bx. >> >> +config LEDS_TI_LMU_COMMON >> + tristate "LED driver for TI LMU" > > what does LMU mean? Lighting management unit it is defined in the DT documentation > >> + depends on REGMAP >> + help >> + Say Y to enable the LED driver for TI LMU devices. >> + This supports common features between the TI LM3532, LM3631, LM3632, >> + LM3633, LM3695 and LM3697. > > Fix help indentation above to use tab + 2 spaces consistently. > UGH I wish I had this comment 2 weeks ago. But I can fix it Dan >> comment "LED Triggers" >> source "drivers/leds/trigger/Kconfig" > > > thanks. >