From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786D515ADB4 for ; Thu, 4 Dec 2025 00:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764809535; cv=none; b=kl6qyyemfLbk4HWsdkIumtQxuaOZwchYKuEpUUxGlfIxBwH5g0tPl5ID2mzz+6Z6qNeTG//bKU63tMezg21aTe+tofChMDLO0C2RKxMx7npc/Xn7FW3UEp5xALFPTpKP62pZBzh/bKxLH8bZvnlPkYhwEUqAuUbRAn2OquOO6HU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764809535; c=relaxed/simple; bh=kEcCUKZDlgMs1iuz9lbnwuEeJ9PXjzHfOWYGEi87I0E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EBPo8ANwK2Brb8anEtFiWgvL/hInFw4OKyP/SvA986mWuW3oU0altwU/U9TNw6lAOhg/2+JUfUUDX0j/NbSAKSGLNxYs9TEIZ/ewEihJq+q+vkgKv2CcF/oSCgUSHo5CgeNg2KpnBX9a78LsKP2NXLtHI1H1VJ15nGXK/lJnFdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KlJ1RxOS; arc=none smtp.client-ip=209.85.221.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KlJ1RxOS" Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-5599b119b4aso104219e0c.0 for ; Wed, 03 Dec 2025 16:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764809532; x=1765414332; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3atcAabCz2sjBHzquuqosDkAjLE72vWIxNsqZt+hnrU=; b=KlJ1RxOSoV6L/mu3/pPJgvzSno7/LRU2AgPPkrOz8kfYUPkjKRMKCQT2GL6nCft7/L d88beO+/GoqSVO4BdwOBkGg04qmAykaN7gZMucm941Ww7lxGZtQ3IlUSOq+4sz9JRGTw wejV909FlRiiIBCX3yqv9i3/NkK+ULKdXovRYXUbTllMgmRpaEGDXdogjMzZNnMJh6lm HDTjnTMGx1rD7o8v7uK1G5NtTwlPgz1o67zF0bTZ/37kmLdkjWvLo+0JUNzQ67ZRDQBB UThsp+2848mr62loR+4iQharqY/cJQ/zwrIF+TCXNsdZugBHzGunyErKH9Jxm43Lm/DS uL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764809532; x=1765414332; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3atcAabCz2sjBHzquuqosDkAjLE72vWIxNsqZt+hnrU=; b=bUlvhamOKI/V1fal3lEv+3x81N++Duxdq4uo5G57XRGLMcFlLw1UZotLqhTHcSlBAZ V38VhMaqwYm5eU7Kk38ucc1DTrkfGupNRVqLS+SuWB9Zmgjw1kq6VFxL8httNoZp+bwC aqDrOv1u+Av7Cuo6v5J4/53rv6k7PUi6GjvCAojNUW44sb4aFN+yGBR8O19sgaudD2E8 PDBjUCXViVBcX84crNlh2WOj/3LcSDseJujN9PwC1VOqks565rZNrX2Xvu0+BUv7WREo JUcjc1xFQjlNSvKhY1kA3CK50GAnhVQAOREsDm9FvzsrKHOUnLVFBQHmVo0eQ9O2Ci8+ agpg== X-Forwarded-Encrypted: i=1; AJvYcCXvn969GEPGexu8CqYaFeJQZHrFFwJblSLW13tqaOPLRoNc7Up4hYnxgIoEGhPWPQYSNrdS9qV0Fz57mJo=@vger.kernel.org X-Gm-Message-State: AOJu0YwGQ35LA8xuxAj5qBQNq9O696CMyKra43X2alaxWQU1wFUWrc0b JwpvNnZA5CTw4SFm/hJR1m9gyCEtJ1QA+Bokn/KPaByyZxW/o3Rr17Mb X-Gm-Gg: ASbGncs1azJxTeKiv+wcHksyULl2+M55I9DnK7c2vC2PIEWWSkpmvVaGpzp6RGDrUNM roNogRa5RYIfm5TZuLyrYFNkwuNXxloWjabx5GvnYpCuA3gY1oz3MLY7p7kuZp/l89GyTCzj7qB RTVvS217tET98i/tkxJ/GIC7nQTLMTJ/M+riValHpJNRue9Bz9RlqzgZhO92mHpteqIGDjWpkwl cmB7JP0zdMeDzoYrOYtumr7avIaZ9cFjzxroE3P+g/VjRaCny2HvD/ZA9ZDDFLpXjzBBOEwtJrm Hl8F2PvRDue7YH2QnsCfQTnOuxVvRHcelSWfMs8fPCOfX2lSjMrDnOT1iH4HOeJa5ioiIy643rg BWYza/ZVH2DAehyeDHz5qoIKpIQd0pGACvlws8KZR7RVro3XP7lDRi4H3mekDn4qewks02e48bN 7mhvSQeWnS8LrgIAcJaBfL0VXz3PYEPaFYYQ/nkdU= X-Google-Smtp-Source: AGHT+IEMpcuJ1gIWyXFsLaW+WfiWQoJCvzkx4F9QSwvAIrW2J9InZ7o7A7DWxduc3pOViRobrHz0JQ== X-Received: by 2002:a05:6122:45a7:b0:55e:4bcb:6bca with SMTP id 71dfb90a1353d-55e5bf4e28dmr1544588e0c.10.1764809532071; Wed, 03 Dec 2025 16:52:12 -0800 (PST) Received: from [172.16.226.146] ([98.254.184.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-55e6c938d9bsm58015e0c.14.2025.12.03.16.52.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 16:52:11 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 19:52:09 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements To: Alan Stern , Greg KH Cc: Clint George , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> <2025120200-backslid-endocrine-e64d@gregkh> <17845408-4a9c-470d-8949-f4cd0a847615@rowland.harvard.edu> Content-Language: en-US From: David Hunter In-Reply-To: <17845408-4a9c-470d-8949-f4cd0a847615@rowland.harvard.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/2/25 10:53, Alan Stern wrote: > On Tue, Dec 02, 2025 at 06:27:46AM +0100, Greg KH wrote: >> On Tue, Dec 02, 2025 at 02:07:09AM +0530, Clint George wrote: >>> As part of my LKMP mentorship i have to complete 5 patches as a criteria >>> for graduation and thus have focused on working on such >>> beginner-friendly patches so that not only do i get the required number >>> of patches but also get familiar with the process of kernel >>> developement. >> >> The LKMP internship should be done in drivers/staging/ as generally >> coding style cleanups are NOT accepted in other parts of the kernel, >> unless you get approval from the maintainer ahead of time. >> >> Does the maintainer of this driver want this to be used for the intern >> project? > > In fact, Clint's changes are small and inoffensive enough, I wouldn't > mind having them applied to dummy-hcd. > > However, Greg is perfectly right that this kind of stylistic update is > not something that should be submitted for most parts of the kernel. It > just bulks up the Git history with essentially meaningless cruft, making > it all that much harder to see the changes that really matter. That's > part of the reason for the suggestion that interns and beginners should > confine their efforts to drivers/staging. > > Also, remember that trivial changes like this are fine for learning the > procedure of submitting kernel patches, but the effects they have on the > kernel itself are minimal. A patch that actually fixes a bug or adds a > functional enhancement would be a different story. > > Alan Stern Understood. David Hunter