From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE8A30E0E5 for ; Fri, 31 Jul 2026 22:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785535447; cv=none; b=mDHtkO4X0UZ/+syNyszhd0IHGy+En39GFRVPvlRcG/di7vCcbMCrbjGbPNRLkkuVPNbTfPV+Nkb426spxTKn8WvAnPElEyC3i2xH++IqeaGHHspyOAKXlOgsGXdIWDIVaq4CYgGA0ZLtg3x/KEFnG31EwgvLGcVeMZeYtvlh2UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785535447; c=relaxed/simple; bh=wprVu+4rI6oZhTEdzwm6VygX6UGfweOUmvNii/btMF8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lRnqvgOD80kz4ZsZ2pjFJhNIo4RHUNZnIBiw6yEMpTw31VDgjksIlM0+yu5zm4hrhH4bRAtjHlzEPSkGexzhy1PeFft/wJUc0nSismxudy69BMeHaORkkbGGQrYotc53Z2P2Ph3p9hHkAAtBJXV4MhrWnt35lCztmhyAW3eWZGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kU1raL0r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AOu7sEX6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kU1raL0r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AOu7sEX6" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VM0J6C1294260 for ; Fri, 31 Jul 2026 22:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= djLiBrCrntR2/g21yzu3z+y0eymgeWBUmxdBpdNDfug=; b=kU1raL0rs+7Krbr4 rYXNg2OZfV+iaVADXFJ5vs2lOpu0FOApn3zvlhKWoyFpPeIuOEGMTXCXmphnyxpa bHEOLNiZBQaB2uZ6GgWY1AWMzzHojxBqeRUl6KVEBwyZ2s4FmKY7nMXctWzPBy5H qgBkU7ytWCvP5MHVlUL1/7bKS27FM3Q835/do0Ra0WHHfArak98kD98A/qOXkD5Q b0LAcqlqJfl3p2yVY0bneAWqa9YchV36H3pMPkUCMJZmPa5tYkyJ1qcGxr1bw/ka vHKWK6Jw6Q/KCsMlrJ+tdmJauJHYJDtXLgp16dQ+fNigSSuUEe6po3W+vWbY/cDg C8M6tA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frufkjh1c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 22:04:05 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so2219516a12.3 for ; Fri, 31 Jul 2026 15:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785535445; x=1786140245; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=djLiBrCrntR2/g21yzu3z+y0eymgeWBUmxdBpdNDfug=; b=AOu7sEX6Yheku3Uhea8M5o+s/wMsW/mxKSDWQCtNXvcGmW9i7OCgUKh+mSZCFRLdv2 J4uzs2DB3zMIYn93J+PnMiSf7vqsojurPFKl864MjBwZv/7KeWMHf1iMhyqFLW9dGy7h 8PyVOeXW1iVABvMuC5cwx8Yvj0t7d0NeuCWK+jVIn44Uu/dtOBErzRUDf+RliLp4QFPe VCDwRzPL8HffWcSP/UsKzXKEjzk5XWpytfjV62eTI8Gv7dNL1FFC8YajuMrXio9IHlpy mZCUAusK4iPXAvdzI2E+R0HMCSulvZ/8OQSCDcBT8nBUch3wBwh4saSvbIF82T4zcW6K 484w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785535445; x=1786140245; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=djLiBrCrntR2/g21yzu3z+y0eymgeWBUmxdBpdNDfug=; b=QP0iEpGEGYc44C0xgzBwMNUZJCn/cxBfRGls+rn3AANTg2Ofh+Pd8cjHNEVHEzQJY/ JI7N24/l44CWvc8ast7ZV03Yd/rPUwOQipQP3i9UXjASe88PQpx7YZnRjC5Qcg+8zl3/ SX8kSVX6dag3D9K8QbhBbdDAJzMcFzIGRkfF9HsHGTZfBYchiFFDNbc+cwcvzv84zhuc aUG3FHGRZymwNXhxLIpup3pSlqQ8Z7Ut/2XT8iG4KrF+YaVkoDNUJ5goEjOUrGOxdVI1 SvHW4IKDaYYEtBKFhzzU0j/dPvPEEpWtGOqtNz4ycgzYmb18UUz/aMXza9yo65w58Hwu 7T6Q== X-Forwarded-Encrypted: i=1; AHgh+RohLUHJBsgUzlFDeXaiI4BiFi7E1Ix95rDOQQPT7fZElFcgo/tDmi93OLqdD5l9IVD1zG/4dpZ9AIEcJxU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyfpl0j2fvgeYQw7ymvjPxW5bAzGz+i4IaMbP7S4Z9JGL25Ka2g 3dnWjixZ/Vr+dWisKzRbJW+KuIzyeicm/mwW/1gS2LWAZc0NwQRNGRpsb78FKxdmjlt/a8UN2VF jxcqoA+E2IMZfbKPJGW7sJrSk5Y1QGTFfR5cBbEi4qnD5UBk+huJ9UKh/EjWLi9CmuJQ= X-Gm-Gg: AR+sD139RV66u+RtIf5FtJMQk0hUSfAmZ2XVXRkewrAFqt2MNfUPbeLWOqSeyqhjdnc j5Vid8mOO4sA3skA9R4Tv6xJCiC9wEbFYlPbRNqt+5aCtAYmBrMlGIfMzv/3tf0trfl6oGm/Kg+ SisV9RRKyB5B/+wfMWADHtuVLlF8OaLp6oMXUGBe9kqK04g7UQggverDVz082hlhWZkfsY02YWv lrTs3TqQiOmHuX9c6OXSWRDG9J7EhdI3pdXrB8bZ40f5061nVAZX/pbz3Z7IXr1uGe+njunjTz6 iGaByoqdZGnP/57YzdlAQU2e/iqCyraYWqjq5zxFLLDTnEZHDjbsemY7tr4JOi7pxpJ40aH6hra PRx5JKKREPfD78wW0ycXZxRRZUAfRFkt/aRK7JryWa3QuUgrPt6QiB4l/W9U= X-Received: by 2002:a05:6a20:4499:b0:3c0:9c19:65ab with SMTP id adf61e73a8af0-3c92a9054e1mr1240321637.67.1785535444670; Fri, 31 Jul 2026 15:04:04 -0700 (PDT) X-Received: by 2002:a05:6a20:4499:b0:3c0:9c19:65ab with SMTP id adf61e73a8af0-3c92a9054e1mr1240278637.67.1785535444178; Fri, 31 Jul 2026 15:04:04 -0700 (PDT) Received: from [192.168.1.9] (103.sub-97-215-187.myvzw.com. [97.215.187.103]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e04491dsm12966664eec.16.2026.07.31.15.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 15:04:02 -0700 (PDT) Message-ID: Date: Fri, 31 Jul 2026 15:04:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] wifi: ath12k: fixes to improve MLO station stability To: Jose Ignacio Tornos Martinez , jjohnson@kernel.org Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260727162748.963275-1-jtornosm@redhat.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20260727162748.963275-1-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDE2NiBTYWx0ZWRfX4AIMGsaT1TXS Z0V1cDhmf5iXwdSNwMbTozCyrM53dSptN3fvR/LM9Qt2Rf7cck//MqJY44c4lRAN1gvifMlQci1 4CaSerZ32czMyGQnA43GkmzkA27xTDI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDE2NiBTYWx0ZWRfXyHaT60OuCONP +e1KQni6lpmy2fRxvcU9JZNjnp9dPBGh+WVMWTtehuMolKFNR9GuSi3vU1Vx+dKBdfsLCaLiRvN h+l1vem5R0jzLH0y5lnINBhQJ5zu6rXmQjtT/UpUcA49E4zcSWEbWEKyVKDsaE0pxoxx0N/tdXm 1SfcTMkKegJGjVgNs1MWjuqECGM9BGzkDRo5QjT1m21Hgg9BvRPn/LqrXjCVxeMIcB8NcSf6szz oIjYStMQf1ccyyWgjFCiLFHhPimkVDFtYnegQ+y/A19Iw+eN6dblGuYMQt4iTDUZsOTAic7B0/h sE+OqDItwr2mUP5FP+GOmjK/WcLjjcjNtuUFRQlkeRanilGodGvME/+Lc07isZ+lYyJoA/4McRp ydj7B6W4u0OguPJzw7bdoNXnSV9lWuvc0D9j+Q1+LQ/IEiYWL0jWXddhQDjGekFPbemywSPZgjo L7yrMj7TwGfjWWwIecA== X-Proofpoint-GUID: VO6HgHIUURuwETfzNMDYynVfWfCq0o3M X-Authority-Analysis: v=2.4 cv=BpOtB4X5 c=1 sm=1 tr=0 ts=6a6d1bd5 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=UaEkX0D7FlC0tWE/LoNF7Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=vNYMOvrsSQ6qDk_1z1wA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: VO6HgHIUURuwETfzNMDYynVfWfCq0o3M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_07,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310166 On 7/27/2026 9:27 AM, Jose Ignacio Tornos Martinez wrote: > This series improves firmware crash recovery and connection stability > for MLO (Wi-Fi 7) stations on ath12k. Both work correctly for non-MLO > (Wi-Fi 6) stations, where the driver handles the full teardown and > reconnect cycle without issues and maintains stable connections. This > series brings MLO to the same level. > > Without these fixes, a firmware crash during an active MLO connection > results in kernel warnings, NULL pointer dereferences, 20+ second > recovery delays, and periodic disconnections both after recovery and > during normal operation under heavy traffic. > > Patches 1-3 fix firmware crash recovery: > > Patch 1 moves the RECOVERY flag clear to reconfig_complete and adds > CRASH_FLUSH guards to prevent operations on dead firmware. > Patch 2 prevents scans during recovery to avoid NULL dereferences. > Patch 3 fixes ML peer ID desync between host and firmware by syncing > the peer ID from firmware's actual value. > > Patches 4-5 fix MLO beacon miss handling: > > Patch 4 fixes beacon_iter to iterate all MLO links instead of only > deflink for BSSID matching and connection_loss_work > cancellation. > Patch 5 complements patch 4 by skipping connection_loss_work for MLO > entirely, since its cancellation mechanism is unreliable and > the mac80211 probe triggered by ieee80211_beacon_loss() is > sufficient to detect real AP unreachability, as done by other > MLO-capable drivers such as mt76 and rtw89. > > Tested on WCN7850 with MLO (Wi-Fi 7). > Firmware crashes were observed to occur spontaneously during normal > MLO operation with intense traffic testing, though rarely. > The debugfs simulate_fw_crash interface was used for systematic testing > and reproduction during active MLO connections with traffic. > > Note: I will have limited availability from mid-August to > mid-September. I will address any review feedback before then > or promptly after returning. > > Jose Ignacio Tornos Martinez (5): > wifi: ath12k: fix MLO station firmware crash recovery > wifi: ath12k: prevent scan during firmware recovery > wifi: ath12k: fix MLO dp_peer ID desync with firmware > wifi: ath12k: fix MLO beacon handling using per-link addressing > wifi: ath12k: skip connection_loss_work for MLO beacon miss > This series doesn't apply to ath/main, please rebase: Applying: wifi: ath12k: fix MLO station firmware crash recovery Using index info to reconstruct a base tree... M drivers/net/wireless/ath/ath12k/core.c M drivers/net/wireless/ath/ath12k/hal.c M drivers/net/wireless/ath/ath12k/mac.c M drivers/net/wireless/ath/ath12k/peer.c Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/ath/ath12k/peer.c CONFLICT (content): Merge conflict in drivers/net/wireless/ath/ath12k/peer.c Auto-merging drivers/net/wireless/ath/ath12k/mac.c Auto-merging drivers/net/wireless/ath/ath12k/hal.c Auto-merging drivers/net/wireless/ath/ath12k/core.c Recorded preimage for 'drivers/net/wireless/ath/ath12k/peer.c' error: Failed to merge in the changes. Patch failed at 0001 wifi: ath12k: fix MLO station firmware crash recovery