From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7E43546CC for ; Wed, 17 Jun 2026 12:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781698300; cv=none; b=fi6Ym1lUkC7CGcktPacnnbXIvSu+XjNctjMVFeWmd2Rxm33TWmnjDP2AL/3FfIp5zPHeTlTw5YRHVjy8IU+GsoN9uYhYxwJtCXCC8updvxHbyn9waAxaoVDlP6zKUhGa7vsoi9tNPWJGsTV6kxpSu/pXSslrYKnGg0dvAMADemk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781698300; c=relaxed/simple; bh=U065ANd9oOx4xWRmwPkvwRyxcFd99MH11yA+2AkkyQM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=THTOq/NdgYE0u1wCjTVQiQ5HY0rbR4+ZAw5GMQWI11MZASuq6JROqEq34ug/Au3jVr+YjwaNNnYb4LcsUyWoRnfFOvBpB/hqkJ1deOfz1y/wZGQ68qU87k57kcbHTAeL7izZ2RZQBs9y2dCFaH1QcjvzBITp3YolkSg0AjJY1CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l7DFG+4g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b2e/PgHs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l7DFG+4g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b2e/PgHs" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65H8V6IN2291343 for ; Wed, 17 Jun 2026 12:11:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RvYjcqqwjarNDsMWrLD79SnsXgpWqHBe8tU1zyG2q0A=; b=l7DFG+4gfMlKacwE AnEXuhB5QIYwdpfRSS2uRr5gcaA4076kQgncB78jOKYnvoQBa4l0ajdMRBtXr3FQ mwqK7A3KFAIFPYe3QMv/LHu4EKD8VzXo+a8zlLNbn1Sr41yfbNMz8qdv4EsKx39g erM5gYTyrdrKM4rRoo3w8UXq0v4c2v8HFoYtpbCE6d8Qmmnv+OXSlxNHQmm/lLns JReE59GIZLK3izAPhYcMYG3Y5OYxbgz8Odkw6S+usDD/wpDC9ykqpG0A+jfoqwRb L4AAACcu5xrUwlYtwZtqy0QYMlsWy3PxbtNeFF26Yn72EppPp4gbpr2jlsR8rHYh XwyfGw== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueevk3a4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 12:11:38 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5bbca8dd925so16872e0c.0 for ; Wed, 17 Jun 2026 05:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781698298; x=1782303098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RvYjcqqwjarNDsMWrLD79SnsXgpWqHBe8tU1zyG2q0A=; b=b2e/PgHsc1fcEvzpBUHHRcH76TzNSsrUfnCB95p2Wnre7zx7tR22kFa4PWZFm8aItG VPRY6PanFvIG1GITcr/IBVik3M7hJL3Jn5biuY0prhYrMQDtZUzV8g0AFSjzyB+lKHEU MbocZJ4MQqbsoCgjOnVD7xbRWVjv4H3GfH3AqNyYftKa8FUV5Wxt6nPdPgyVtsZIlwcg XgA0X6q/EPhExZHBhem/QE1Zn5xJD05zM72ehiFZDolBOS2U4VjLNR7SIJC5npv17yUX MCqb78MV01UNqeyhCpiQT6zMJiEI9J+TE7Jbjf2pFfCYBjJBJRWZfT2JH942vfcZovJf rtrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781698298; x=1782303098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RvYjcqqwjarNDsMWrLD79SnsXgpWqHBe8tU1zyG2q0A=; b=c8u1BTsItkEv1Hv4M4SnJwi7DahYYdO3vN3HnnKb+t/kTvyd6tklChdckWUlskMo5V Xp5lUXc2MAcDISmDWGIk63H9EErGm5dEkt9BViFdIge4d99M3pWYjJ9jtyM8f2phYCwC a1t7dF3z2mjvWXA+CJyAJT6RsYb0QKr3AFX9AWW0ns8kv1GswcdGUCBDJXTjdLTqvHwm bAGDH09kQ2bji7oVkSRwWi0/0DuNLvqMozdsnq/qT+jWxfMNFofbwpKpe16ITvHuFvXf ujQXm94Q+9o/6TF09gL74c/aXkfBPWpNWGVfIe3eIHqAmdEz4QzGBGcJs5vtpbAKY8rP S5nA== X-Forwarded-Encrypted: i=1; AFNElJ+3pRB/T/WJwNW1pFAPjBSGqba0crDjyZ8g9APd/arfDZfqfQuOtSNFcmgc5WM7RojBFfChIyJApGc2C5E=@vger.kernel.org X-Gm-Message-State: AOJu0Yy61+IFUDYRQA/b9U9HcmmP7NEHFr3JdR0MYJ14u31q8eEIZhUQ RLaxMXgIHzMkOwX4jRH/lCQom63y6h/v0myojQCDCtxApzHKvf4AK07Shakxxakx+vh1+acvVuN HVfNoCme5g06gEP6t/1ukDljD5FA3OhsEaMpD0/hEMIzBZCHOQvBJ0JNR/UkG+vc2vK8= X-Gm-Gg: AfdE7clt7QOM1+Vv8EWzyxYdviTnD6iCHROEM+yCHQwhzWXueQX47C3EFx62TVTCaPV gT4Ub16To0wLxm6KGVP1B99Zeo3DhPH81Q0z7E2dqnIrDi4fj66Y1wqDqQectzmycl1uJ1MsMHc eZ0enLvWiqstOEAABX/Ja8tfb/MwCN2br0LTzSAxlbWu7RYJnhKJRX/YVFMOylWJttfcrpRmOlv UeHMq8/lI7fQP4MqSeQUG1niSSAZvj0ZzXbgiQdW6SMcbZR8TgR9PPD5KiacSv61EwXxNo3Zh/X dAQuq1CwI0tCVEc55ZEV+hDk0bFgcxZOmM8ar3wrEmLozPkb2sDYBzmodApwoDRV1MqwDO1ah5Q 0dNCRxM6FabldyzmsKHcN1etdTqROtr9AeQY= X-Received: by 2002:a05:6102:8499:10b0:726:e608:6651 with SMTP id ada2fe7eead31-726e617ab08mr45103137.2.1781698298042; Wed, 17 Jun 2026 05:11:38 -0700 (PDT) X-Received: by 2002:a05:6102:8499:10b0:726:e608:6651 with SMTP id ada2fe7eead31-726e617ab08mr45100137.2.1781698297638; Wed, 17 Jun 2026 05:11:37 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb531896dsm781731566b.27.2026.06.17.05.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 05:11:36 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 14:11:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] arm64: dts: qcom: mahua: Switch pcie5_phy ref clock to RPMH_CXO_CLK To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260527-tcsr_qref_0527-v4-0-ded83866c9d9@oss.qualcomm.com> <20260527-tcsr_qref_0527-v4-7-ded83866c9d9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDExNSBTYWx0ZWRfX7HdzRL7q94G3 0kvmeMSxuKWqvOR7Z2JhSPk0VaVftoCZaaIiys9kiNEykzJzNES0OPyMVhyNcNSbHu3IJWijQfa 9pCI9JFykYTSJa6dfFpg9Bj2Wisc0pqyz69drbilezjx4Y0SySCwCnnwT5YmL4SOg4NjpuUaZUU uZsYQ34ANLJvWxiWD2d9aM7HOpI2ONIJrjwXaQmxFQwT/ugsfyB2Z7WTiL2JAIozMgNot1wqAn4 XyI3ZdTu20Ie+eugxfb3ypxoe7B/2JPLnPxrNlhENXMEPxBwLwFCbfYMqX3AcagzhPXjNfaitgp ta89J62EZWA9g7euEML3jIARfzCKZZcOUzKtlVWoN+TSo/SayRPmfODDSXT6qI72aZDj7SXDTDA vQB6K0KVduMXWT4zHfeFDgfD8Rpis8X/Rvd/D1RfuBKrDjckZeK9f+UC4GoURT6L3k0NbwtqWGE XZCVW/e5B1xk4sZN3TQ== X-Authority-Analysis: v=2.4 cv=LM1WhpW9 c=1 sm=1 tr=0 ts=6a328efa cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=kmjxFz_dt4H88yzuuMsA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: luzwZudXKyP7_FFtuIB5-5TqmGzP-xzT X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDExNSBTYWx0ZWRfXwWQb49wsF+aU blP40aZPUCiFzWiUH2oVG7LGNlzNs827Sfo/My9REGC1UxIGdkn8rX/7/cE6gR8ZbG0sFlhUIng iqCPNjp6HA6mT7Gpq7TSxE17jN2OqXw= X-Proofpoint-ORIG-GUID: luzwZudXKyP7_FFtuIB5-5TqmGzP-xzT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_01,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170115 On 6/15/26 10:51 AM, Qiang Yu wrote: > On Tue, Jun 09, 2026 at 03:06:02PM +0200, Konrad Dybcio wrote: >> On 5/28/26 4:29 AM, Qiang Yu wrote: >>> PCIe5 PHY on Mahua gets refclk from CXO0 pad directly, so no QREF >>> clkref_en voting is required. Override the clock list to use RPMH_CXO_CLK >>> directly instead. >> >> This is the last piece of the puzzle that this series is missing. >> There's no QREF clkref_en, but there is a refgen that needs to be >> powered. For PCIe5 on Mahua this would be L2F_E0 (0p9) and L4H_E0 >> (1p2). >> >> I think the easiest (laziest?) solution would be to add dummy clocks >> in the clkref driver and only toggle the required regulators. Another >> option is to defer back to individual drivers (such as PCIe QMPPHY). >> >> I kinda like the "one central node to drive power" approach, but I'm >> not sure others agree, since it stretches truth just a tiny bit >> (although not as much as one would think since there are *some* >> controls for the transparent-to-the-OS hw pieces in these paths still >> in TCSR).. Dmitry, Krzysztof, would you object to that? >> > > PCIe5 PHY on Mahua does not use QREF at all, so there is no refgen for > QREF either. The refgen supplies you mentioned are for the PCIe5 PHY > itself, not for QREF. For other PHYs that do use QREF, there are two > refgens: one for QREF (voted here in the TCSR clkref driver) and one for > the PHY (which should be voted in the PHY driver). Okay, so in this case we have the refgen regulator hardwired into the PHY block and we just consume it from the PHY node&driver, am I following correctly? Konrad