From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Rishikesh Donadkar <r-donadkar@ti.com>,
jai.luthra@linux.dev, laurent.pinchart@ideasonboard.com,
mripard@kernel.org
Cc: y-abhilashchandra@ti.com, devarsht@ti.com, s-jain1@ti.com,
vigneshr@ti.com, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, p.zabel@pengutronix.de, conor+dt@kernel.org,
sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl,
jai.luthra@ideasonboard.com, changhuang.liang@starfivetech.com,
jack.zhu@starfivetech.com, sjoerd@collabora.com,
hverkuil+cisco@kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 05/16] media: ti: j721e-csi2rx: allocate DMA channel based on context index
Date: Mon, 22 Sep 2025 15:04:43 +0300 [thread overview]
Message-ID: <a961f6a3-d4ba-4c8f-a1a2-da0dbcb8cd83@ideasonboard.com> (raw)
In-Reply-To: <20250911102832.1583440-6-r-donadkar@ti.com>
On 11/09/2025 13:28, Rishikesh Donadkar wrote:
> From: Pratyush Yadav <p.yadav@ti.com>
>
> With multiple contexts, there needs to be a different DMA channel for
> each context. Earlier, the DMA channel name was hard coded to "rx0" for
> the sake of simplicity. Generate the DMA channel name based on its index
> and get the channel corresponding to the context.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
> ---
> drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index d4e6d6b5b2f7..99a721e46d54 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -1039,9 +1039,11 @@ static int ti_csi2rx_init_dma(struct ti_csi2rx_ctx *ctx)
> struct dma_slave_config cfg = {
> .src_addr_width = DMA_SLAVE_BUSWIDTH_16_BYTES,
> };
> + char name[5];
> int ret;
>
> - ctx->dma.chan = dma_request_chan(ctx->csi->dev, "rx0");
> + snprintf(name, sizeof(name), "rx%u", ctx->idx);
> + ctx->dma.chan = dma_request_chan(ctx->csi->dev, name);
> if (IS_ERR(ctx->dma.chan))
> return PTR_ERR(ctx->dma.chan);
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
next prev parent reply other threads:[~2025-09-22 12:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 10:28 [PATCH v7 00/16] media: cadence,ti: CSI2RX Multistream Support Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 01/16] media: ti: j721e-csi2rx: Remove word size alignment on frame width Rishikesh Donadkar
2025-09-22 11:56 ` Tomi Valkeinen
2025-10-17 4:53 ` Donadkar, Rishikesh
2025-09-11 10:28 ` [PATCH v7 02/16] dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 03/16] media: ti: j721e-csi2rx: separate out device and context Rishikesh Donadkar
2025-09-22 12:03 ` Tomi Valkeinen
2025-09-11 10:28 ` [PATCH v7 04/16] media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts Rishikesh Donadkar
2025-09-22 12:03 ` Tomi Valkeinen
2025-09-11 10:28 ` [PATCH v7 05/16] media: ti: j721e-csi2rx: allocate DMA channel based on context index Rishikesh Donadkar
2025-09-22 12:04 ` Tomi Valkeinen [this message]
2025-09-11 10:28 ` [PATCH v7 06/16] media: ti: j721e-csi2rx: add a subdev for the core device Rishikesh Donadkar
2025-09-22 12:38 ` Tomi Valkeinen
2025-11-06 9:53 ` Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 07/16] media: ti: j721e-csi2rx: get number of contexts from device tree Rishikesh Donadkar
2025-09-22 12:39 ` Tomi Valkeinen
2025-09-11 10:28 ` [PATCH v7 08/16] media: cadence: csi2rx: add get_frame_desc wrapper Rishikesh Donadkar
2025-09-22 12:49 ` Tomi Valkeinen
2025-09-11 10:28 ` [PATCH v7 09/16] media: ti: j721e-csi2rx: add support for processing virtual channels Rishikesh Donadkar
2025-09-22 13:30 ` Tomi Valkeinen
2025-11-06 10:35 ` Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 10/16] media: cadence: csi2rx: add multistream support Rishikesh Donadkar
2025-09-22 14:39 ` Tomi Valkeinen
2025-09-25 12:44 ` Tomi Valkeinen
2025-11-10 12:23 ` Rishikesh Donadkar
2025-11-11 9:46 ` Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 11/16] media: ti: j721e-csi2rx: " Rishikesh Donadkar
2025-09-25 12:17 ` Tomi Valkeinen
2025-10-07 11:52 ` Jai Luthra
2025-11-11 12:19 ` Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 12/16] media: ti: j721e-csi2rx: Submit all available buffers Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 13/16] media: ti: j721e-csi2rx: Change the drain architecture for multistream Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 14/16] media: cadence: csi2rx: Support runtime PM Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 15/16] media: ti: j721e-csi2rx: Support runtime suspend Rishikesh Donadkar
2025-09-11 10:28 ` [PATCH v7 16/16] media: ti: j721e-csi2rx: Support system suspend using pm_notifier Rishikesh Donadkar
2025-09-12 9:45 ` [PATCH v7 00/16] media: cadence,ti: CSI2RX Multistream Support Jai Luthra
2025-09-24 9:33 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a961f6a3-d4ba-4c8f-a1a2-da0dbcb8cd83@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=jai.luthra@ideasonboard.com \
--cc=jai.luthra@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=r-donadkar@ti.com \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sjoerd@collabora.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®