From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C1F31690D for ; Mon, 19 Jan 2026 11:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823225; cv=none; b=DN1sTNgXhiED7n82yd0NX5O8OB7ZM3wb9YSAt9CQSbH0sp2b9fosUOx5UrD6gbfmRjtRBPQy4eU32GnJIRHgNc55aBE6ZIofLw3m3KlzqgWLbsyUtToQR1Zp3uk2IhgHEBhugcqkGHQSC2In7dqcsZj6EojbiyoONz8wqVEp8ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823225; c=relaxed/simple; bh=WphD3di6sPvBYWLWfOlZFQEfvM5D5MOizS2is20CSA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vFFkwjus1se5ElgK3bXfLUGDcEZEWPvefvya7+YEVEbfG/1l76KpwZB7Pw+Ka7hu08T02v9hn4at4w6rqFSYOajtzDRb/JlmzdtOpuddXF6tIZfij1uqRonwamNakaMBzJmq2wdw0vsnyqnteKnoCGmybsLOogT2s0i0EH4IlhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mS9A1G33; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iCQpLgiy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mS9A1G33"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iCQpLgiy" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J912rB903231 for ; Mon, 19 Jan 2026 11:47:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M/kXB9qV/mARKq84Xs1cOBzOK1huJAJfToX9eRl6AHs=; b=mS9A1G339ZJwcryC OxlCD1EbNjsXWuZbe33d6R3UEBmqU86gn2skhLjd++cDhn3dshpBcs39QAKbVPhr HrB7Up7sr21iyyC9uOOHJb5UcjAPl5a+h5EdlvY5tZCZLl99k35Ar3KeoG0/7Mdk 47L+YzPTIBCpfJD2ExVdZdvm3FLrZ6vgGw2dF0Btd74K2liYyN1Y1XTQkNxAeWq1 4jqzTJ65f16ahgowtWb8sYzSwzJ30S12adW5Xp0Kimy2I/GrMNGemADq/OuDONPY 90proo8DJYg/41vBS79I1hQge6b6KddbzyFBT7Vy1P35NXLC+1zUGye6z/92nnqb PO6HFg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsb4ysq1t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 11:47:03 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34e70e2e363so3254554a91.1 for ; Mon, 19 Jan 2026 03:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768823222; x=1769428022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M/kXB9qV/mARKq84Xs1cOBzOK1huJAJfToX9eRl6AHs=; b=iCQpLgiye4N4IAZofYZ8fCgmY7iHUie25NRUz4/DSe2qUxnUbZfFmMKMd1+xNnNQuK sTFBzF/ToAsyx/SGCP8dCRoAZtMeGHhk3qu8L/qeJLsKsxR+gVfxOXy4rpUp+N4AyzUi uzlx6AHtIYWRYeD/UTHhWd8yjUbju5UbJeicYvg/FTZiK+ZZxR7bQTqLz237GKUNqfBr Wi40708YDReW9repnHr8+IBwe3RAEBfrl1fIFrNSI432s1G2eHmWqtAvXSf/r688XGCu wXQp30P61wmMLztP5h6Lsj/PNzp85CxdWCwwS/Vo0SwUyJQhq1U7Zw9lVyLjzLLC+S8S uoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768823222; x=1769428022; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M/kXB9qV/mARKq84Xs1cOBzOK1huJAJfToX9eRl6AHs=; b=LgCxtk9xP77JWwbwg/ftSTXgzBTHcon3LTt5p0SYFge64bJ0SgDt/qSgfOziPkJI2R uddzQevnrnmCyNFrdfzP/T+AedTetu+7AqkDRzu2IU91cHN/YYLEK7MXjXBfl8rIoYuZ 2KL/M291OsDi0EGcSQHWhK94VzL47FKj6giyCIGLDnJQCyWCv7iOggsDF38qEAdwDdtG uP89WkGBpLRn5EE16ca8MMVOofjJEB4aaZle7xQqjgFJpKcu+yAN6clQAJ4lgerKcIUb bq7mTGwujKreIytSbsbMs0tbJ9V4o+SN4DR30PFyZc9kSm6HO3I/CsLP8qgz1WtHLxUs 9P/w== X-Forwarded-Encrypted: i=1; AJvYcCWWi4JXfChTzzqeLpQ1ajuVSb4BrQm1RnsQ4tnVTvK5DofJC8I8OxZN4guKWb7YI1Cp/dBP5rr1Cxny0nI=@vger.kernel.org X-Gm-Message-State: AOJu0YwxYB64QAN/5dsM0oDeBfGO7i4qZEDQTjOEVTz8trwh1tdZ3Zj1 fO+6ewXJIBwHZ2YKF1FFIxOA+zGo8qcP3I6fBwzcmkmDecvASYenJLiQrRHb71dzXrvUjZ0sVZ/ +E/EDY0eHxQAS95j7CzdjtetjBxOiPSiG+A0pdvVyJ+95fZq/DEY+aKxFBuaFZmMdJKo= X-Gm-Gg: AZuq6aKsTXaQ4yr/vQsfdIy6LxIRpYNd9x8XZMi8S3Keyjhbm5IbDDrNe8yG8HNvELB aZ37bCNbFe9QPLhH6oaTQEPIKSBKhAK7EYpzXC3nRHPzzbYu6uvKpfatiFSi/5bYaPVsFLmeZUN 7tde+BqacW/1pPb4DJH8f4HqzVAa2cLr2sxIZU0ctncRJQh5upvsmq5tU85OoIeF1DcfgiPJ9MC qkWW3E5ymoCHiDy94zDK/WfUddHGC54mLurlqlIYzrKdwxAdKTtLwirdN7G3c4VoAmyBriRmAbz Wt/aL+ZBalO4v1ayX9VDV2JRbHE/hSPjBoljAu1mVRUUn8TH/0QjBKmr24uR8np9WwPzx0oSsl2 HG3YpXV78SpGfri78t9O9vV/MVRUJE6mIhrU= X-Received: by 2002:a17:90b:2d47:b0:34a:4a8d:2e2e with SMTP id 98e67ed59e1d1-35272f973b4mr9869545a91.17.1768823222182; Mon, 19 Jan 2026 03:47:02 -0800 (PST) X-Received: by 2002:a17:90b:2d47:b0:34a:4a8d:2e2e with SMTP id 98e67ed59e1d1-35272f973b4mr9869524a91.17.1768823221716; Mon, 19 Jan 2026 03:47:01 -0800 (PST) Received: from [10.239.97.158] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf233914sm9089925a12.1.2026.01.19.03.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 03:47:01 -0800 (PST) Message-ID: Date: Mon, 19 Jan 2026 19:46:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: hci_sync: Fix not clearing cmd_sync_work_list on power off To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com References: <20251209140347.2816326-1-shuai.zhang@oss.qualcomm.com> Content-Language: en-US From: Shuai Zhang In-Reply-To: <20251209140347.2816326-1-shuai.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SNhPlevH c=1 sm=1 tr=0 ts=696e19b7 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=bkFCjwZo7dHlCUbkh74A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA5NyBTYWx0ZWRfX5t27uR/U4JGJ hj4h1sGlzoAqDSHthIgKsLUeYFuO0ekHk1ATvk2JWeTtpzmtrK5CkBzu/ijkXpJ4bCVPHlx2uek VkwoK3ri7k5EpLKLI2BD4AsLSua8Lg7RGGTi7SJe+Zyrpmfhax4oQf6KEI/cvMeqUuZwzU+tz5D oiKSKJt4s9OnrRfvajQkBj9tXXBZHuxeMItnnW1HznjgC8yvoECP6H5hQlDSg1SvqmB6wogsjhC ihaK8BaTEWU3NIMTzP6QQZJ7DewQ/ZjQ82klBtX21VfMKS/wUaQ2m+bN/TT31Md3UbSpcVvws99 p/s2lAGYH7WfOArNgo7dcM77RxS0YyIS53BXpkCyGmbKP7R+ZWy0bFV4nYQEEgnkC0tVqXDuyBs KsBY8Oo212rq/qsNDPhfI5LQL0h7uzUsyQIyH3OEX74OOuVsAXKWxjVWBbVtGEuL0evaxpb5Fsr AWAxmzpVRnytY7sVXmA== X-Proofpoint-ORIG-GUID: i15eeNLY3pIT9VRDB1d2weFDOADRN5MP X-Proofpoint-GUID: i15eeNLY3pIT9VRDB1d2weFDOADRN5MP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190097 Hi On 12/9/2025 10:03 PM, Shuai Zhang wrote: > When powering off the cmd_sync_work_list may contain items which shall > be cleared during power off as they shouldn't be run during power off > sequence. > > Signed-off-by: Shuai Zhang > --- > net/bluetooth/hci_sync.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c > index a9f5b1a68..45b593ec7 100644 > --- a/net/bluetooth/hci_sync.c > +++ b/net/bluetooth/hci_sync.c > @@ -648,16 +648,22 @@ static void _hci_cmd_sync_cancel_entry(struct hci_dev *hdev, > kfree(entry); > } > > -void hci_cmd_sync_clear(struct hci_dev *hdev) > +/* Clear remaining entries in cmd_sync_work_list */ > +static void hci_cmd_sync_list_clear(struct hci_dev *hdev) > { > struct hci_cmd_sync_work_entry *entry, *tmp; > > + list_for_each_entry_safe(entry, tmp, &hdev->cmd_sync_work_list, list) > + _hci_cmd_sync_cancel_entry(hdev, entry, -ECANCELED); > +} > + > +void hci_cmd_sync_clear(struct hci_dev *hdev) > +{ > cancel_work_sync(&hdev->cmd_sync_work); > cancel_work_sync(&hdev->reenable_adv_work); > > mutex_lock(&hdev->cmd_sync_work_lock); > - list_for_each_entry_safe(entry, tmp, &hdev->cmd_sync_work_list, list) > - _hci_cmd_sync_cancel_entry(hdev, entry, -ECANCELED); > + hci_cmd_sync_list_clear(hdev); > mutex_unlock(&hdev->cmd_sync_work_lock); > } > > @@ -678,6 +684,7 @@ EXPORT_SYMBOL(hci_cmd_sync_cancel); > * > * - Set result and mark status to HCI_REQ_CANCELED > * - Wakeup command sync thread > + * - Clear cmd_sync_work_list if the interface is down > */ > void hci_cmd_sync_cancel_sync(struct hci_dev *hdev, int err) > { > @@ -692,6 +699,9 @@ void hci_cmd_sync_cancel_sync(struct hci_dev *hdev, int err) > > wake_up_interruptible(&hdev->req_wait_q); > } > + > + if (err == EHOSTDOWN || err == -EHOSTDOWN) > + hci_cmd_sync_list_clear(hdev); > } > EXPORT_SYMBOL(hci_cmd_sync_cancel_sync); > > @@ -5260,14 +5270,14 @@ int hci_dev_close_sync(struct hci_dev *hdev) > disable_delayed_work(&hdev->power_off); > disable_delayed_work(&hdev->ncmd_timer); > disable_delayed_work(&hdev->le_scan_disable); > + hci_cmd_sync_cancel_sync(hdev, ENODEV); > } else { > cancel_delayed_work(&hdev->power_off); > cancel_delayed_work(&hdev->ncmd_timer); > cancel_delayed_work(&hdev->le_scan_disable); > + hci_cmd_sync_cancel_sync(hdev, EHOSTDOWN); > } > > - hci_cmd_sync_cancel_sync(hdev, ENODEV); > - > cancel_interleave_scan(hdev); > > if (hdev->adv_instance_timeout) { Kindly let me know if there are any updates. Kindly, regard Shuai