mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: shijie001@208suo.com, alexander.deucher@amd.com,
	Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
Date: Fri, 14 Jul 2023 09:21:18 +0200	[thread overview]
Message-ID: <a96b79fb-3ad8-918f-d109-3da2121e4607@amd.com> (raw)
In-Reply-To: <26d3424f83f1f394614e2a774d1bf1e9@208suo.com>

Am 14.07.23 um 07:35 schrieb shijie001@208suo.com:
> Fix one occurrence of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"

It's nice to see all those little typos fixed, but I'm not sure how 
feasible it is to send patches for each type individually.

Maybe just merge them together into one patch for the whole radeon code 
base.

Additional to that I'm pretty sure that most of that stuff is already 
fixed, so what base do you use for this?

Regards,
Christian.

>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
>  drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c 
> b/drivers/gpu/drm/radeon/uvd_v1_0.c
> index 58557c2263a7..5684639d20a6 100644
> --- a/drivers/gpu/drm/radeon/uvd_v1_0.c
> +++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
> @@ -142,7 +142,7 @@ int uvd_v1_0_resume(struct radeon_device *rdev)
>      addr = (rdev->uvd.gpu_addr >> 32) & 0xFF;
>      WREG32(UVD_LMI_EXT40_ADDR, addr | (0x9 << 16) | (0x1 << 31));
>
> -    WREG32(UVD_FW_START, *((uint32_t*)rdev->uvd.cpu_addr));
> +    WREG32(UVD_FW_START, *((uint32_t *)rdev->uvd.cpu_addr));
>
>      return 0;
>  }


  reply	other threads:[~2023-07-14  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_16FACBDCDA61595C4219E185613C85C8BF0A@qq.com>
2023-07-14  5:35 ` shijie001
2023-07-14  7:21   ` Christian König [this message]
     [not found] <20230710091057.64085-1-xujianghui@cdjrlc.com>
2023-07-10 10:03 ` sunran001
2023-07-10 17:34   ` Alex Deucher
     [not found] <20230710082515.54604-1-xujianghui@cdjrlc.com>
2023-07-10  8:26 ` sunran001
2023-07-10 17:25   ` Alex Deucher
     [not found] <20230710074943.54300-1-xujianghui@cdjrlc.com>
2023-07-10  7:51 ` sunran001
2023-07-10 17:21   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a96b79fb-3ad8-918f-d109-3da2121e4607@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shijie001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®