From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] staging: rtl8192e: Remove entry .interrupt_re.. from struct rtl819x_ops
Date: Tue, 21 Feb 2023 21:53:03 +0100 [thread overview]
Message-ID: <a972ff8963b426f20651810b5161c8759ffa2d05.1677010997.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1677010997.git.philipp.g.hortmann@gmail.com>
Remove entry .interrupt_recognized and replace it with function name
rtl92e_ack_irq. This increases readability of the code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +--
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index f1cde3fc8634..3323bdf564ee 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -30,7 +30,6 @@ static const struct rtl819x_ops rtl819xp_ops = {
.link_change = rtl92e_link_change,
.rx_command_packet_handler = NULL,
.irq_clear = rtl92e_clear_irq,
- .interrupt_recognized = rtl92e_ack_irq,
.tx_check_stuck_handler = rtl92e_is_tx_stuck,
.rx_check_stuck_handler = rtl92e_is_rx_stuck,
};
@@ -2103,7 +2102,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
spin_lock_irqsave(&priv->irq_th_lock, flags);
- priv->ops->interrupt_recognized(dev, &inta, &intb);
+ rtl92e_ack_irq(dev, &inta, &intb);
if (!inta) {
spin_unlock_irqrestore(&priv->irq_th_lock, flags);
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index 79281c077182..d3558bf6ce23 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -211,8 +211,6 @@ struct rtl819x_ops {
struct sk_buff *skb,
struct rx_desc *pdesc);
void (*irq_clear)(struct net_device *dev);
- void (*interrupt_recognized)(struct net_device *dev,
- u32 *p_inta, u32 *p_intb);
bool (*tx_check_stuck_handler)(struct net_device *dev);
bool (*rx_check_stuck_handler)(struct net_device *dev);
};
--
2.39.2
next prev parent reply other threads:[~2023-02-21 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 20:52 [PATCH 0/7] staging: rtl8192e: Remove entries from struct rtl819x_ops start with .tx_enable Philipp Hortmann
2023-02-21 20:52 ` [PATCH 1/7] staging: rtl8192e: Remove entry .tx_enable from struct rtl819x_ops Philipp Hortmann
2023-02-21 20:53 ` Philipp Hortmann [this message]
2023-02-21 20:53 ` [PATCH 3/7] staging: rtl8192e: Remove entry .tx_check_stuc.. " Philipp Hortmann
2023-02-21 20:53 ` [PATCH 4/7] staging: rtl8192e: Remove entry .rx_check_stuc.. " Philipp Hortmann
2023-02-21 20:53 ` [PATCH 5/7] staging: rtl8192e: Remove dead code " Philipp Hortmann
2023-02-21 20:53 ` [PATCH 6/7] staging: rtl8192e: Remove entry .link_change " Philipp Hortmann
2023-02-21 20:53 ` [PATCH 7/7] staging: rtl8192e: Remove entry .nic_type " Philipp Hortmann
2023-02-22 13:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a972ff8963b426f20651810b5161c8759ffa2d05.1677010997.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®