From: "Christian König" <christian.koenig@amd.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting
Date: Fri, 1 Sep 2023 09:30:37 +0200 [thread overview]
Message-ID: <a975bbdb-8cd9-35b2-ce98-f711439db3a5@amd.com> (raw)
In-Reply-To: <20230901070240.31027-1-jiapeng.chong@linux.alibaba.com>
Am 01.09.23 um 09:02 schrieb Jiapeng Chong:
> No functional modification involved.
>
> drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting.
We should probably not have a printk here in the first place.
Christian.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> index 7c08e5f95e97..76e21357dd4d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> @@ -31,10 +31,9 @@
> static u32 nbio_v7_11_get_rev_id(struct amdgpu_device *adev)
> {
> u32 tmp;
> - printk("%s, getid\n",__func__);
> -
> - tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0);
>
> + printk("%s, getid\n", __func__);
> + tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0);
> tmp &= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0_MASK;
> tmp >>= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0__SHIFT;
>
next prev parent reply other threads:[~2023-09-01 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 7:02 Jiapeng Chong
2023-09-01 7:30 ` Christian König [this message]
2023-09-05 17:20 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-06-02 6:16 Jiapeng Chong
2023-06-02 13:16 ` Alex Deucher
2022-05-10 6:04 Jiapeng Chong
2022-05-10 15:09 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a975bbdb-8cd9-35b2-ce98-f711439db3a5@amd.com \
--to=christian.koenig@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®