From: Jeff Layton <jlayton@kernel.org>
To: Luis Henriques <lhenriques@suse.com>,
Amir Goldstein <amir73il@gmail.com>,
Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ceph: don't return -ESTALE if there's still an open file
Date: Tue, 19 May 2020 06:32:55 -0400 [thread overview]
Message-ID: <a9793df5b119b81b995b903505006076811227ed.camel@kernel.org> (raw)
In-Reply-To: <20200518174726.GA84496@suse.com>
On Mon, 2020-05-18 at 18:47 +0100, Luis Henriques wrote:
> Similarly to commit 03f219041fdb ("ceph: check i_nlink while converting
> a file handle to dentry"), this fixes another corner case with
> name_to_handle_at/open_by_handle_at. The issue has been detected by
> xfstest generic/467, when doing:
>
> - name_to_handle_at("/cephfs/myfile")
> - open("/cephfs/myfile")
> - unlink("/cephfs/myfile")
> - sync; sync;
> - drop caches
> - open_by_handle_at()
>
> The call to open_by_handle_at should not fail because the file hasn't been
> deleted yet (only unlinked) and we do have a valid handle to it. -ESTALE
> shall be returned only if i_nlink is 0 *and* i_count is 1.
>
> This patch also makes sure we have LINK caps before checking i_nlink.
>
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> ---
> Hi!
>
> (and sorry for the delay in my reply!)
>
> So, from the discussion thread and some IRC chat with Jeff, I'm sending
> v2. What changed? Everything! :-)
>
> - Use i_count instead of __ceph_is_file_opened to check for open files
> - Add call to ceph_do_getattr to make sure we have LINK caps before
> accessing i_nlink
>
> Cheers,
> --
> Luis
>
> fs/ceph/export.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ceph/export.c b/fs/ceph/export.c
> index 79dc06881e78..e088843a7734 100644
> --- a/fs/ceph/export.c
> +++ b/fs/ceph/export.c
> @@ -172,9 +172,16 @@ struct inode *ceph_lookup_inode(struct super_block *sb, u64 ino)
> static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino)
> {
> struct inode *inode = __lookup_inode(sb, ino);
> + int err;
> +
> if (IS_ERR(inode))
> return ERR_CAST(inode);
> - if (inode->i_nlink == 0) {
> + /* We need LINK caps to reliably check i_nlink */
> + err = ceph_do_getattr(inode, CEPH_CAP_LINK_SHARED, false);
> + if (err)
> + return ERR_PTR(err);
> + /* -ESTALE if inode as been unlinked and no file is open */
> + if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) {
> iput(inode);
> return ERR_PTR(-ESTALE);
> }
>
Looks good. Merged into testing branch.
Thanks!
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-05-19 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 17:47 Luis Henriques
2020-05-19 3:45 ` Amir Goldstein
2020-05-19 10:32 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9793df5b119b81b995b903505006076811227ed.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=amir73il@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=lhenriques@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®