mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Marc Zyngier <maz@kernel.org>,
	gregkh <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	<quic_psodagud@quicinc.com>,
	Prasad Sodagudi <psodagud@codeaurora.org>
Subject: Re: [PATCHv5 3/4] tracing: Add register read/write tracing support
Date: Mon, 6 Dec 2021 16:22:11 +0530	[thread overview]
Message-ID: <a97be342-21e3-54f1-ea36-db67747b7a70@quicinc.com> (raw)
In-Reply-To: <CAK8P3a2hoQHTDUs5YNWwrAk2GfD7bFh6ipvgqSttDxNdUX6jyg@mail.gmail.com>

On 12/6/2021 4:16 PM, Arnd Bergmann wrote:
> On Mon, Dec 6, 2021 at 11:11 AM Sai Prakash Ranjan
> <quic_saipraka@quicinc.com> wrote:
>> On 12/6/2021 2:29 PM, Arnd Bergmann wrote:
>>> On Mon, Dec 6, 2021 at 9:28 AM Sai Prakash Ranjan
>>>> +void log_read_mmio(u8 width, const volatile void __iomem *addr)
>>>> +{
>>>> +       trace_rwmmio_read(CALLER_ADDR0, CALLER_ADDR1, width, addr);
>>>> +}
>>> Here, it may be better to pass the caller address as an argument, I think
>>> CALLER_ADDR1 is not always reliable, though it's possible that it is
>>> in the configurations when this file gets enabled.
>>>
>>>
>> Do you mean that we use __builtin_return_address(0,1) directly here or
>> that I pass __func__ as the argument to log_read/write_mmio or is there
>> some other way to pass the caller address?
> I meant passing CALLER_ADDR0 from readl() down to
> log_read_mmio().
>
>         Arnd

Ah ok, will do that and remove CALLER_ADDR1.

Thanks,
Sai

  reply	other threads:[~2021-12-06 10:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  8:28 [PATCHv5 0/4] tracing/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2021-12-06  8:28 ` [PATCHv5 1/4] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2021-12-06  8:50   ` Arnd Bergmann
2021-12-06 11:12     ` Sai Prakash Ranjan
2021-12-06 11:30       ` Arnd Bergmann
2021-12-06 13:52         ` Sai Prakash Ranjan
2021-12-06 15:15           ` Arnd Bergmann
2021-12-06 15:57             ` Sai Prakash Ranjan
2021-12-06 15:36   ` kernel test robot
2021-12-07 13:04   ` kernel test robot
2021-12-06  8:28 ` [PATCHv5 2/4] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
2021-12-06  8:51   ` Arnd Bergmann
2021-12-06  8:28 ` [PATCHv5 3/4] tracing: Add register read/write tracing support Sai Prakash Ranjan
2021-12-06  8:59   ` Arnd Bergmann
2021-12-06 10:11     ` Sai Prakash Ranjan
2021-12-06 10:46       ` Arnd Bergmann
2021-12-06 10:52         ` Sai Prakash Ranjan [this message]
2021-12-06 10:13     ` Sai Prakash Ranjan
2021-12-06 11:52   ` kernel test robot
2021-12-06 16:39   ` kernel test robot
2021-12-06  8:28 ` [PATCHv5 4/4] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2021-12-06  9:09   ` Arnd Bergmann
2021-12-06  9:52     ` Sai Prakash Ranjan
2021-12-06 10:01       ` Arnd Bergmann
2021-12-06 10:20         ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a97be342-21e3-54f1-ea36-db67747b7a70@quicinc.com \
    --to=quic_saipraka@quicinc.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=quic_psodagud@quicinc.com \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®