From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdHIK6X (ORCPT ); Wed, 9 Aug 2017 06:58:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbdHIK6V (ORCPT ); Wed, 9 Aug 2017 06:58:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5C6E9CF96A Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=javierm@redhat.com Subject: Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases To: Kieran Bingham , linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org References: <20170809093731.3572-1-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: Date: Wed, 9 Aug 2017 12:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 09 Aug 2017 10:58:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kieran, On 08/09/2017 12:29 PM, Kieran Bingham wrote: > Hi Javier, > > Thankyou for the patch > You are welcome. > On 09/08/17 10:37, Javier Martinez Canillas wrote: >> The I2C core always reports a MODALIAS of the form i2c: even if the >> device was registered via OF, and the driver is only exporting the OF ID >> table entries as module aliases. >> >> So if the driver is built as module, autoload won't work since udev/kmod >> won't be able to match the registered OF device with its driver module. > > Good catch, and perhaps I should have known better :D > > I've only worked on this driver as a built-in so far :-) #BadExcuses > A better excuse I think is that after all these years, one would had thought that the I2C OF modalias issue would had been finally fixed, but not yet :) >> Before this patch: >> >> $ modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias >> alias: of:N*T*Cadi,adv7482C* >> alias: of:N*T*Cadi,adv7482 >> alias: of:N*T*Cadi,adv7481C* >> alias: of:N*T*Cadi,adv7481 >> >> After this patch: >> >> modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias >> alias: of:N*T*Cadi,adv7482C* >> alias: of:N*T*Cadi,adv7482 >> alias: of:N*T*Cadi,adv7481C* >> alias: of:N*T*Cadi,adv7481 >> alias: i2c:adv7482 >> alias: i2c:adv7481 >> >> Signed-off-by: Javier Martinez Canillas > > Reviewed-by: Kieran Bingham > Thanks! Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat