From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8EF40287259 for ; Mon, 5 Jan 2026 16:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767632240; cv=none; b=OUEwyGj914r8u8jKz8RbM7Cp2H8+PXGIpL4pEnsFFl2jSSCd/qowbG70U/+TIMZ++vRK2v0m2xo7DX2sBQuKs7iSLHw6g/3HbRDoaFAOLPmOPEo7Nfzwcp5nKlqRpam1YUBLudryCQa9ilnzBs49rZJdPh57vpSyKpl9yy4u/b8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767632240; c=relaxed/simple; bh=5smsRiMWCKU+MfoVhiEB92JKqOPKepN2wzr8tKD47wg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DRsplWKo40sswFvlKkoZLz237KyHrt8QISh9btpI9tSwYBGo542DpJBfchp9K2QwuU4aJT11n2IWPJir+636MvaDAG9LtfM1TPmTZPHVBG/5WgTbmemUWk6QOuCQU4/uA3dKZjy2IQrK+py/aosCMDGXmOk+Ah1u/ifSBWaD9aQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B61F4339; Mon, 5 Jan 2026 08:57:08 -0800 (PST) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B675F3F5A1; Mon, 5 Jan 2026 08:57:10 -0800 (PST) Message-ID: Date: Mon, 5 Jan 2026 16:57:09 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/45] KVM: arm64: Make MPAMSM_EL1 accesses UNDEF To: Jonathan Cameron Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, gshan@redhat.com, james.morse@arm.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev References: <20251219181147.3404071-1-ben.horgan@arm.com> <20251219181147.3404071-7-ben.horgan@arm.com> <20260105164738.0000792f@huawei.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20260105164738.0000792f@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jonathan, On 1/5/26 16:47, Jonathan Cameron wrote: > On Fri, 19 Dec 2025 18:11:08 +0000 > Ben Horgan wrote: > >> The MPAMSM_EL1 controls the MPAM labeling for an SMCU, Streaming Mode >> Compute Unit. As there is on MPAM support in kvm, make sure MPAMSM_EL1 >> accesses trigger an UNDEF. >> >> The range of valid configurations for the PARTID and PMG in MPAMSM_EL1 is >> not currently specified in Arm Architectural Reference Manual but the >> architect has confirmed that it is intended to be the same as that for the >> cpu configuration in the MPAMy_ELx registers. > > Good to know but I'm not seeing why it matters in this patch. Perhaps > a little more on that? Hmmm, yes. This paragraph should go with patch 11 where we start setting MPAMSM_EL1 with the same value as MPAM0_EL1 and MPAM1_EL1. > >> >> Signed-off-by: Ben Horgan > > Reviewed-by: Jonathan Cameron > >> --- >> arch/arm64/kvm/sys_regs.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index c8fd7c6a12a1..72654ab984ee 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -3373,6 +3373,8 @@ static const struct sys_reg_desc sys_reg_descs[] = { >> >> { SYS_DESC(SYS_MPAM1_EL1), undef_access }, >> { SYS_DESC(SYS_MPAM0_EL1), undef_access }, >> + { SYS_DESC(SYS_MPAMSM_EL1), undef_access }, >> + >> { SYS_DESC(SYS_VBAR_EL1), access_rw, reset_val, VBAR_EL1, 0 }, >> { SYS_DESC(SYS_DISR_EL1), NULL, reset_val, DISR_EL1, 0 }, >> > Thanks, Ben