From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdFII0h (ORCPT ); Fri, 9 Jun 2017 04:26:37 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55461 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbdFII0b (ORCPT ); Fri, 9 Jun 2017 04:26:31 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-19-593a5bb4f973 Subject: Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi To: Krzysztof Kozlowski Cc: inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, a.hajda@samsung.com From: Hoegeun Kwon Message-id: Date: Fri, 09 Jun 2017 17:26:32 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <20170609072754.GB4018@kozik-book> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPJsWRmVeSWpSXmKPExsWy7bCmuu6WaKtIg8ZLaha31p1jteg9d5LJ 4v2yHkaL+UeA3Ctf37NZTLo/gcXizds1TBYv7l1kseh//JrZ4vz5DewWmx5fY7W4vGsOm8WM 8/uYLJZev8hk0br3CLvFjMkv2SxefjzB4iDosWbeGkaPTas62Ty2f3vA6nG/+ziTx+Yl9R5b +u+ye/RtWcXo8XmTXABHVKpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJu qq2Si0+ArltmDtAbSgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9QwNzPSMjIz0T 41grI1OgkoTUjCsP7rEX7BKvuDv5DHsD40+BLkZODgkBE4mTHe8ZIWwxiQv31rN1MXJxCAks ZZSY8GQBlPOZUWLdgVlMXYwcYB0tC2Mg4msZJV69+cIE4dxllJi67hcLSJGwgI/EtXZ3kKki ApoS1/9+ZwWpYRZYxCzR+mAKE0iCTUBX4mvPdTCbV8BOYk37NbAzWARUJZ5O28AMYosKREgs mjSRHaJGUOLH5HssIDangL7E0ynbwOLMAlYSz/61skLY8hKb17xlhrDFJZpbb7KALJYQ6OSQ +HTzPRvEB7ISmw4wQ5guEh9XiUB8Lyzx6vgWdghbSqK7YxaUXS9xecdJRogxDYwS/RNnQyWM JU51NTJB7OKT6P39BBpAvBIdbUIQJR4S/c/b2CBsR4nZLx6xQMLqIKPElystbBMYFWYheW0W kndmIXlnFpJ3FjCyrGIUSy0ozk1PLTYtMNIrTswtLs1L10vOz93ECE7cWro7GL8s8D7EKMDB qMTD+6LFMlKINbGsuDL3EKMEB7OSCG9FlFWkEG9KYmVValF+fFFpTmrxIUZTYNBPZJYSTc4H ZpW8knhDE0sDE1MzYwNjQwtLJXFe9ZXXIoQE0hNLUrNTUwtSi2D6mDg4pRoYFcVeHZlcdfDL hbgJt2ZrP5+rtemPW5NvoNA7Gdv9kT+qJl47rGzJkSZcdXZz1dFnwjyH567/FLZj44t/h91b g/XO5OX0CUSFnNzQwqHue+ofe/aWBWVuW2JWLJPe8IFFm+XJjJext7+0Tw15eYHr2UGxTbcE 1EM39e7f9+fmk1rG+8JRHqfmOSmxFGckGmoxFxUnAgBxUYLX8gMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsVy+t9jQd0t0VaRBrOWc1rcWneO1aL33Ekm i/fLehgt5h8Bcq98fc9mMen+BBaLN2/XMFm8uHeRxaL/8Wtmi/PnN7BbbHp8jdXi8q45bBYz zu9jslh6/SKTReveI+wWMya/ZLN4+fEEi4Ogx5p5axg9Nq3qZPPY/u0Bq8f97uNMHpuX1Hts 6b/L7tG3ZRWjx+dNcgEcUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+IUFK CmWJOaVAnpEBGnBwDnAPVtK3S3DLuPLgHnvBLvGKu5PPsDcw/hToYuTgkBAwkWhZGNPFyAlk iklcuLeerYuRi0NIYDWjxIUVq6Gc+4wSLY0r2UAahAV8JK61u4M0iAhoSlz/+50VpIZZYAGz xKEp/6EaDjNKrLnQxQJSxSagK/G15zoTiM0rYCexpv0aI4jNIqAq8XTaBmYQW1QgQmLX9QOs EDWCEj8m3wPr5RTQl3g6ZRs7iM0sYCbx5eVhVghbXmLzmrfMELa4RHPrTZYJjIKzkLTPQtIy C0nLLCQtCxhZVjFypRYU56bnFhsVGG1iBEb+tsNaATsYm85FH2IU4GBU4uGd0GQZKcSaWFZc mXuIUYKDWUmEtyLKKlKINyWxsiq1KD++qDQntfgQoynQSxOZpUST84FJKa8k3tDE0sjEwMzM 0MjA2ExJnHdC4JcIIYH0xJLU7NTUgtQimD4mDk6pBsaLSt+NIx4cDxbbdeykh1z8aZGSLtmS 19VPXplPXn/nrZ7H5Eu9SifcLBgX/s4Wnv/C+0Lm/pvXueWTBRNMb/I4P8j6W/78Dstxu/O5 e8Pu9zB2Zm46eX7DCxUltw3C7LefCTdJnnnzfkbyl6/PWFdmJdz2Wnbe9FGMTzF3w8GD0/cv /TflfP4/JZbijERDLeai4kQApNMx+hIDAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170609082628epcas5p3a99d13b17ec8ff21f366db2ec9d921b8 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170609025951epcas1p19f5ca8c241b8b79068a84eb239ed46ed X-RootMTR: 20170609025951epcas1p19f5ca8c241b8b79068a84eb239ed46ed References: <1496977173-20550-1-git-send-email-hoegeun.kwon@samsung.com> <20170609072754.GB4018@kozik-book> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote: > On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote: >> It should be connected to OF graph between fimd and dsi. >> Add the OF graph between fimd and dsi. > I need more explanation why this is needed. What happens without this? > What issue is fixed here? > > What about Exynos5250 and Exynos5420? I think we do not have a board in > mainline using FIMD but maybe this should be added just for correct > hardware description? Thank you for your review. I'm sorry, this patch is wrong. Please ignore this patch. :) Best regards, Hoegeun > > > Best regards, > Krzysztof > >> Signed-off-by: Hoegeun Kwon >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++ >> arch/arm/boot/dts/exynos4.dtsi | 26 ++++++++++++++++++++++++++ >> 2 files changed, 52 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 590ee44..22d523f 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -311,6 +311,19 @@ >> iommus = <&sysmmu_fimd0>; >> samsung,sysreg = <&sys_reg>; >> status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + fimd_to_dsi: endpoint { >> + remote-endpoint = >> + <&dsi_to_fimd>; >> + }; >> + }; >> + }; >> }; >> >> dsi_0: dsi@11C80000 { >> @@ -326,6 +339,19 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + dsi_to_fimd: endpoint { >> + remote-endpoint = >> + <&fimd_to_dsi>; >> + }; >> + }; >> + }; >> }; >> >> sysmmu_fimd0: sysmmu@11E20000 { >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 497a947..773d392 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -193,6 +193,19 @@ >> status = "disabled"; >> #address-cells = <1>; >> #size-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + dsi_to_fimd: endpoint { >> + remote-endpoint = >> + <&fimd_to_dsi>; >> + }; >> + }; >> + }; >> }; >> >> camera { >> @@ -715,6 +728,19 @@ >> iommus = <&sysmmu_fimd0>; >> samsung,sysreg = <&sys_reg>; >> status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + fimd_to_dsi: endpoint { >> + remote-endpoint = >> + <&dsi_to_fimd>; >> + }; >> + }; >> + }; >> }; >> >> tmu: tmu@100C0000 { >> -- >> 1.9.1 >> > >