From: Dave Hansen <dave.hansen@intel.com>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/mm: Remove duplicate definition of _PAGE_PAT_LARGE
Date: Tue, 5 Jan 2021 14:17:25 -0800 [thread overview]
Message-ID: <a990cea4-00ad-007e-68bc-ca0ad9422bcd@intel.com> (raw)
In-Reply-To: <X/TaBK3AnKJCbI3n@rani.riverdale.lan>
On 1/5/21 1:28 PM, Arvind Sankar wrote:
> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
> index 394757ee030a..f24d7ef8fffa 100644
> --- a/arch/x86/include/asm/pgtable_types.h
> +++ b/arch/x86/include/asm/pgtable_types.h
> @@ -177,8 +177,6 @@ enum page_cache_mode {
> #define __pgprot(x) ((pgprot_t) { (x) } )
> #define __pg(x) __pgprot(x)
>
> -#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)
Huh, I didn't realize that duplicate #defines were allowed. Guess you
learn something new every day. This looks fine to me, it removes the
exact dup that Ingo appears to have added.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2021-01-05 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 16:37 Definition of PMD_FLAGS_DEC_WP in arch/x86/mm/mem_encrypt_identity.c Arvind Sankar
2020-11-09 14:28 ` Tom Lendacky
2020-11-09 17:35 ` [PATCH] x86/mm/sme: Fix definition of PMD_FLAGS_DEC_WP Arvind Sankar
2020-11-09 20:41 ` Tom Lendacky
2020-11-09 21:42 ` Arvind Sankar
2020-11-10 23:31 ` Tom Lendacky
2020-11-11 16:09 ` [PATCH 1/2] " Arvind Sankar
2020-11-11 16:09 ` [PATCH 2/2] x86/mm: Remove duplicate definition of _PAGE_PAT_LARGE Arvind Sankar
2021-01-05 21:28 ` Arvind Sankar
2021-01-05 22:17 ` Dave Hansen [this message]
2021-01-08 21:12 ` [tip: x86/cleanups] " tip-bot2 for Arvind Sankar
2020-12-10 11:44 ` [tip: x86/urgent] x86/mm/mem_encrypt: Fix definition of PMD_FLAGS_DEC_WP tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a990cea4-00ad-007e-68bc-ca0ad9422bcd@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome