From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D0C330328 for ; Mon, 15 Jun 2026 10:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781517648; cv=none; b=qQUj3q++/BpQH7wvRhKCC3Qt0q4oe3HB/mR7cJOuGfyMeqoU1xGc4q4CYWOM3MOHT/wjtely2w10c9sk3qiv4TkENcBvZrypbvkDS5SF2nbRbMJAW1epTWLLoJJQMul16naswnNlheYuo99cSyZA4v/kT1s1jjtC6mrbDU5uvyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781517648; c=relaxed/simple; bh=DZlwvNFhOczSN15iV3ZhEhqrNk3Z2FnJ3q8czGO+XvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hyNrryMMqV8vAt1q368BnGA8isfh2+TunjMP7Jx6E9Zm+W1c0ymrTQz1LZztCc05twp9ISYnSo1u+C8gs6OBVsWaDgaEWc8BLi7wu1H7a/itQyY20oY2eMFKwcCxfAEBZwyZY/22L7SQjSHBEZLsjziLdEi49LnDPECTvCyTVfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dl5VIgMe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M84Uaqea; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dl5VIgMe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M84Uaqea" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65F9Z0si3818779 for ; Mon, 15 Jun 2026 10:00:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2AIOFqjx25h1fmAVRqpund2U9aeEiVKZYsg80qRzviI=; b=Dl5VIgMe8zt0RvuC Mp0Aiu7J+1B8czhXacbZfIPdBD1gOUrDMvq+fzMZ1Yg5iCIu6KSYHPK037kAvZiO br3PCfXR57OHKQl+tcfqKQLHXKgmzyJOyyvCHnR3Zwe29JGM7oAe1lm+Z2G6cU3N 4atN3XTZUW/V3qbmmy4Af4Cqk69uKyK+AcOiRTK+IbzHysKSo3S8TGKsYy1JEORU a2mGXvoNnujvKr/X5rwcW/ZoWwqkyzEB+SK6qtZz9rsgZKoyXVphwBz+g3AwlFoH eQG4/foq858KFROP4m8STRRHfZduyRvRVvBeXv9DvqnWX4Yw4744yxkzeLSU4BCk XGyOqw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etew0g36k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 10:00:46 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c0b35fa876so37324515ad.1 for ; Mon, 15 Jun 2026 03:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781517646; x=1782122446; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2AIOFqjx25h1fmAVRqpund2U9aeEiVKZYsg80qRzviI=; b=M84UaqeaCWTbVnxD1m8Wf3SCTlJ5ZpuidCa9DV8TPFe69GyFuV+6Mvqj6TNUjnlDE8 kmYj1fukbH/93XieXVFS57gOoZI7reLe8R9dR74dFfUCXtNfyG1RAYgQfXsXvR+eZUNM B3/+63+o8WRS4NaY3f1hKX2sh5HcL9A3L9LWMbC36cMgZioa0RVaw0kujCeDedHAXEcj ibGvvRX/LyOLUamnrVFsk1MO7w4AvmCt3lMi/OGA9wCZD2b5bjxNoIo/a3jusN4MJHbr oDf6POsZshnS2v35VvQk8jZff8yPel2e95Be2EvoKqj+m6tdTePZyKdKd6NCklHmYCFl SQnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781517646; x=1782122446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2AIOFqjx25h1fmAVRqpund2U9aeEiVKZYsg80qRzviI=; b=DMqEtkeENGYC93o2Pl9V8p5rwQww29fB6/wG/J8UZyRTpj2lLB3a2h+h8bI6WBaZoy x7wjPs/0Fnb+puWz8/aEJGQzsMi6EeNro74dE9xVWz6FgM8KYRZcKqdYc9VDHZbgdgCh Xlgvn3IoffzafUBbt/g6KCXVR9vp4LTewNdLmrOgjU16RpF55+dBt9foWd+nEXTIGnvf CxUlFQfDDpU8PvIQdsWxSXHYPyRp+L1lXz3slCYgj8BRNg1S7o5XU+ez7uvX3sePgIkj 6FFcHjO+sXvSiNX1qBWynKcEajpQfKy8utwUDP6T8DmoiI7tUdpXz1fv3FRU6zjSE6fp YRFA== X-Forwarded-Encrypted: i=1; AFNElJ8c5YZdEgOkTS5irb3FO4uU+Vv1M6+OuuQw1GS+wJ6g3/7DzYZGDtKGREYBAsEByK2Lz0ooCsO2dTYvjxA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy46AOfxrd/IX9zGiFkHT4oTH6K9yjku1RkzbWhADJENN62Nt/z OCAtmg/CeNacSRs85bBwIUKO9dgQ1OxBVvio3Q/la9d8Ka/Mb6+9mgadvf3rPgRWGaPziAAgYjS cpA9qU/bOn026YzKC3HBStYmXJte8C3kPhwc4NoFr81/Eds4WkQNroCf1TKWQzkdTc50= X-Gm-Gg: Acq92OH8W6JHDLT1B9mbA5RILwMPDgXY/K/XpAnrrH1O9CbcIS27BhzTgHXO8dMZkPe ROD8XvIoCVrtrrTltt91o02xPfahY4NA60r9DqEJ/lD6+2v3BIrfJOEHETyllFugP7Ve13+4VnB SVl4DbimSmuDfgoR+eSn+p0cvIbkmoHCwKDryRLTF+sg5Sh7Vsx3Mb1EpIrvnwSI5NE7bBnteBw dg9iznaH5d6X3cLtq71luU1ln/RKVaahm+SqycqyU+WYMpy3EzEI/ST26Wh6FABLCXAxq2M2Q4f 6FXMWAPbKAlGvtbOZJIAVj7Ox0NO6C55oqeI/g1Fio8GCW2Me3Q16DwJycatTlzfu0M+3roPhJQ uGPNnYhfXQwxFCPoZS3Xxo/685l0SOY+++d9Otd6yUkLnrWp8ji2RwgxClxQT X-Received: by 2002:a17:902:e783:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2c4134ec05dmr144412935ad.21.1781517646035; Mon, 15 Jun 2026 03:00:46 -0700 (PDT) X-Received: by 2002:a17:902:e783:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2c4134ec05dmr144411645ad.21.1781517644854; Mon, 15 Jun 2026 03:00:44 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c432c8ce89sm97213885ad.57.2026.06.15.03.00.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 03:00:44 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 15:30:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Add MI2S clock control To: Mark Brown Cc: Srinivas Kandagatla , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260608023011.942228-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260608023011.942228-3-mohammad.rafi.shaik@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEwNSBTYWx0ZWRfX97KsxgRO1/ut EjGWjr5pc9N56oaNGhO0uPn8ZhwPR8rJ/QHr7uL57CbbE5wYomspK5QMZYFzX+71nqwwMLSaf0k Lf8wEbn1Zz57ci/FpU2ZKUuBaKHcKvg= X-Authority-Analysis: v=2.4 cv=QLlYgALL c=1 sm=1 tr=0 ts=6a2fcd4e cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=2pCuibHp1YRUK2peGzAA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEwNSBTYWx0ZWRfXyuK5GxOYdAGW mLcX3MaV3fg4hod8AzdPfKTxneVsK7DMq1GswWAw34P1elMeT/3H+inD2O7VvgBUOFkqGExL64I tacqndvMnYN19ksLpJqPOmAIr45o6BrCURxl7HE0XMS8FN0KGB1utXq6vz5ydSX4ACJGFLNq2S2 oE7x2AflfPGONT0JacNr5An+qZnaZavRTpV/Xblktw2AU5unn9BLp5aSYheUCzhv/4FdPUokYoQ P1Wa9mInj3iB6888DPKML2u+W5GawZ8LHBvL8tc2cTPOlA2HlpzOSyT05EPmBC8d3x0RL5K8w+D H2yNJ5l+3+4y9Mjn3qiDxMpMj8Fv+LUb9E4v7jP35QSHvDNV+rkKWKmSs+A+dTejxUrGZpx7dAZ HP0gVbEDyA1qF75EkR7Rcbx+EjoU8cKO1dnOhweMsx0qJLcR0GU5nWGGTUyfOFI+fEw8k+op/ue g8opyILV0rTeK5u0QGg== X-Proofpoint-GUID: IHGK9PvV-bYUSb0K7ZFHjNpaFlELi1UQ X-Proofpoint-ORIG-GUID: IHGK9PvV-bYUSb0K7ZFHjNpaFlELi1UQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150105 On 6/8/2026 5:31 PM, Mark Brown wrote: > On Mon, Jun 08, 2026 at 08:00:10AM +0530, Mohammad Rafi Shaik wrote: >> Add support for MI2S clock control within q6apm-lpass DAIs, including >> handling of MCLK, BCLK, and ECLK via the DAI .set_sysclk callback. > >> +static int q6i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id, unsigned int freq, int dir) >> +{ >> + struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev); >> + struct clk *sysclk; >> + bool *enabled; > > Neither sysclk nor enabled are initialised by default... > Yes right, Thanks for pointing out. I will initialize sysclk and enabled to NULL and add an explicit error return in the default case of the switch statement to handle invalid clock IDs safely. >> + switch (clk_id) { > >> + case LPAIF_MI2S_ECLK: >> + sysclk = dai_data->priv[dai->id].eclk; >> + enabled = &dai_data->priv[dai->id].eclk_enabled; >> + break; >> + default: >> + break; >> + } >> + >> + if (sysclk) { > > ...but we just fall through the switch statement if the clock ID is > invalid and use the values. > ack, will fix this in next version. >> + for_each_child_of_node(dev->of_node, node) { > >> + if (IS_ERR(priv->mclk)) { >> + if (PTR_ERR(priv->mclk) == -EPROBE_DEFER) >> + return dev_err_probe(dev, PTR_ERR(priv->mclk), >> + "unable to get mi2s mclk\n"); >> + priv->mclk = NULL; >> + } > > Do we need to drop any OF references on early return? Yes, an of_node_put(node) is required before the early return to avoid a reference leak. I will update the code to use for_each_child_of_node_scoped() to handle the cleanup automatically, or explicitly call of_node_put() before returning. Thanks & Regards, Rafi.