From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f228.google.com (mail-qk1-f228.google.com [209.85.222.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A06D335078 for ; Wed, 14 Jan 2026 18:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768414946; cv=none; b=N0096xbLz+XcBSp4zs3f9gEDB/6vk06XVtq1RXCWR0KxN3ThN/5aN9zLUWNum3wgzHvyfQqg//FieZcE/d+O9N7u5X1OyiL7B3fEonzfSH8/GmZauVZUmOFavlAKwrVvHR+5sX9WMTWk/mfUuwItX/KT+2Tt79EwY3lXi5A8Dtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768414946; c=relaxed/simple; bh=wiIc7dSLmMyDHUTZ74c81ZTYpMMmL0tPFuAq0nhq574=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eGcKzLJRCSTlQ8brYMz/vdRBgYeP3jk6KYLAqlVByzzepnSXexvTK8D7aUJ1N7B6o/b8LbH6NX7M/HIzuAKjPUOwzWBD2IzqP3Ztj4STPUvAfRvKBNkILHQ01D0sWs0EWjfmKz8PBMqJxL9RO2x8oor3w/7XbAwd1dVuKJZU/Hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VL6sh7hc; arc=none smtp.client-ip=209.85.222.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VL6sh7hc" Received: by mail-qk1-f228.google.com with SMTP id af79cd13be357-8c533228383so6258585a.3 for ; Wed, 14 Jan 2026 10:22:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768414943; x=1769019743; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zvsCV4xxeZfBF7U+NpDM1p1RqT3IT06yXEOy1GqmxoE=; b=vz9tkS2zfUaZqv0Hx2QsW5QBPS5bzapKT292NpE59fXFxWCtQ1gbrHYWR7duvJ4Iox jWty0RafyCi1m5Lb10Tc29XqRQX+b9lzwwWXKZnBeVsUXCstxI9cTWicT6UEuiKh8GiM 4/GZP8cV/hL7c+etERrQGAhrrMQyMKd/jE9A0m2VzuZK4mJgAV5TpAzZzVteh2nOVVZT m46Zoofuf3mYkg5OWKam5yo0qDOJx8sxvORo66ibdHfCEyHkRCGbbcx8AVzEDom3QAoB 1S60j4eVuzS6wvlBgTNb7HF8jdxYnjQPqtXNWqdhesBMOXcGQ5x2Kk1vb77iXzyRcX9T lZJw== X-Forwarded-Encrypted: i=1; AJvYcCURldWyZ25z6Vq1fNsvAzbhHNfBFH4mD6DHVuo8EUzXpYKUhrNwfgd4vDRwdss/hQ8zIePfnysq81S6IVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Vf1250akH1tnzyGvfv9lpVx9nwV67yQp2VnOh70X7RPHw4T0 mDPofD4gJhHK0r1DEGk3b7ub7Xat3xdE0Nup8m6XNqWN5qkD8oWP/3iIHlrUmczkpggv1uT1MO5 XFMXffZbqwBaWm9vu2AzmFfM6zhhoORMH+/F0ccfvoX5ybWgeZVkzU9IZWPSIbRtpdAmGGGyZoy KoCzHGswepL2R/TTMYsQyzwsxtGeLCvtk/USZkS0CqqJuX8PitXSGxLPXKOT+UsPThOWoAneHjz 17mKhJG9bG5CP3Xj6Ck46Kp X-Gm-Gg: AY/fxX4M1IW8ALzBdfFdp2QfZs3FMOrYZaYOMmT3H8xC4NRffoHdxBaqNBXrF1J1bMx 8Bq1avC+y3RI2KZZewJ3pBdCaF6rdrTnUKJb1ckCGKyE+bnjDN22F12NnhtUWd4c1NiRAdAcLl9 YOiNuDxarGwX8KepX6PGnenrIPmROLr+5FhaEcsLR2Jipg3RCiUpBTJXcZw0YavHbxkBxzJfy7d iBH+SDP11KXRgyy5VI0XpBsDG/knsa2u5IEnVtfRnfXQ2gX4Cveyf89a/433iaM3USxdl0VKAh0 XDd5UUWEgVCdVFXuSFUMiVE5LJAoj+5GE3hi2mwbvkcoiLxt0XHqe9+OV6vAIRGqvK5e/ozWyUg Sncev2qglyZ+isjPtcGqvqcpb8ki0r1bW/ooZBFjzQysGpCZoLEEdob8e/3fY1WUQ7UGIpgsKAw fMJ9AY7XWW5RVwTP4v6iZhB3wiGdlDz5ZpW3YrqKhcqSvMBuM= X-Received: by 2002:a05:620a:bca:b0:8c3:650d:577e with SMTP id af79cd13be357-8c52fb32a9dmr407990485a.4.1768414943069; Wed, 14 Jan 2026 10:22:23 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-89077093b36sm29750516d6.2.2026.01.14.10.22.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jan 2026 10:22:23 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ae32686ed0so856717eec.0 for ; Wed, 14 Jan 2026 10:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768414942; x=1769019742; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zvsCV4xxeZfBF7U+NpDM1p1RqT3IT06yXEOy1GqmxoE=; b=VL6sh7hcn+ISA3reORZwMfmKgbIS+0fu3aiXPZEefGzEaLJf9kodv/uVjct8k0wjHk neJUaJtImmSP6Hoj/EBpkuXXOvT+pTCFUJX64pMd78YnVJxmu6xzs9bEsWaGoenkUiMn x7lTJPYvdJ+i53c3+J6RFmhorp5JOg/27ZXyU= X-Forwarded-Encrypted: i=1; AJvYcCV5LLEubbfxaPFkzHX4ej0umrzkSByb+/08J6XoExJ2EPXXLn9+t6Z2RvTTiSxhcQ/KHGOazal5TFPewKM=@vger.kernel.org X-Received: by 2002:a05:7300:6901:b0:2ae:5bde:a5c5 with SMTP id 5a478bee46e88-2b4870abc8dmr3633853eec.30.1768414941857; Wed, 14 Jan 2026 10:22:21 -0800 (PST) X-Received: by 2002:a05:7300:6901:b0:2ae:5bde:a5c5 with SMTP id 5a478bee46e88-2b4870abc8dmr3633817eec.30.1768414941183; Wed, 14 Jan 2026 10:22:21 -0800 (PST) Received: from [10.88.173.133] ([207.212.61.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707da231sm22380597eec.34.2026.01.14.10.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 10:22:20 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 10:22:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ARM: dts: broadcom: bcm2835-rpi: Move the firmware node down 1 level To: "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: Marek Szyprowski , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260114015810.701076-2-robh@kernel.org> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260114015810.701076-2-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/13/2026 5:58 PM, Rob Herring (Arm) wrote: > Commit 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non > simple-bus nodes to root level") moved the firmware nodes into the > standard /firmware. However, /firmware is intended to be just a > container for firmware nodes as it is possible to have multiple types of > firmware (e.g. SCMI, OP-TEE, etc.). Move the RPi firmware down a level. > > Fixes: 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non simple-bus nodes to root level") > Reported-by: Marek Szyprowski > Signed-off-by: Rob Herring (Arm) > --- > This is only half the fix. Unfortunately, a kernel change[1] is also > needed to make this all work. I do plan for that to go to stable. I'll > leave it up to the Broadcom maintainers whether it's preferred to revert > the fixed patches or apply these fixes. A 3rd option is revert for now > and apply these DT changes some time later to give some time for stable > updates. Let's wait until your fix for the /firmware match table gets applied and then I will pick up your two changes. -- Florian