From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-samsung-soc@vger.kernel.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Linus Walleij <linusw@kernel.org>,
"moderated list:PIN CONTROLLER - SAMSUNG"
<linux-arm-kernel@lists.infradead.org>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: samsung: exynos: replace irq_of_parse_and_map with modern APIs
Date: Tue, 28 Jul 2026 08:05:34 +0200 [thread overview]
Message-ID: <a9a2caab-f93b-448a-b846-7e739c143687@kernel.org> (raw)
In-Reply-To: <20260727194836.11689-1-rosenp@gmail.com>
On 27/07/2026 21:48, Rosen Penev wrote:
> Replace irq_of_parse_and_map() with fwnode_irq_get() for per-pin IRQ
> lookup and of_irq_get() for the muxed EINT IRQ. The fwnode-based API
> works with both OF and ACPI fwnodes and follows modern conventions.
And what is the point of ACPI here? I see no point in such conversions
of one call while leading everything untouched. Add proper ACPI support
with valid ACPI tables with ENTIRE driver converted, not one call.
>
> For the muxed EINT path, change the error handling to propagate the
> error code rather than silently returning 0.
But why?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-28 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 19:48 Rosen Penev
2026-07-28 6:05 ` Krzysztof Kozlowski [this message]
2026-07-29 21:03 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9a2caab-f93b-448a-b846-7e739c143687@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=rosenp@gmail.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®