RE: [PATCH V2] tty/serial: add support for Xilinx PS UART

[John Linn <John.Linn@xilinx.com>]

> -----Original Message-----
> From: John Linn
> Sent: Friday, April 22, 2011 7:36 AM
> To: 'michal.simek@petalogix.com'
> Cc: linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org;
> alan@lxorguk.ukuu.org.uk; greg@kroah.com; grant.likely@secretlab.ca
> Subject: RE: [PATCH V2] tty/serial: add support for Xilinx PS UART
> 
> > -----Original Message-----
> > From: Michal Simek [mailto:michal.simek@petalogix.com]
> > Sent: Friday, April 22, 2011 3:11 AM
> > To: John Linn
> > Cc: linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org;
> > alan@lxorguk.ukuu.org.uk; greg@kroah.com; grant.likely@secretlab.ca
> > Subject: Re: [PATCH V2] tty/serial: add support for Xilinx PS UART
> >
> > John Linn wrote:
> > > The Xilinx PS Uart is used on the new ARM based SoC. This
> > > UART is not compatible with others such that a seperate
> > > driver is required.
> > >
> > > Signed-off-by: John Linn <john.linn@xilinx.com>
> > > ---
> > >
> > > V2 Changes
> > >
> 
> Hi Michal,
> 
> I don't have a problem removing the empty lines, but is there some
> guideline on that
> which I'm ignoring and should know?

Those were pretty ugly, didn't realize they were all in there, no big
deal. I found a few more than you did :)

Thanks,
John

> 
> > AFAIK. Grant proposed to write it in different style. I think he
will
> > agree with me.
> >
> > #ifdef CONFIG_OF
> > static struct of_device_id xuartps_of_match[] __devinitdata = {
> > 	{ .compatible = "xlnx,xuartps", },
> > 	{}
> > };
> > MODULE_DEVICE_TABLE(of, xuartps_of_match);
> > #else
> > #define xuartps_of_match NULL
> > #endif
> >
> >
> > static struct platform_driver xuartps_platform_driver = {
> > 	.probe   = xuartps_probe,		/* Probe method */
> > 	.remove  = __exit_p(xuartps_remove),	/* Detach method */
> > 	.suspend = xuartps_suspend,		/* Suspend */
> > 	.resume  = xuartps_resume,		/* Resume after a
suspend */
> > 	.driver  = {
> > 		.owner = THIS_MODULE,
> > 		.name = XUARTPS_NAME,		/* Driver name */
> > 		.of_match_table = xuartps_of_match,
> > 	},
> > };
> >
> 
> I'll check it out, that does look familiar to me now that you say it.
> We've had this
> driver around for a while so it just needs to be updated to the newer
> style.
> 
> Easy enough.
> 
> Thanks for the review and input,
> John
> 
> > Regards,
> > Michal
> >
> >
> >
> > --
> > Michal Simek, Ing. (M.Eng)
> > PetaLogix - Linux Solutions for a Reconfigurable World
> > w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-
> > 30090663


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.