From: Paolo Bonzini <pbonzini@redhat.com>
To: Yi Wang <wang.yi59@zte.com.cn>
Cc: rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
xu.xi8@zte.com.cn
Subject: Re: [PATCH] KVM: x86: fix failure of injecting exceptions in x86_emulate_instruction
Date: Thu, 20 Sep 2018 18:53:55 +0200 [thread overview]
Message-ID: <a9a47c9b-c8b9-74f4-78ef-fb54c7fe806d@redhat.com> (raw)
In-Reply-To: <9835d255-dd9a-222b-f4a2-93611175b326@redhat.com>
On 20/09/2018 18:30, Paolo Bonzini wrote:
> On 06/09/2018 10:02, Yi Wang wrote:
>> In order to fix a page table walk issue, commit 6ea6e84309ca
>> ("KVM: x86: inject exceptions produced by x86_decode_insn") check
>> if variable ctxt->have_exception true and inject the exception.
>> Unfortunately, ctxt->have_exception is set to true only in function
>> x86_emulate_insn(), which won't be called before invoking
>> inject_emulated_exception() in the 6ea6e84309ca.
>> This patch fix this issue.
>>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Xi Xu <xu.xi8@zte.com.cn>
>
> Queued, thanks. Do you have a testcase for this?
Unqueued, sorry. The hypercall test from kvm-unit-tests fails. A
VMCALL on the "edge" of canonical address space, i.e. at 0x7ffffffffffd,
raises a general protection fault before this patch and a double fault
afterwards.
Paolo
next prev parent reply other threads:[~2018-09-20 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 8:02 Yi Wang
2018-09-20 16:30 ` Paolo Bonzini
2018-09-20 16:53 ` Paolo Bonzini [this message]
2018-09-20 17:50 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9a47c9b-c8b9-74f4-78ef-fb54c7fe806d@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=x86@kernel.org \
--cc=xu.xi8@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®