From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: angkery <angkery@163.com>, axboe@kernel.dk
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
Date: Sat, 10 Apr 2021 11:52:08 +0300 [thread overview]
Message-ID: <a9af3dac-7ce5-71fb-5d89-a9afab4e48d4@gmail.com> (raw)
In-Reply-To: <20210409234242.1979-1-angkery@163.com>
On 10.04.2021 2:42, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> Fixes coccicheck warnings:
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0
>
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> ---
> changes in v1:
> update the commit information.
Not seeing what's updated, and anwyways it should read irq < 0, else it
doesn't make sense...
[...]
MBR, Sergei
prev parent reply other threads:[~2021-04-10 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 23:42 angkery
2021-04-10 8:52 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9af3dac-7ce5-71fb-5d89-a9afab4e48d4@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=angkery@163.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangjunlin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®