From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010213B14D4 for ; Mon, 8 Jun 2026 08:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907721; cv=none; b=Y98u3udRY9TGWsIr3vWYN0fW42NQAowvjakwL5X6Z9nVpFU/DVsH3z4rsQKMbZQrVjCI5rqWnSeMaCLL0iIkGpyAoRiy8EU3bVXzzy1SYCJjrtej0mDW+2hWgRk/gKJfIvhmFl8wmW81COHHHnJggsvSOOMF0lnTL7dvF8bevI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907721; c=relaxed/simple; bh=Sfj5gt6MvIEmG0HbHoKsMbRpZjmrEHXu8jQM2CsCIY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TEu27HMlyX1QwoOwEotoEcoKoOv/JjeM5smq0V1F5GQuxuAjMuoQNgMoeQB2od/jHX4YE4z/JgQYUozSKQgI1wb2XfgAHe06YP9igtJMMetJPQlUmJ+LFAgdhYJxxpRiVes3W5Dlu8eGKZuZ0tDowlfiyHYshUtupd4F6TkxBhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ne8mE17G; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DtFkyhEq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ne8mE17G"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DtFkyhEq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780907713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lrvJesBjI5N3mqdjRc1dMOyxu185onYyp291JtEzMjE=; b=Ne8mE17GRmRUhWRufmS4hY3aVr1coZHmySuo9SoFUCl/Es4iN17qAv3thKqH+pwTpHkcRE El8YyTKDPzQ8t/g+i30+vQizMgRbeyefU1GAxQCrfi/YLD+vDC408ekxpK7Fx8Ht0j+2nt 0MeN6fexUDwP8eg2cblLUpX/7ptwKVM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-7Cl64OnJNWO51GHKAQzAHg-1; Mon, 08 Jun 2026 04:35:06 -0400 X-MC-Unique: 7Cl64OnJNWO51GHKAQzAHg-1 X-Mimecast-MFC-AGG-ID: 7Cl64OnJNWO51GHKAQzAHg_1780907706 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490ae3bcf4cso19713905e9.3 for ; Mon, 08 Jun 2026 01:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780907706; x=1781512506; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lrvJesBjI5N3mqdjRc1dMOyxu185onYyp291JtEzMjE=; b=DtFkyhEqHDXiBFPWvDGNOBtNPn0yD/hRecDfh9xweMFy1TQOFixMuYWN0Wi3R9a5Qi uSPLNQVu1pGFpzc1gqpFEKMPzUdWl7NQOXItBD3nOR7Y1GLnLuIR6QVa41sIb2PqM7bk JbLIzqLld2Qh1NYu0hnnsBVlkkmQSBu+5LN3sZmvuIbM0nrVGQ0Xytp7R0JMwroCj/FA 3QbiBorBCO4f1Ul206J1Jh6+MIvV3xLU8k1eF9qtmFPRNAnVieKUkuXZHW6WakeGKgeo JtcI6CCZGuG+V2yBoPP3Wter4jrtfme7hZ02yBCE1bHTa7TPc6/Dqg0bWiuQ7LOXqYLy NTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780907706; x=1781512506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lrvJesBjI5N3mqdjRc1dMOyxu185onYyp291JtEzMjE=; b=lFcUTnsUSvvsPBPO9LdmsNE9ojzTyUStfI0psyCknbhzqwfbkgtzLZqHQZ0K9/Hh/W IAxWDIO9oWAwGjZt6dKbAjGx/1/WNrLS1bMBZBsCk5GU3ocizc2brDeyN8HR/4jVZ3Cu YBWRMzmn2/hatAfAQBC0k485pqGqk3F6HSNodFSNpDYm1pnHuE9LH2E1AJT+HVWa6yLg fJpZn9c0iuSN+Q3gcnnKSveJm29VVGkLhGz7/KqdCTRtJBELPHVBFaZB6z7dw3fXjhJB ltyCeirDbHcCrCGfndz8bFEKbXE+T48U2/DhBOU+Y61x/lBuJ+vAZKDKNS5nlmusqKRA ocTA== X-Gm-Message-State: AOJu0YxKU3GiIg60R/9fh8xMsXncMIMwtZbdzK8/UOGEH0y15jaRaQtH Clp1x2R/5e8niVPwpNbGCMc0HWu04tAa7ooK5eSsDYoh8wZTf/LWwx55K4oA1nWwnKYw09Ux5tK OY/QfZfFzbkn+YJjXpPLAU+VP0eukl6CTyL2z0SnIg9dMOdMwoIPsOu1WRa+DQXBfABl5D7kgSV kE6MjnPhfLcDbqezjM8GMT6IuDbxNTreW/IkF7S4+iLKI= X-Gm-Gg: Acq92OHFXQPKVDsAXug8mQADrMjPumIf4vZ1K0Bha52Ecj40KgJ9wu4RJSD7wieJDYZ qkDGWsJG4UQPKsc9D7erRUyywbEMjlvwetXw7qejsYmxR75phIyeAM5KXZvGXmkG7sESNXx60IT BUPmRESi3oFpd8dFg1iZ54kQjrvxZxvrML1xX4yIB0Au26JoQvbtm2AkRZH8r4PaFk/G0SOETKn yAnmGbBFKYrbo0rhkhgZ7fzjvwYFppeQrHyPcRXgnBz8aY7LO2HdQOvx4ZWnpL097UVM8xa8TYT HBfpeu39dZ5SSMHL6xfbKjshWc3Ze6aE28Bp8lI/MqJd/rW6Sz55zAUdFuklB2cASewO1o8xr+C OgITe7r6PYxTaAnXK4COp5go= X-Received: by 2002:a05:600c:6087:b0:48a:8b02:ae91 with SMTP id 5b1f17b1804b1-490c25b0231mr252123705e9.11.1780907705569; Mon, 08 Jun 2026 01:35:05 -0700 (PDT) X-Received: by 2002:a05:600c:6087:b0:48a:8b02:ae91 with SMTP id 5b1f17b1804b1-490c25b0231mr252122505e9.11.1780907704887; Mon, 08 Jun 2026 01:35:04 -0700 (PDT) Received: from redhat.com ([31.152.37.159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc391aaasm433938045e9.1.2026.06.08.01.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:35:04 -0700 (PDT) Date: Mon, 8 Jun 2026 04:34:57 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v10 05/37] mm: hugetlb: remove dead alloc_hugetlb_folio stub Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent Remove the !CONFIG_HUGETLB_PAGE stub for alloc_hugetlb_folio(). The stub is dead code: all callers are in mm/hugetlb.c (CONFIG_HUGETLB_PAGE) or fs/hugetlbfs/inode.c (CONFIG_HUGETLBFS), and CONFIG_HUGETLB_PAGE is def_bool HUGETLBFS with nothing selecting it independently. The stub is also broken: it returns NULL, but all callers check IS_ERR(folio), so a NULL return would not be caught and would crash on the subsequent folio dereference. Remove it now since follow-up patches change the signature of alloc_hugetlb_folio and would otherwise need to update the broken stub too. Reviewed-by: Gregory Price Assisted-by: Claude:claude-opus-4-6 Reviewed-by: Dev Jain Signed-off-by: Michael S. Tsirkin --- include/linux/hugetlb.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 5957bc25efa8..1f7ae6609e51 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -1123,13 +1123,6 @@ static inline void wait_for_freed_hugetlb_folios(void) { } -static inline struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, - unsigned long addr, - bool cow_from_owner) -{ - return NULL; -} - static inline struct folio * alloc_hugetlb_folio_reserve(struct hstate *h, int preferred_nid, nodemask_t *nmask, gfp_t gfp_mask) -- MST