From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: dsa: b53: Support setting learning on port
Date: Mon, 22 Feb 2021 13:52:25 -0800 [thread overview]
Message-ID: <a9b9a186-9c9d-b2bc-82cc-c99e2012061f@gmail.com> (raw)
In-Reply-To: <20210222214641.2865493-1-f.fainelli@gmail.com>
On 2/22/2021 1:46 PM, Florian Fainelli wrote:
> Add support for being able to set the learning attribute on port, and
> make sure that the standalone ports start up with learning disabled.
>
> We can remove the code in bcm_sf2 that configured the ports learning
> attribute because we want the standalone ports to have learning disabled
> by default and port 7 cannot be bridged, so its learning attribute will
> not change past its initial configuration.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> David, Jakub,
>
> This is submitted against "net" because this is technically a bug fix
> since ports should not have had learning enabled by default but given
> this is dependent upon Vladimir's recent br_flags series, there is no
> Fixes tag provided.
>
> I will be providing targeted stable backports that look a bit
> difference.
This is incorrect because I did not update the supported mask of BR_*
bits that we support, v2 coming shortly.
--
Florian
prev parent reply other threads:[~2021-02-22 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 21:46 Florian Fainelli
2021-02-22 21:52 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b9a186-9c9d-b2bc-82cc-c99e2012061f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®