From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983CF1E51E0 for ; Thu, 5 Feb 2026 09:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770284438; cv=none; b=cgOxduPwD9wl4sMSDBc4BKzeH+pZ/XqR/T/Jjjoam+SIPoE79q134mb9MoBTNSKYO1IF6odu7LL7Dr1FvyLgf+rmEpA3j4SNLve8lvW7U9aAcs6Nb9swgqYrDkmenZvrfDXga6TDbO5RyyVdFWSOG7hft7Y9h8BgWkB+u93vNYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770284438; c=relaxed/simple; bh=6OP4X1GRRM5LIjBE2kov2yEkqnOd0tKwLWVXu8fzT78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C7R6WL0bBTXy+8faXrCA6ObGNIbvIsxxiTDIZgj8UcsWP6H/tS00ZTfRcY6ACJp9o1qbwtnE/LJISzrptkBys+qT7XdtTOEIoDrN9W0qPoa7U8AAQ4R3T0e6EsOngUm3QRCqC/ctURM/ikbjLJm7My7+1b5MFILX1WT+j2ItvqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gohF43ol; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Cbj1ajw8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gohF43ol"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Cbj1ajw8" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6153dkNu3030973 for ; Thu, 5 Feb 2026 09:40:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HQQ358TlNZqts7bN6Y5kHCWLryFbr3guTvwxcXlcfD8=; b=gohF43olQU++Mikw 9FYRKJEaSoQZQ0rDWR0ROeoKrW673uPSVodAJVri5EkRbgtn7o4lkTjo9dQHU4WK np9EUhdUVOstd2Vmps6XNC4sbpgY0MlLHBpciYH2bqUoExU0wS94RqLulvDfCtbW bEAsi0ilybPyrXfyC9Pve+395nrw46Yyl/XaQrfhJLWfGdWUmOVsjCba08GopZz/ u83B2bR72I/qWUHV4DtAV0aT0vCnXDNPiYd9zMBf4iXrqGIuQhfMzUi8C+SfUQS5 25fO2AJMl+Plqs9w7zXM40QAPX8T7c9exuaWGFrlZPF2YHGo0h8lIsNW2ppbt9Vc mESzCw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c4a7tjp62-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Feb 2026 09:40:37 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81efa628efbso799292b3a.1 for ; Thu, 05 Feb 2026 01:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770284437; x=1770889237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HQQ358TlNZqts7bN6Y5kHCWLryFbr3guTvwxcXlcfD8=; b=Cbj1ajw8KpKGGDySLUael5HFPLna+rtb6wTZa7QVimDmjggJx2R7oPF1TnNjvo9stJ B74yBXfEk7IDS2J1F2Q/XutVo7wS0mHGCUG2zUMWKo/DdOWIzld3JF3kWCRdhry47jIk l495ZAxRUNDEb1r70kwA38aLQtYqbrJsfu+ED5thjgSOHkpk2NsC07MlJrJJ9h+HT0eO uKRqHhwYYqFl6uMZZGUJeRx0e6MOCcdo+tUSMtvS/bXz+EBfx/JVBipmxYary/1HPov4 48qnj1f1EGAXwbC8pqBheg7jqxbuP4YbN+MBpiNncnIAXIkJkyJJIScdKetFSC5D00e4 oBRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770284437; x=1770889237; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HQQ358TlNZqts7bN6Y5kHCWLryFbr3guTvwxcXlcfD8=; b=Sdx4Qu4tPIZxdtyeRF+THwwJAxIr92cpiRMX86QF7UUL09R8olAewUz06Xr6g14B5J Kk4Fgnq6VoVZ8fFU2FtdvWQlgxIu7B8Wl2XRXoTK/tJZ7qTPdL3bFeZ+vIP5Tg+zlYA7 t+fjzhTkQKHNahiI4GCyrc/30xkpA5Ptr7ctE64NAP2XZYRn4+e7CV0cconL5phNcRmq MK1TH0eQBXbTLILoOCWvY+rlCTCCw5y7GEJxWu6ZKdMZLxoiA4A3FGumGSDDeyY++4V9 7DbLtr5GInQIEn7a+x3ztqd4hTGVeBWxEFWOJ+7Of8Farpr7kY1mMZM6FeI87XoO/+IQ 3CUg== X-Forwarded-Encrypted: i=1; AJvYcCWb6LtjzQXzyov0tgomWI94ViMRXatOjHn5lKZOq6AXQaDfm4MOv8Wb4Ly4grVHN7DZw/62XZT5aKxUpxo=@vger.kernel.org X-Gm-Message-State: AOJu0YxdfPSX6Z56gWLqrxAeOSDgBtJUFpmevCy710Cu78AywDV8dDaW XqqO0ZYtQz1q4Cdc2bzfh3M+ejh7695GcB1f5aV94xsf+jQGG8/yIRFPNY1TQp6478bHPvqtl6B dKec7F9d/JnztHoFamebkzMjab4z1vMTukrGDfy+NyAlH1/rUJv1tkys/vXF/fPOpq5g= X-Gm-Gg: AZuq6aKRux4f1Y7ixT/jzRIPjBPPvqFvnwCxrIz98JpogJ1hTkQPEjqoHz1YTZxCnwV O5cCgZJPHjGDH3qOk+niFv4zhXP1VUMlxRH8WZOs/8ASiKbXNOetUswvJCJl+qQGUkYH1bfQqR8 dN5gOKLt8z10O89QLpS97l8vn/fLUFmN7iO5usnYkHzkCCRVwYvg7AjaZksf3oGETs4QFvRyuyl TsM0lxgdmixUKqiStq3pu36QBfghjGQZCrn66dfuwLoUKwo4UB2GY8Y9+vIShC9lxBVRDAOUbjH 3uDIIFdBnbU8yGXfdmBe6r90K/dvQkh946/Sj6n/2sRI9XQy7D3kqTQB++mN0tJa/bSZCNopbrH iiwFL3lkywL+IzOlFYJLEtEGfZpILxRN2clo4Txqqgw== X-Received: by 2002:a05:6a00:1709:b0:823:1726:aedc with SMTP id d2e1a72fcca58-8241c64598dmr5170937b3a.50.1770284437016; Thu, 05 Feb 2026 01:40:37 -0800 (PST) X-Received: by 2002:a05:6a00:1709:b0:823:1726:aedc with SMTP id d2e1a72fcca58-8241c64598dmr5170907b3a.50.1770284436566; Thu, 05 Feb 2026 01:40:36 -0800 (PST) Received: from [10.217.216.195] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d16f5b9sm6773391b3a.7.2026.02.05.01.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 01:40:36 -0800 (PST) Message-ID: Date: Thu, 5 Feb 2026 15:10:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS To: Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20260202070534.1281652-1-odelu.kukatla@oss.qualcomm.com> <20260202070534.1281652-2-odelu.kukatla@oss.qualcomm.com> <95d42fb7-2365-46a0-a995-c9cc51b17424@oss.qualcomm.com> Content-Language: en-US From: Odelu Kukatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: lJ9vkFviBQUILLrKbUyH7gWHzcWJGzku X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA3MCBTYWx0ZWRfX8vOGakVGQ3mh ss2A1YXP49bIkF/d/9Zzbnar3h9SEkd3TO/CZ6EkpfGEXTy2NwG7RH2uZI7c8vI5vH4iXJy84yq +4T8LF6rNP2B6eKopQMuw1L+YbaTfK/pnrzTOGqKXVj4qTO2MtIRb74loet7RX4DAp66iRtbPRd /bVobJhPFTWAfMg5K6M07ZqtmcFytG1oe1HrtBX5HZrplo4Oahea39M5wBtVwHXgHX+OdVpJMi5 PJtwUwMmifvnD/IMnlNatz2jSOirGXDIuTTkhKpPfj73HdWSiTCMWaU1/UXjeFLGFtUktGjJN5v 9CGgF4l9Z/rJBLlMzjmYmBPewpDaMI4f2kyX/tF8ViyFxTt9qTwP8rjlLYf2/e5h+teMaLWeAi3 l4Vx4DDAfNhq6eDWVkMSrEwosFC7JAPmLVAvaoLxDqn3bkmm1FYGncK0DDYOUx9U3FFspGP6uOY bxKHANxIhs1dlhr13vA== X-Proofpoint-GUID: lJ9vkFviBQUILLrKbUyH7gWHzcWJGzku X-Authority-Analysis: v=2.4 cv=QaVrf8bv c=1 sm=1 tr=0 ts=69846595 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=_oi8KRYSsQRZKH7G7RYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_01,2026-02-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050070 On 2/5/2026 2:31 PM, Konrad Dybcio wrote: > On 2/5/26 7:06 AM, Odelu Kukatla wrote: >> >> >> On 2/2/2026 4:33 PM, Konrad Dybcio wrote: >>> On 2/2/26 8:05 AM, Odelu Kukatla wrote: >>>> Aggre1-noc interconnect node on QCS615 has QoS registers located >>>> inside a block whose interface is clock-gated. For that node, >>>> driver must enable the corresponding clock(s) before accessing >>>> the registers. Add the 'clocks' property so the driver can obtain >>>> and enable the required clock(s). >>>> >>>> Only interconnects that have clock‑gated QoS register interface >>>> use this property; it is not applicable to all interconnect nodes. >>>> >>>> Signed-off-by: Odelu Kukatla >>>> --- > > [...] > >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - qcom,qcs615-aggre1-noc >>>> + then: >>>> + properties: >>>> + clocks: >>>> + items: >>>> + - description: aggre UFS PHY AXI clock >>>> + - description: aggre USB2 SEC AXI clock >>>> + - description: aggre USB3 PRIM AXI clock >>> >>> Should we also include the IPA clock here? >>> >> >> Thanks for the review! >> >> For QCS615, the IPA clock is already enabled by the bootloader (xBL) and >> kept on during the boot‑up stage. Because of this, we do not need to >> explicitly enable the IPA clock in the interconnect driver when >> accessing the QoS registers. > > Would we need to re-enable it to re-program the hardware if say the > icc module is loaded after unused clk cleanup or after a cx collapse? > IPA clock is not managed by GCC clock controller driver, so clk_disable_unused does not disable it. As a result, the icc provider does not need to re enable an IPA clock for QoS access after unused clk cleanup. And QCS615 does *not* support Cx collapse. Thanks, Odelu > Konrad