mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jason Wang <wangborong@cdjrlc.com>, daniel@ffwll.ch
Cc: airlied@linux.ie, Xinhui.Pan@amd.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
	christian.koenig@amd.com
Subject: Re: [PATCH] dma-buf: Fix comment typo
Date: Mon, 18 Jul 2022 16:44:34 +0200	[thread overview]
Message-ID: <a9ca8493-5fe6-4271-d551-284b99549664@amd.com> (raw)
In-Reply-To: <20220715052017.31633-1-wangborong@cdjrlc.com>

Am 15.07.22 um 07:20 schrieb Jason Wang:
> The double `have' is duplicated in line 696, remove one.

The subject line is rather confusing since this isn't related to DMA-buf 
at all.

Please change that to "drm/radeon:", apart from that the patch looks 
good to me.

Christian.

>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>   drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
> index 84843b3b3aef..261fcbae88d7 100644
> --- a/drivers/gpu/drm/radeon/radeon_gem.c
> +++ b/drivers/gpu/drm/radeon/radeon_gem.c
> @@ -693,7 +693,7 @@ int radeon_gem_va_ioctl(struct drm_device *dev, void *data,
>   	}
>   
>   	/* !! DONT REMOVE !!
> -	 * We don't support vm_id yet, to be sure we don't have have broken
> +	 * We don't support vm_id yet, to be sure we don't have broken
>   	 * userspace, reject anyone trying to use non 0 value thus moving
>   	 * forward we can use those fields without breaking existant userspace
>   	 */


      reply	other threads:[~2022-07-18 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  5:20 Jason Wang
2022-07-18 14:44 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9ca8493-5fe6-4271-d551-284b99549664@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangborong@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®