mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Julien Massot <julien.massot@collabora.com>,
	kernel@collabora.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq
Date: Mon, 4 Aug 2025 10:05:21 +0200	[thread overview]
Message-ID: <a9cd33f5-cc37-4a1d-b1fd-094761a146ed@collabora.com> (raw)
In-Reply-To: <20250801-radxa-nio-12-l-gpio-v1-1-d0840f85d2c8@collabora.com>

Il 01/08/25 15:16, Julien Massot ha scritto:
> A recent commit in linux-next added support for key events.
> However, the key release event is not properly handled: only key press events
> are generated, leaving key states stuck in "pressed".
> 
> This patch ensures that both key press and key release events are properly
> emitted by handling the release logic correctly.
> 
> Note: the code was introduced in linux-next by commit
> bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
> and is not yet present in mainline.
> 
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Well, you are effectively fixing the commit that you pointed out, so this needs

Fixes: bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")

and

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Cheers,
Angelo



  parent reply	other threads:[~2025-08-04  8:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 13:16 [PATCH 0/3] Radxa NIO 12L: Add GPIO keys and LED support Julien Massot
2025-08-01 13:16 ` [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq Julien Massot
2025-08-02  1:02   ` kernel test robot
2025-08-04  8:05   ` AngeloGioacchino Del Regno [this message]
2025-08-06 16:49     ` Dmitry Torokhov
2025-08-26 13:51       ` Julien Massot
2025-08-01 13:16 ` [PATCH 2/3] arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support Julien Massot
2025-08-04  8:05   ` AngeloGioacchino Del Regno
2025-08-01 13:16 ` [PATCH 3/3] arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs Julien Massot
2025-08-04  8:05   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9cd33f5-cc37-4a1d-b1fd-094761a146ed@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=julien.massot@collabora.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®