From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 867C151FCDA for ; Thu, 15 Oct 2026 12:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792068412; cv=none; b=stwJ/FIPWjrPR7nCO9Qi06U2U5ynIbhTVMKtcmC1o+ChSEgug9s36fKQ1CickuZd5mSFpRQwOdNJReQYM8ClyeiI5/VFSYDiDidmIbXxNtzl/XGWdmGlHqNrKx5PItXIhyX+SYyNb24UmIJuaM+REV1V5BtcRpMPN+GEJ1TojHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792068412; c=relaxed/simple; bh=zDN7SNuYuh1g08zUdIuQFmX0WMNo+t2hPuwvDFZNQfs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Awo4n0diFeqfGXIaRIpwCeQlHkVui6KNo0M+2v9jZ93NBeBFfzlFPT3K7jaVq/ZBz+4oVn10DmhU/wTX03WJxIry/+adVv05I7Q9o7hesB7JR2EMO5P8zTdrIbp5efB22StKcPge/OLit5LWe9mcIE2ABn8EdA/ZSmDjJ63V8cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=PDu7uvLa; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="PDu7uvLa" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC6B31516; Thu, 15 Oct 2026 05:46:46 -0700 (PDT) Received: from [10.0.129.161] (e122027.cambridge.arm.com [10.0.129.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC0DD3F871; Thu, 15 Oct 2026 05:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1792068410; bh=zDN7SNuYuh1g08zUdIuQFmX0WMNo+t2hPuwvDFZNQfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PDu7uvLaWetg/UZzUKAIERfgfuFOap7SByK1JkadoWjk9NqTPmqn/s34e34U97MoK jGzvVyBXHC/pzoEHOxhKklEXiMAdO+BgHVADWNJf3Q8LmmLEn8wJ4K54laU3LzUir6 MHwsw/CEPYnl+H+Er/7vdChxdnIflDjnUE0Qrc9U= Message-ID: Date: Thu, 15 Oct 2026 13:46:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] drm/panthor: Remove redundant drm_gem_create_mmap_offset() call from BO_MMAP_OFFSET ioctl To: Akash Goel , boris.brezillon@collabora.com, liviu.dudau@arm.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com References: <20261013125433.26432-1-akash.goel@arm.com> <20261013125433.26432-2-akash.goel@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20261013125433.26432-2-akash.goel@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/10/2026 13:54, Akash Goel wrote: > This commit removes the call to drm_gem_create_mmap_offset() from > the BO_MMAP_OFFSET ioctl handler. The call was redundant and didn't > have any effect as file offset range is allocated unconditionally > at the BO creation time. > > v2: > - New patch > > Suggested-by: Boris Brezillon > Signed-off-by: Akash Goel Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index 1ca8aedd83f4..dc8d0191aef4 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1081,7 +1081,7 @@ static int panthor_ioctl_bo_mmap_offset(struct drm_device *ddev, void *data, > struct drm_panthor_bo_mmap_offset *args = data; > struct panthor_gem_object *bo; > struct drm_gem_object *obj; > - int ret; > + int ret = 0; > > if (args->pad) > return -EINVAL; > @@ -1096,10 +1096,6 @@ static int panthor_ioctl_bo_mmap_offset(struct drm_device *ddev, void *data, > goto out; > } > > - ret = drm_gem_create_mmap_offset(obj); > - if (ret) > - goto out; > - > args->offset = drm_vma_node_offset_addr(&obj->vma_node); > > out: