From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B135CC433EF for ; Mon, 7 Mar 2022 02:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234864AbiCGCqU (ORCPT ); Sun, 6 Mar 2022 21:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233993AbiCGCqS (ORCPT ); Sun, 6 Mar 2022 21:46:18 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69595F6E for ; Sun, 6 Mar 2022 18:45:25 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id p3-20020a17090a680300b001bbfb9d760eso15334954pjj.2 for ; Sun, 06 Mar 2022 18:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MqTvzhnDnNsM5gc1jxNKVsqHTeWOImRbSBaH/Le+AV0=; b=ii0KSuBKQb6dIjrfOwNM5mk/9+Nq7Hgn9DTHrwdUkgL/ZLQLBBKluI3Iwlmv8Zu1O4 Q8/j77axaUB3XVjJ72tcgzUH8A4jWRlTK5rp7S6IQ0j7DWMJpCmQZidE1zpTVZ6rE19a XJXOL96PemSMSQwhyECg4jWBTKm06QfU2quY23E0II6hHrppbQ9TsirSKEmILBMVNz8/ bCdC9cURTp3hMsgFnMlrhoNl4n+ATpabzkW2Z0rpr9zQIH4Yr2xTEbXqKed2RxmmlJ7a b/EF2ho6JLko+gIQb3pK4xJQsa2D7+REwDPDyFkd18tHDpzyUN6cCmuySwm7Nv4EXGU0 YyRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MqTvzhnDnNsM5gc1jxNKVsqHTeWOImRbSBaH/Le+AV0=; b=VLxzLl8tVEJxstfbGd1nVv03NFG2LWRURjPFbmi5A932djefSjs6DLbx5UrWbkzpdL KtHln0VWOaXKacPopfRppR7GVp+ccrOx09N9KinPO4PE8XDqdfbFiftfCgDrbKxmhgah jf9Nl7oVeLzEoqqH3Ona9tKfvrCH/B5eHeRWD+JEC/4YgdgxEMd3jLtOtPFvEQSrQjwS +uU+5dC/eYu+immWmNr6pnId39r18FNBBeZcLZ7oH5t5lpBbtTeV33tXljls9LMPEf7U zM7YD5g0QjEkgnmuMoz5mRrX8HZwpRCOF4lO5vir4Ci8xvY5BoFBIQ87j+ahgtnotyQz vCAw== X-Gm-Message-State: AOAM533McHY0IAkiodGy8/xHd85B3eqk2RKkKk820Avvos0VJArDKkkw 2IzfQNZoxOrLz16JLPQcOGxUqw== X-Google-Smtp-Source: ABdhPJx9z16gRqP9k0HLwPVJ/PCks1UzrTHcjIYRn5tv8E0ldU0gePkCgrzBhpbw4mb5hbFv4roBfw== X-Received: by 2002:a17:902:7143:b0:151:eea7:bc62 with SMTP id u3-20020a170902714300b00151eea7bc62mr1578566plm.122.1646621125042; Sun, 06 Mar 2022 18:45:25 -0800 (PST) Received: from [10.76.15.169] ([61.120.150.76]) by smtp.gmail.com with ESMTPSA id nn5-20020a17090b38c500b001bf09d6c7d7sm11087532pjb.26.2022.03.06.18.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Mar 2022 18:45:24 -0800 (PST) Subject: Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto To: arei.gonglei@huawei.com, mst@redhat.com Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, helei.sig11@bytedance.com, cohuck@redhat.com References: <20220302033917.1295334-1-pizhenwei@bytedance.com> From: zhenwei pi Message-ID: Date: Mon, 7 Mar 2022 10:42:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220302033917.1295334-1-pizhenwei@bytedance.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Michael & Lei The full patchset has been reviewed by Gonglei, thanks to Gonglei. Should I modify the virtio crypto specification(use "__le32 akcipher_algo;" instead of "__le32 reserve;" only, see v1->v2 change), and start a new issue for a revoting procedure? Also cc Cornelia Huck. On 3/2/22 11:39 AM, zhenwei pi wrote: > v2 -> v3: > Rename virtio_crypto_algs.c to virtio_crypto_skcipher_algs.c, and > minor changes of function name. > Minor changes in virtio_crypto_akcipher_algs.c: no need to copy from > buffer if opcode is verify. > > v1 -> v2: > Fix 1 compiling warning reported by kernel test robot > Put "__le32 akcipher_algo;" instead of "__le32 reserve;" field of > struct virtio_crypto_config directly without size change. > Add padding in struct virtio_crypto_ecdsa_session_para to keep > 64-bit alignment. > Remove irrelevant change by code format alignment. > > Also CC crypto gurus Herbert and linux-crypto@vger.kernel.org. > > Test with QEMU(patched by the v2 version), works fine. > > v1: > Introduce akcipher service, implement RSA algorithm, and a minor fix. > > zhenwei pi (4): > virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC > virtio-crypto: introduce akcipher service > virtio-crypto: implement RSA algorithm > virtio-crypto: rename skcipher algs > > drivers/crypto/virtio/Makefile | 3 +- > .../virtio/virtio_crypto_akcipher_algs.c | 585 ++++++++++++++++++ > drivers/crypto/virtio/virtio_crypto_common.h | 7 +- > drivers/crypto/virtio/virtio_crypto_core.c | 6 +- > drivers/crypto/virtio/virtio_crypto_mgr.c | 15 +- > ...o_algs.c => virtio_crypto_skcipher_algs.c} | 4 +- > include/uapi/linux/virtio_crypto.h | 82 ++- > 7 files changed, 693 insertions(+), 9 deletions(-) > create mode 100644 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c > rename drivers/crypto/virtio/{virtio_crypto_algs.c => virtio_crypto_skcipher_algs.c} (99%) > -- zhenwei pi