Re: [PATCH] net: retain NOCARRIER on protodown interfaces

[Paolo Abeni <pabeni@redhat.com>]

On 9/27/24 09:33, Volodymyr Boyko wrote:
> Make interface with enabled protodown to retain NOCARRIER state during
> transfer of operstate from its lower device.
> 
> Signed-off-by: Volodymyr Boyko <boyko.cxx@gmail.com>
> ---
> Currently bringing up lower device enables carrier on upper devices
> ignoring the protodown flag.
> 
> Steps to reproduce:
> ```
> ip l a test0 up type dummy
> ip l a test0.mv0 up link test0 type macvlan mode bridge
> ip l s test0.mv0 protodown on
> sleep 1
> printf 'before flap:\n'
> ip -o l show | grep test0
> ip l set down test0 && ip l set up test0
> printf 'after flap:\n'
> ip -o l show | grep test0
> ip l del test0
> ```
> 
> output without this change:
> ```
> before flap:
> 28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
> 	 state LOWERLAYERDOWN protodown on
> after flap:
> 28: test0.mv0@test0: <BROADCAST,MULTICAST,UP,LOWER_UP>
> 	 state UP protodown on
> ```
> 
> output with this change:
> ```
> before flap:
> 28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
> 	state DOWN protodown on
> after flap:
> 28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
> 	state DOWN protodown on
> ```

I'm unsure we can accept this change of behavior: existing user-space 
application may rely on the existing one. I tend to stay on the safe side.

Paolo