mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
	"Felix Gu" <ustc.gu@gmail.com>,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Hans Zhang" <hans.zhang@cixtech.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Rob Herring" <robh@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Hans Zhang <18255117159@163.com>
Subject: Re: [PATCH] PCI: sky1: Fix missing cleanup of ECAM config on probe failure
Date: Tue, 24 Mar 2026 19:54:32 +0100	[thread overview]
Message-ID: <a9db10d6-6db9-4939-86e2-f8cd169e6d96@web.de> (raw)
In-Reply-To: <177433688851.20261.7315743280318704387.b4-ty@b4>

> > Add the missing pci_ecam_free() call to properly release the allocated
> > ECAM configuration window on this error path.
…
> Applied, thanks!
> 
> [1/1] PCI: sky1: Fix missing cleanup of ECAM config on probe failure
>       commit: 72e76b63d6ff6d1f96acccbfc6c118656f63e66a

Can the application of another goto chain become more desirable for
the implementation of the function “sky1_pcie_probe”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc5#n526

Regards,
Markus

      reply	other threads:[~2026-03-24 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 16:41 Felix Gu
2026-03-24  5:43 ` Hans Zhang
2026-03-24  7:21 ` Manivannan Sadhasivam
2026-03-24 18:54   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9db10d6-6db9-4939-86e2-f8cd169e6d96@web.de \
    --to=markus.elfring@web.de \
    --cc=18255117159@163.com \
    --cc=bhelgaas@google.com \
    --cc=hans.zhang@cixtech.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=ustc.gu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®