From: Paolo Abeni <pabeni@redhat.com>
To: Wang Ming <machel@vivo.com>, Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir()
Date: Thu, 13 Jul 2023 11:29:30 +0200 [thread overview]
Message-ID: <a9dc336793322d3525280e4f30b2acbd0c88bbf8.camel@redhat.com> (raw)
In-Reply-To: <20230713040518.13734-1-machel@vivo.com>
On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in ath6kl_debug_init_fs() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
>
> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs")
The SoB tag should be after the 'Fixes' one and you must avoid empty
lines in between.
(The same applies to your other patch)
Cheers,
Paolo
next prev parent reply other threads:[~2023-07-13 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 4:05 Wang Ming
2023-07-13 9:29 ` Paolo Abeni [this message]
[not found] ` <SG2PR06MB374387D043556FE8AEAA6ED9BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-13 9:43 ` 回复: " Paolo Abeni
2023-07-20 6:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9dc336793322d3525280e4f30b2acbd0c88bbf8.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®