From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbcHRHXy (ORCPT ); Thu, 18 Aug 2016 03:23:54 -0400 Received: from mga09.intel.com ([134.134.136.24]:26011 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbcHRHXw (ORCPT ); Thu, 18 Aug 2016 03:23:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,538,1464678000"; d="scan'208";a="750306456" Subject: Re: [PATCH] mmc: core: need retune if error value is -EIO To: Shawn Lin , Ulf Hansson References: <1470299459-8478-1-git-send-email-shawn.lin@rock-chips.com> Cc: Jaehoon Chung , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 18 Aug 2016 10:19:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470299459-8478-1-git-send-email-shawn.lin@rock-chips.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/16 11:30, Shawn Lin wrote: > We need to do retune if receiving -EIO, otherwise we > could see debug dump like: > > [ 89.057226] bcmsdh_sdmmc: Failed to Read byte F1:@0x1001f=ff, Err: -5 > [ 89.058811] bcmsdh_sdmmc: Failed to Read byte F1:@0x1001f=ff, Err: -5 > [ 89.059415] bcmsdh_sdmmc: Failed to Read byte F1:@0x1000e=ff, Err: -84 > [ 89.254248] dwmmc_rockchip fe310000.dwmmc: Successfully tuned phase to 199 > [ 89.273912] dhd_set_suspend: Remove extra suspend setting > [ 89.274478] dhd_enable_packet_filter: enter, value = 0 > 64 bytes from 112.90.83.112: icmp_seq=24 ttl=53 time=1321 ms > 64 bytes from 112.90.83.112: icmp_seq=25 ttl=53 time=319 ms > 64 bytes from 112.90.83.112: icmp_seq=26 ttl=53 time=69.8 ms > 64 bytes from 112.90.83.112: icmp_seq=27 ttl=53 time=37.5 ms > ... > > In this case we see dw_mmc finally enter retune process, but > if this patch is applied, we could save more time to make it > work. Also many host drivers will generate -EIO, so this patch > can also prevent them from failing to enter retune process. The current logic is re-tune on CRC errors. -EIO isn't informative and drivers can use it for cases that clearly are not related to tuning. A driver can call mmc_retune_needed() itself in other cases. > > Signed-off-by: Shawn Lin > --- > > drivers/mmc/core/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index e55cde6..18d0af5 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -133,7 +133,8 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq) > /* Flag re-tuning needed on CRC errors */ > if ((cmd->opcode != MMC_SEND_TUNING_BLOCK && > cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) && > - (err == -EILSEQ || (mrq->sbc && mrq->sbc->error == -EILSEQ) || > + (err == -EILSEQ || err == -EIO || > + (mrq->sbc && mrq->sbc->error == -EILSEQ) || > (mrq->data && mrq->data->error == -EILSEQ) || > (mrq->stop && mrq->stop->error == -EILSEQ))) > mmc_retune_needed(host); >