From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FF92F29 for ; Mon, 28 Apr 2025 14:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745849768; cv=none; b=b5k9d8aOh0oq238dPgydF2g4VD7AS9ATciEVDVFFBTKQTX5WwohzTeu752wJ9iLtKTa6ZgzSAK29etEkH9fiwB7yKmxGBLyyLtAsCq+tkFlwdwL4kUauIOUkFx/a7PlcBHx/dyycWcKQ5QNau9fDBpKBjV98Lbl7Oo3XBEJehDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745849768; c=relaxed/simple; bh=7jpFf0X44mvZPBwHm4oi95YMAiHMwB3njgHS2bzbL6U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KKSsyGYIvnh3yYSU38yvXrHvlcJGoP/iCbz6ERdOjtVQrnrzWEx0vTAIZc0+DUKC4UX4clFCAgol2gocw4Ldn8WFNqi4YY2hWaldiJZAzxXYC+yGbOoftfmHZhIP0f45D+NVI6kTOSQemK7ywXBOrPxtVjVN9cvN5DRzAWL21v8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FWxqQTTQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FWxqQTTQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745849765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVeCmrqrUzw7XcCq/Od4x1SVTaUBINUIH5X6q+EccXM=; b=FWxqQTTQ7130GdvGTT2+0ExFlXju/EpheUZ0x5rUk30XNjlnIbmM94rISxbeuyfJLQIJ3G 8ZKnPrkbP7ivblENM+q24z/Z4dKCGYlbXOAJaP5f0a4tBwvRB3T8TC7YfIz2HZnCfkrTOT 9O2h2XLIfRR26muM8NZXs2TM2jFvE7k= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-ykXCCHRFPeqt3a6zrsOMRQ-1; Mon, 28 Apr 2025 10:16:04 -0400 X-MC-Unique: ykXCCHRFPeqt3a6zrsOMRQ-1 X-Mimecast-MFC-AGG-ID: ykXCCHRFPeqt3a6zrsOMRQ_1745849763 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ac28f255a36so337376566b.3 for ; Mon, 28 Apr 2025 07:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745849763; x=1746454563; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uVeCmrqrUzw7XcCq/Od4x1SVTaUBINUIH5X6q+EccXM=; b=uC80Nh2d9q8qDhp0kFO4eH9GUc4Dtu4KMfwsS2AKuG4yGOcBe3dDyWir1F9G6nwaI7 aUABkkP7PpD1oW66wu3jCIJBwvHJv9xsNKg8uRuyTkBYY2oukEC4Lve2WIaXU7ckorgP k12WOvsLX5lbxCrjOiLHAea/AvZSEMbfCu10AzygB17hefinFryLVMBBO3V9Iay5ec73 Cb4oDF6tjTpHwYm/stIyef0abQ3GfcVa5WuVv7lf4fBfOddH55eMrL9oHJ8nBf/bNCj8 BVuJeoyjCnFx9VO3cup5M4CHzwTbVgsX8R6by2Rmcl55O/VG452jVFAgIY5ovDu1gbLY kBMQ== X-Forwarded-Encrypted: i=1; AJvYcCXSbBeNE4DuoOYQPCGhdb+bUfKJ5xjwpgsrxYuSlIaNyKCbqG86KASidDU5unNzWwz9TI53sfziTECaN70=@vger.kernel.org X-Gm-Message-State: AOJu0YzYz1aILfBetLz6j8YTlGinFR3m/Jz17q4n17BcwFqGVxIXOFcF 44Y1CQhVBlbtWlMbUav9jSoDTQtRX6lNBg+Np/tDYYn1Iz6Teyp0fdDoP2bKBHPLma6fLwXZOiW 9AL9VRNKbv+dXUHR0HkF/CWoPlzWR/wTnjMMJRmOO4pfeh5sOSAh+JqUYhW4zp6JIBDT2pw== X-Gm-Gg: ASbGncs45w7Gi1KqzgII9rm/1xgExrQGFVK+wURyOuNmhTzkbK0Np/7vGf/cghLR1TA /hgXjtEIOgaXtdspQWsIENOc/HcOm/qxjFuOZyWXUws8NZaZ4sP2G5c4hJysBTRjURJezzADwJw vlydjj4EgwoJc7NYPRACYBCa4JVaGACNBk35hX4Koclrsr5GXuQk0tW2LVohZaivagF0WG+kx5j c/QgSVnmdX32VhnnsRqwN/eIk8YzRIk/2XZkqgPeDQVVMt7SBWVWtvl69VVykWXU74W2XkIXnsz otECWtCVmeGEDQY= X-Received: by 2002:a17:907:720d:b0:ace:3ede:9d26 with SMTP id a640c23a62f3a-ace711175b7mr1232459466b.27.1745849762804; Mon, 28 Apr 2025 07:16:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR/e9QmbwHOiCLBIV4zMYiJpJwXtmPx7xY++qV/czLNz8zUG7J1jnJV/Ws/7DrjDPUG1JACw== X-Received: by 2002:a17:907:720d:b0:ace:3ede:9d26 with SMTP id a640c23a62f3a-ace711175b7mr1232455266b.27.1745849762340; Mon, 28 Apr 2025 07:16:02 -0700 (PDT) Received: from [10.40.98.122] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f7013ff9c5sm5977861a12.28.2025.04.28.07.16.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 07:16:01 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 16:16:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] platform/x86: int3472: add hpd pin support To: Dongcheng Yan , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl, andriy.shevchenko@linux.intel.com, u.kleine-koenig@baylibre.com, ricardo.ribalda@gmail.com, bingbu.cao@linux.intel.com Cc: stable@vger.kernel.org, dongcheng.yan@linux.intel.com, hao.yao@intel.com References: <20250425104331.3165876-1-dongcheng.yan@intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250425104331.3165876-1-dongcheng.yan@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 25-Apr-25 12:43, Dongcheng Yan wrote: > Typically HDMI to MIPI CSI-2 bridges have a pin to signal image data is > being received. On the host side this is wired to a GPIO for polling or > interrupts. This includes the Lontium HDMI to MIPI CSI-2 bridges > lt6911uxe and lt6911uxc. > > The GPIO "hpd" is used already by other HDMI to CSI-2 bridges, use it > here as well. > > Signed-off-by: Dongcheng Yan Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel/int3472/common.h | 1 + > drivers/platform/x86/intel/int3472/discrete.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/common.h b/drivers/platform/x86/intel/int3472/common.h > index 51b818e62a25..4593d567caf4 100644 > --- a/drivers/platform/x86/intel/int3472/common.h > +++ b/drivers/platform/x86/intel/int3472/common.h > @@ -23,6 +23,7 @@ > #define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c > #define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d > #define INT3472_GPIO_TYPE_HANDSHAKE 0x12 > +#define INT3472_GPIO_TYPE_HOTPLUG_DETECT 0x13 > > #define INT3472_PDEV_MAX_NAME_LEN 23 > #define INT3472_MAX_SENSOR_GPIOS 3 > diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c > index 394975f55d64..efa3bc7af193 100644 > --- a/drivers/platform/x86/intel/int3472/discrete.c > +++ b/drivers/platform/x86/intel/int3472/discrete.c > @@ -191,6 +191,10 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3 > *con_id = "privacy-led"; > *gpio_flags = GPIO_ACTIVE_HIGH; > break; > + case INT3472_GPIO_TYPE_HOTPLUG_DETECT: > + *con_id = "hpd"; > + *gpio_flags = GPIO_ACTIVE_HIGH; > + break; > case INT3472_GPIO_TYPE_POWER_ENABLE: > *con_id = "avdd"; > *gpio_flags = GPIO_ACTIVE_HIGH; > @@ -221,6 +225,7 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3 > * 0x0b Power enable > * 0x0c Clock enable > * 0x0d Privacy LED > + * 0x13 Hotplug detect > * > * There are some known platform specific quirks where that does not quite > * hold up; for example where a pin with type 0x01 (Power down) is mapped to > @@ -290,6 +295,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, > switch (type) { > case INT3472_GPIO_TYPE_RESET: > case INT3472_GPIO_TYPE_POWERDOWN: > + case INT3472_GPIO_TYPE_HOTPLUG_DETECT: > ret = skl_int3472_map_gpio_to_sensor(int3472, agpio, con_id, gpio_flags); > if (ret) > err_msg = "Failed to map GPIO pin to sensor\n"; > > base-commit: 4d1e8c8f11c611db5828e4bae7292bc295eea8ef