From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63DA7262A for ; Tue, 23 Dec 2025 07:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766473718; cv=none; b=fKrrLZehGDBrz45IrY1aL2NQAXiW5r60TKfuB60oWgmFghf2OG+UqvvN9T35Apr2aX/mEAAgTnlW7u7DZNifDZ3uLKJuv/k2PcF2MPxfbhz8TbyhxgsqO28/cENbk+4asi5on9E93+gth0tbsGBg5lr064hkklHiOe0CPQSOD9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766473718; c=relaxed/simple; bh=Ot1113sdR4ICLww8kH8UrumoMzAywen+S30YAGh6fWQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e9pAoi9HeFiPVO95miytL4JW+O5tgEKCZT6+JxcETRYM4JbIr9Tzkw+Tss+cm9BdAY8gd+3IoMHTMbpSjstlDAEXtGyKjcXFIGyRs+XmeghTdgXNbi42FZKPv8r4nt5rLOvlZqFxM4ZHAt9GVfWXB34P0TXw9Tyik8HFXY2JXzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E3Iizvum; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XKMpl4wt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E3Iizvum"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XKMpl4wt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766473715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10niOhLQWj8MZ1UX89LR/k7WodLz7bBsvamkj7DQNao=; b=E3IizvumxoDNaeGLKilDnjMQBglzKg+MfgqsB9oefSwfw3I2/UsmL+PXbuROjRFcb9QLM6 yjRxLOuTMultvmjWEVlR+qJ9KTW5Ie07L1LgRQ+vVZbedgZih5jjsUR+8mi/CQPxgoy/zz nHYSS8bKvqzcGyCVy5tb55YmYUTuzzQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-5hgz4JFcPlGc-0HNJlsRyQ-1; Tue, 23 Dec 2025 02:08:34 -0500 X-MC-Unique: 5hgz4JFcPlGc-0HNJlsRyQ-1 X-Mimecast-MFC-AGG-ID: 5hgz4JFcPlGc-0HNJlsRyQ_1766473713 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-430fcb6b2ebso2563483f8f.2 for ; Mon, 22 Dec 2025 23:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766473713; x=1767078513; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=10niOhLQWj8MZ1UX89LR/k7WodLz7bBsvamkj7DQNao=; b=XKMpl4wt2llCEackzl4Gv+41R48CAiCr6zmCjEPGhh16oCWA6odVpYZ6WD2WsbfTrb xbXxFsk9+s81DT7qYUCUviOtafZuPoPLTTBjCq169NZ+nIAAplIE0e2OSqq00tvDDW5R IPmL8SJWHvS7YZ5tnDDBehPAWGwuBsxh84iXeuhtmtWbtrgnDSlfbwjwZ7NfFhkwsMK7 mIe6/CFG6VXAzcQ2YxoS6q66Wy9KYCSJ0jqZv5fOmywuCbmrio/AJO0/LKIFEXMU9HsP g0S65bNnMnvEltZ2Y/4jxCUN2KE30D4TNnzu0Eq2O1nbZuhxCsmzXJRbWtAWK978L4/N ahTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766473713; x=1767078513; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=10niOhLQWj8MZ1UX89LR/k7WodLz7bBsvamkj7DQNao=; b=q+M9tsJwDA32M5PFoIuDd4A7yumFXlxIWHvqrCfRTaIUb8Ar/h8LtF+qFTwc4kn4n0 vtoSx/kbkabRYeqPjB8N6jGMMru8JIsFkSLU9+Pn4SAYDoRHVV8/mXCs0DVpJdItsxyw Qx0QiTbGxXBE/4hIBgM6Qt8h5VNgx5VnXF97IdzZLQEHGiPILyYOZ0ueIzOyyqcAoEoe fSWkclh+5ISKwSEWrKQZPe2QiIiiFMSwabatx/lWdl/KHLwBZXr1zNKvD3rpK8pszEqB /VJcF5hX6CuE6rtEdTkxLB/+gacq1KrZmgEjtAWNPDC+tXVi1REhEdCocYSQFf4G0G1V b/Rg== X-Gm-Message-State: AOJu0Yy1xpAfMNVzsKp2yD+MNIuBOwmN94/MiZqcKgequOxImt7v+9x8 ZtnW9fpbkV46c5d/F98Hm1b56jEgFhAYeSruecqGL5qyldY9iaySKZEUwrDNStNL0is7y9JrXug onIjluxuI52ejtkSm6o7N5gdz7yKmM4cSUw1Ju5LHTO582rLzZ+WdK/u+HKPP0IU92I9mj+hw2A == X-Gm-Gg: AY/fxX7TTv+xwItvuxXfcwuw+Z/OzROSPe8M255oh4rX/xFzr4IBYUVQ38UUX97XGrq 3ivl9W7E0yK3h//PNcDnTKiitdgbjlAkOd2cv2lm3U10/GY0yO+lFMUZMwUxesOh7al7WRBms/F NVd7ZQPhcfxXkOrpzOg2CbUtHcK/xlaGLa8xPpLT/8yxX9Wxnz3N766b3O75nFTKEHY6AgLqhUx cXjpuSsQlUqtmOiyiXhAq9cAemmsp3Z/VIBOxRFLjMDy+aGW2NUGWLv6oN6+pMPJ8wgh5FQ2Tus xrpEbYeCxP0AxvunLHhzO2x0my0WxxV7bmZfaNUFHc398U7vaT4jQP+JJ1+NAy0KDk5VdoWTslJ wQyrssjFzUpZZ X-Received: by 2002:a5d:5f54:0:b0:431:2b2:9628 with SMTP id ffacd0b85a97d-4324e506ba3mr13554578f8f.52.1766473712770; Mon, 22 Dec 2025 23:08:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2/F9cxhPn5IdB9dXseWhjktn4DNI+GITUDnXyOaDGSylCJE8I4qOMs0JTw7LLNZQx/CkEbQ== X-Received: by 2002:a5d:5f54:0:b0:431:2b2:9628 with SMTP id ffacd0b85a97d-4324e506ba3mr13554539f8f.52.1766473712281; Mon, 22 Dec 2025 23:08:32 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324e9ba877sm25879368f8f.0.2025.12.22.23.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 23:08:31 -0800 (PST) Message-ID: Date: Tue, 23 Dec 2025 08:08:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs To: "illusion.wang" , dimon.zhao@nebula-matrix.com, alvin.wang@nebula-matrix.com, sam.chen@nebula-matrix.com, netdev@vger.kernel.org Cc: open list References: <20251223035113.31122-1-illusion.wang@nebula-matrix.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251223035113.31122-1-illusion.wang@nebula-matrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/23/25 4:50 AM, illusion.wang wrote: > The patch series add the nbl driver, which will support the nebula-matrix 18100 and 18110 series > of network cards. > This submission is the first phase. which includes the PF-based and VF-based Ethernet transmit > and receive functionality. Once this is merged. will submit addition patches to implement support > for other features. such as ethtool support, debugfs support and etc. > Our Driver architecture supports Kernel Mode and Coexistence Mode(kernel and dpdk) Not a real review, but this series has several basic issues: - each patch should compile and build without warnings on all arches - don't use inline in c code - avoid using 'module_params' - the preferred line width is still 80 chars - strip changed-id from the commit message - respect the reverse christmas tree order for variable declaration - commit messages lines should be wrapped at 72 chars Note that you can clone the NIPA repository: https://github.com/linux-netdev/nipa/ and use the ingest_mdir.py script to validate most of the above check before submission (otherwise you should do that manually). However... ## Form letter - net-next-closed The net-next tree is closed for new drivers, features, code refactoring and optimizations due to the merge window and the winter break. We are currently accepting bug fixes only. Please repost when net-next reopens after Jan 2nd. RFC patches sent for review only are obviously welcome at any time.