From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966386AbdADJGq (ORCPT ); Wed, 4 Jan 2017 04:06:46 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:20057 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758584AbdADJGO (ORCPT ); Wed, 4 Jan 2017 04:06:14 -0500 X-AuditID: cbfec7f1-f79626d000005d7d-5e-586cbadcd5ef Subject: Re: [PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function To: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, inki.dae@samsung.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com From: Andrzej Hajda Message-id: Date: Wed, 04 Jan 2017 10:05:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <1483517711-23849-2-git-send-email-hoegeun.kwon@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsWy7djP87p3duVEGDx8r2bRe+4kk8X1L89Z LeYfOcdqceXrezaL98u72Cwm3Z/AYnHjVxurRf/j18wW589vYLe4vGsOm8WM8/uYLP7v2cFu 8XPXPBYHXo+ds+6ye2xa1cnmsf3bA1aP+93HmTz6tqxi9Pi8SS6ALYrLJiU1J7MstUjfLoEr 4+DJioJvnBVtv7IbGNs5uhg5OSQETCSm/r3BBmGLSVy4tx7I5uIQEljKKLF5RzOU85lR4t3K vUAOB1hHy+tciPgyRonTLbcZIZxnjBKnLrxnBhklLOAtca/3AytIQgRk1JO7TWAJZoHNjBLn T+eD2GwCmhJ/N98E280rYCex4Mc1dhCbRUBVYt7uKWC2qECExKFjt5khagQlfky+xwJicwp4 Sqy7uZQJYqaBxIwph6FseYnNa94ygyyWELjHLvH3wEIWiLNlJTYdYIb400XiScMFdghbWOLV 8S1QtozE5cndLBC93YwSn/pPsEM4Uxgl/n2YAdVtLXH4+EVWiG18EpO2TWeGWMAr0dEmBFHi IXF29REWCNtRYtexNlZIEN1mlLi1azbzBEb5WUgemoXkiVlInljAyLyKUSS1tDg3PbXYSK84 Mbe4NC9dLzk/dxMjMC2d/nf84w7G9yesDjEKcDAq8fCuWJQdIcSaWFZcmXuIUYKDWUmE99vW nAgh3pTEyqrUovz4otKc1OJDjNIcLErivHsWXAkXEkhPLEnNTk0tSC2CyTJxcEo1MAZ075ka UTHVvZ9//xtHySqGM6eELhvFbKl6on7TfuKpSdXf579ujzujcf1OH1v2S911dQqbtvX3MVtU CQSumNXXfM/4ekK/zZwTV2x0oqdM+3t70t9bLlcUD0tOrgqSdEvaqypy7enVgvJZQa3/pRhW 2M4694T5fW3ZevcpW/WS7vSG68+eaK7EUpyRaKjFXFScCACCxJP9RwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t/xa7qXduVEGDw5Jm7Re+4kk8X1L89Z LeYfOcdqceXrezaL98u72Cwm3Z/AYnHjVxurRf/j18wW589vYLe4vGsOm8WM8/uYLP7v2cFu 8XPXPBYHXo+ds+6ye2xa1cnmsf3bA1aP+93HmTz6tqxi9Pi8SS6ALcrNJiM1MSW1SCE1Lzk/ JTMv3VYpNMRN10JJIS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGQdPVhR846xo +5XdwNjO0cXIwSEhYCLR8jq3i5ETyBSTuHBvPVsXIxeHkMASRonF71azQzjPGCWm73/NDlIl LOAtca/3AytIQkRgKaPEk81HmCGqbjNKTFjVC9bPLLCZUWLf4zOMIC1sApoSfzffZAOxeQXs JBb8uAY2ikVAVWLe7insIHeICkRINBxOhygRlPgx+R4LiM0p4Cmx7uZSJpASZgE9ifsXtUDC zALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUSS0tzk3PLTbSK07MLS7NS9dLzs/dxAiMzm3H fm7Zwdj1LvgQowAHoxIPb8CC7Agh1sSy4srcQ4wSHMxKIrzftuZECPGmJFZWpRblxxeV5qQW H2I0BfpgIrOUaHI+MHHklcQbmhiaWxoaGVtYmBsZKYnzTv1wJVxIID2xJDU7NbUgtQimj4mD U6qBsePg9XdaGuor4ou87KeE6S8UnRuzzeuD4ecrrmscHbfFhTd5HXx2W/OGl6VBYFF758aY 5d9498++v3+ZQsH9iJ0fxda6Kl/zWbHF6mi70f/teWZN3UHGS3ovZDDcZg4R27WUfbleYFPX zFULXy4vmGmmGd+o0S4/77BYcNSbZHuzk2e6stRzlFiKMxINtZiLihMBn4GlKeQCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170104090532eucas1p1089491b11a0e2bed4a11bd8cdeddf937 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170104081521epcas1p40d5fbfbe0600d0df05e77b36ce6a353f X-RootMTR: 20170104081521epcas1p40d5fbfbe0600d0df05e77b36ce6a353f References: <1483517711-23849-1-git-send-email-hoegeun.kwon@samsung.com> <1483517711-23849-2-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.01.2017 09:15, Hoegeun Kwon wrote: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through > mode_set callback function. > > Signed-off-by: Hoegeun Kwon Reviewed-by: Andrzej Hajda Only one, non-blocking comment below. > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 30 +++++++++++++++++++----------- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0b..a0f459c 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -286,13 +286,6 @@ static int parse_dt(struct exynos_mic *mic) > } > nodes[j++] = remote_node; > > - ret = of_get_videomode(remote_node, > - &mic->vm, 0); > - if (ret) { > - DRM_ERROR("mic: failed to get videomode"); > - goto exit; > - } > - I think the whole parse_dt function should be refactored, but it can be done later in separate patch. Regards Andrzej