From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
fenglin.wu@oss.qualcomm.com
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2] leds: flash: leds-qcom-flash: Fix registry access after re-bind
Date: Thu, 29 May 2025 14:46:51 +0800 [thread overview]
Message-ID: <a9f260e1-c632-4955-b7d4-98fb024e2989@oss.qualcomm.com> (raw)
In-Reply-To: <20250529063335.8785-2-krzysztof.kozlowski@linaro.org>
On 5/29/2025 2:33 PM, Krzysztof Kozlowski wrote:
> Driver in probe() updates each of 'reg_field' with 'reg_base':
>
> for (i = 0; i < REG_MAX_COUNT; i++)
> regs[i].reg += reg_base;
>
> 'reg_field' array (under variable 'regs' above) is statically allocated,
> thus each re-bind would add another 'reg_base' leading to bogus
> register addresses. Constify the local 'reg_field' array and duplicate
> it in probe to solve this.
>
> Fixes: 96a2e242a5dc ("leds: flash: Add driver to support flash LED module in QCOM PMICs")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
next prev parent reply other threads:[~2025-05-29 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 6:33 Krzysztof Kozlowski
2025-05-29 6:46 ` Fenglin Wu [this message]
2025-06-13 13:46 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f260e1-c632-4955-b7d4-98fb024e2989@oss.qualcomm.com \
--to=fenglin.wu@oss.qualcomm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®