From: Markus Elfring <Markus.Elfring@web.de>
To: guanjing@cmss.chinamobile.com, Barret Rhoden <brho@google.com>,
David Vernet <void@manifault.com>, Hao Luo <haoluo@google.com>,
Josh Don <joshdon@google.com>, Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sched_ext: fix application of sizeof to pointer
Date: Mon, 18 Nov 2024 18:30:53 +0100 [thread overview]
Message-ID: <a9f86b63-6645-49e8-88d5-a5dbab2aaccd@web.de> (raw)
In-Reply-To: <20241116230258.140098-1-guanjing@cmss.chinamobile.com>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer.
>
> The proper fix in this particular case is to code sizeof(cpu_set_t)
> instead of sizeof(cpuset).
…
I suggest to reconsider this view once more.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.12#n941
Would the specification “sizeof(*cpuset)” be more appropriate here?
Regards,
Markus
prev parent reply other threads:[~2024-11-18 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 23:02 guanjing
2024-11-18 17:30 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f86b63-6645-49e8-88d5-a5dbab2aaccd@web.de \
--to=markus.elfring@web.de \
--cc=brho@google.com \
--cc=guanjing@cmss.chinamobile.com \
--cc=haoluo@google.com \
--cc=joshdon@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®